{"thread":{"id":"31566","subject":"[PATCH] fetch-pack.h: remove unnecessary #include","startedAt":"2012-09-17T15:15:10Z","lastAt":"2012-09-17T15:15:10Z","messageCount":1,"participants":["Michael Haggerty"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"199237","messageId":"1347894910-27624-1-git-send-email-mhagger@alum.mit.edu","threadId":"31566","inReplyTo":null,"subject":"[PATCH] fetch-pack.h: remove unnecessary #include","fromName":"Michael Haggerty","fromEmail":"mhagger@alum.mit.edu","sentAt":"2012-09-17T15:15:10Z","receivedAt":"2012-09-17T15:15:10Z","isPatch":true,"sender":{"key":"mhagger@alum.mit.edu","avatar":"https://avatars.githubusercontent.com/u/119718?v=4"},"body":"Given the git project policy that *.c files that include header files\nare responsible for including everything the headers they include\nneed, there is no need for fetch-pack.h to include string-list.h\nitself.  As for the files that include fetch-pack.h:\n\n* builtin/clone.c and builtin/fetch-pack.c\n  include builtin.h\n  which includes notes.h\n  which includes string-list.h\n\n* transport.c\n  includes string-list.h\n\nso no other adjustments are needed.\n\nSuggested by: Junio C Hamano <gitster@pobox.com>\n\nSigned-off-by: Michael Haggerty <mhagger@alum.mit.edu>\n---\n fetch-pack.h | 2 --\n 1 file changed, 2 deletions(-)\n\ndiff --git a/fetch-pack.h b/fetch-pack.h\nindex cb14871..018f35f 100644\n--- a/fetch-pack.h\n+++ b/fetch-pack.h\n@@ -1,8 +1,6 @@\n #ifndef FETCH_PACK_H\n #define FETCH_PACK_H\n \n-#include \"string-list.h\"\n-\n struct fetch_pack_args {\n \tconst char *uploadpack;\n \tint unpacklimit;\n-- \n1.7.11.3\n"}]}