{"thread":{"id":"31536","subject":"[PATCH] git-gui: Fix semi-working shortcuts for unstage and revert","startedAt":"2012-09-14T23:36:41Z","lastAt":"2012-09-17T10:47:01Z","messageCount":3,"participants":["vi0oss@gmail.com","Bert Wesarg","Pat Thoyts"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"199084","messageId":"1347665801-22634-1-git-send-email-vi0oss@gmail.com","threadId":"31536","inReplyTo":null,"subject":"[PATCH] git-gui: Fix semi-working shortcuts for unstage and revert","fromName":"","fromEmail":"vi0oss@gmail.com","sentAt":"2012-09-14T23:36:41Z","receivedAt":"2012-09-14T23:36:41Z","isPatch":true,"sender":{"key":"vi0oss@gmail.com","avatar":"https://avatars.githubusercontent.com/u/173219?v=4"},"body":"From: Vitaly _Vi Shukela <vi0oss@gmail.com>\n\nMake Ctrl+U for unstaging and Ctrl+J for reverting selection behave\nmore like Ctrl+T for adding.\n\nThey were working only when one area was focused (diff or commit message),\nnow they should work everywhere.\n\nSigned-off-by: Vitaly _Vi Shukela <vi0oss@gmail.com>\n---\nSending the patch the third time (haven't got any replies to previous two attempts).\n\n git-gui/git-gui.sh |    4 ++++\n 1 files changed, 4 insertions(+), 0 deletions(-)\n\ndiff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\nindex ba4e5c1..6618016 100755\n--- a/git-gui/git-gui.sh\n+++ b/git-gui/git-gui.sh\n@@ -3710,6 +3710,8 @@ bind $ui_diff <$M1B-Key-v> {break}\n bind $ui_diff <$M1B-Key-V> {break}\n bind $ui_diff <$M1B-Key-a> {%W tag add sel 0.0 end;break}\n bind $ui_diff <$M1B-Key-A> {%W tag add sel 0.0 end;break}\n+bind $ui_diff <$M1B-Key-j> {do_revert_selection;break}\n+bind $ui_diff <$M1B-Key-J> {do_revert_selection;break}\n bind $ui_diff <Key-Up>     {catch {%W yview scroll -1 units};break}\n bind $ui_diff <Key-Down>   {catch {%W yview scroll  1 units};break}\n bind $ui_diff <Key-Left>   {catch {%W xview scroll -1 units};break}\n@@ -3742,6 +3744,8 @@ bind .   <$M1B-Key-s> do_signoff\n bind .   <$M1B-Key-S> do_signoff\n bind .   <$M1B-Key-t> do_add_selection\n bind .   <$M1B-Key-T> do_add_selection\n+bind .   <$M1B-Key-u> do_unstage_selection\n+bind .   <$M1B-Key-U> do_unstage_selection\n bind .   <$M1B-Key-j> do_revert_selection\n bind .   <$M1B-Key-J> do_revert_selection\n bind .   <$M1B-Key-i> do_add_all\n-- \n1.7.8.5\n"},{"id":"199092","messageId":"CAKPyHN0_GVwCzrmH1YJu-cgGrPSQ3eqgFM8Ad1JJP8ZpF7Dx9w@mail.gmail.com","threadId":"31536","inReplyTo":"1347665801-22634-1-git-send-email-vi0oss@gmail.com","subject":"Re: [PATCH] git-gui: Fix semi-working shortcuts for unstage and revert","fromName":"Bert Wesarg","fromEmail":"bert.wesarg@googlemail.com","sentAt":"2012-09-15T11:04:42Z","receivedAt":"2012-09-15T11:04:42Z","isPatch":true,"sender":{"key":"bert.wesarg@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/111934?v=4"},"body":"On Sat, Sep 15, 2012 at 1:36 AM,  <vi0oss@gmail.com> wrote:\n> From: Vitaly _Vi Shukela <vi0oss@gmail.com>\n>\n> Make Ctrl+U for unstaging and Ctrl+J for reverting selection behave\n> more like Ctrl+T for adding.\n>\n> They were working only when one area was focused (diff or commit message),\n> now they should work everywhere.\n>\n> Signed-off-by: Vitaly _Vi Shukela <vi0oss@gmail.com>\n> ---\n> Sending the patch the third time (haven't got any replies to previous two attempts).\n\nFor what its worth:\n\nAcked-by: Bert Wesarg <bert.wesarg@googlemail.com>\n\nBut unless Pat reacts this is useless.\n\nBert\n\n>\n>  git-gui/git-gui.sh |    4 ++++\n>  1 files changed, 4 insertions(+), 0 deletions(-)\n>\n> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\n> index ba4e5c1..6618016 100755\n> --- a/git-gui/git-gui.sh\n> +++ b/git-gui/git-gui.sh\n> @@ -3710,6 +3710,8 @@ bind $ui_diff <$M1B-Key-v> {break}\n>  bind $ui_diff <$M1B-Key-V> {break}\n>  bind $ui_diff <$M1B-Key-a> {%W tag add sel 0.0 end;break}\n>  bind $ui_diff <$M1B-Key-A> {%W tag add sel 0.0 end;break}\n> +bind $ui_diff <$M1B-Key-j> {do_revert_selection;break}\n> +bind $ui_diff <$M1B-Key-J> {do_revert_selection;break}\n>  bind $ui_diff <Key-Up>     {catch {%W yview scroll -1 units};break}\n>  bind $ui_diff <Key-Down>   {catch {%W yview scroll  1 units};break}\n>  bind $ui_diff <Key-Left>   {catch {%W xview scroll -1 units};break}\n> @@ -3742,6 +3744,8 @@ bind .   <$M1B-Key-s> do_signoff\n>  bind .   <$M1B-Key-S> do_signoff\n>  bind .   <$M1B-Key-t> do_add_selection\n>  bind .   <$M1B-Key-T> do_add_selection\n> +bind .   <$M1B-Key-u> do_unstage_selection\n> +bind .   <$M1B-Key-U> do_unstage_selection\n>  bind .   <$M1B-Key-j> do_revert_selection\n>  bind .   <$M1B-Key-J> do_revert_selection\n>  bind .   <$M1B-Key-i> do_add_all\n> --\n> 1.7.8.5\n>\n"},{"id":"199211","messageId":"87haqxj596.fsf@fox.patthoyts.tk","threadId":"31536","inReplyTo":"1347665801-22634-1-git-send-email-vi0oss@gmail.com","subject":"Re: [PATCH] git-gui: Fix semi-working shortcuts for unstage and revert","fromName":"Pat Thoyts","fromEmail":"patthoyts@users.sourceforge.net","sentAt":"2012-09-17T10:47:01Z","receivedAt":"2012-09-17T10:47:01Z","isPatch":true,"sender":{"key":"patthoyts@users.sourceforge.net","avatar":"https://avatars.githubusercontent.com/u/30739?v=4"},"body":"vi0oss@gmail.com writes:\n\n>From: Vitaly _Vi Shukela <vi0oss@gmail.com>\n>\n>Make Ctrl+U for unstaging and Ctrl+J for reverting selection behave\n>more like Ctrl+T for adding.\n>\n>They were working only when one area was focused (diff or commit message),\n>now they should work everywhere.\n>\n>Signed-off-by: Vitaly _Vi Shukela <vi0oss@gmail.com>\n>---\n>Sending the patch the third time (haven't got any replies to previous two attempts).\n>\n> git-gui/git-gui.sh |    4 ++++\n> 1 files changed, 4 insertions(+), 0 deletions(-)\n>\n>diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\n>index ba4e5c1..6618016 100755\n>--- a/git-gui/git-gui.sh\n>+++ b/git-gui/git-gui.sh\n>@@ -3710,6 +3710,8 @@ bind $ui_diff <$M1B-Key-v> {break}\n> bind $ui_diff <$M1B-Key-V> {break}\n> bind $ui_diff <$M1B-Key-a> {%W tag add sel 0.0 end;break}\n> bind $ui_diff <$M1B-Key-A> {%W tag add sel 0.0 end;break}\n>+bind $ui_diff <$M1B-Key-j> {do_revert_selection;break}\n>+bind $ui_diff <$M1B-Key-J> {do_revert_selection;break}\n> bind $ui_diff <Key-Up>     {catch {%W yview scroll -1 units};break}\n> bind $ui_diff <Key-Down>   {catch {%W yview scroll  1 units};break}\n> bind $ui_diff <Key-Left>   {catch {%W xview scroll -1 units};break}\n>@@ -3742,6 +3744,8 @@ bind .   <$M1B-Key-s> do_signoff\n> bind .   <$M1B-Key-S> do_signoff\n> bind .   <$M1B-Key-t> do_add_selection\n> bind .   <$M1B-Key-T> do_add_selection\n>+bind .   <$M1B-Key-u> do_unstage_selection\n>+bind .   <$M1B-Key-U> do_unstage_selection\n> bind .   <$M1B-Key-j> do_revert_selection\n> bind .   <$M1B-Key-J> do_revert_selection\n> bind .   <$M1B-Key-i> do_add_all\n\nLooks good to me. Applied.\n\nThank you. \n\n-- \nPat Thoyts                            http://www.patthoyts.tk/\nPGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD\n"}]}