{"thread":{"id":"31465","subject":"[PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile","startedAt":"2012-09-07T12:10:49Z","lastAt":"2012-09-08T15:23:00Z","messageCount":5,"participants":["Joachim Schmitz","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"198515","messageId":"003301cd8cf1$d26258c0$77270a40$@schmitz-digital.de","threadId":"31465","inReplyTo":null,"subject":"[PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-09-07T12:10:49Z","receivedAt":"2012-09-07T12:10:49Z","isPatch":true,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"\nSigned-off-by: Joachim Schmitz <jojo@schmitz-digital.de>\n---\n Makefile | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/Makefile b/Makefile\nindex ac49320..03e245a 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -90,6 +90,8 @@ all::\n #\n # Define NO_MKDTEMP if you don't have mkdtemp in the C library.\n #\n+# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.\n+#\n # Define NO_MKSTEMPS if you don't have mkstemps in the C library.\n #\n # Define NO_STRTOK_R if you don't have strtok_r in the C library.\n-- \n1.7.12\n"},{"id":"198535","messageId":"7vsjatyc9e.fsf@alter.siamese.dyndns.org","threadId":"31465","inReplyTo":"003301cd8cf1$d26258c0$77270a40$@schmitz-digital.de","subject":"Re: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-09-07T17:27:09Z","receivedAt":"2012-09-07T17:27:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"},{"id":"198536","messageId":"7vliglyc5g.fsf@alter.siamese.dyndns.org","threadId":"31465","inReplyTo":"003301cd8cf1$d26258c0$77270a40$@schmitz-digital.de","subject":"Re: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-09-07T17:29:31Z","receivedAt":"2012-09-07T17:29:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Joachim Schmitz\" <jojo@schmitz-digital.de> writes:\n\n> Signed-off-by: Joachim Schmitz <jojo@schmitz-digital.de>\n> ---\n>  Makefile | 2 ++\n>  1 file changed, 2 insertions(+)\n>\n> diff --git a/Makefile b/Makefile\n> index ac49320..03e245a 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -90,6 +90,8 @@ all::\n>  #\n>  # Define NO_MKDTEMP if you don't have mkdtemp in the C library.\n>  #\n> +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.\n> +#\n>  # Define NO_MKSTEMPS if you don't have mkstemps in the C library.\n>  #\n>  # Define NO_STRTOK_R if you don't have strtok_r in the C library.\n\nNot really.  \"make MKDIR_WO_TRAILING_SLASH=YesPlease\" won't do\nanything.\n\nYou would need at least something like this, no?\n\n Makefile | 5 +++++\n 1 file changed, 5 insertions(+)\n\ndiff --git c/Makefile w/Makefile\nindex 66e8216..21b4816 100644\n--- c/Makefile\n+++ w/Makefile\n@@ -90,6 +90,8 @@ all::\n #\n # Define NO_MKDTEMP if you don't have mkdtemp in the C library.\n #\n+# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.\n+#\n # Define NO_MKSTEMPS if you don't have mkstemps in the C library.\n #\n # Define NO_STRTOK_R if you don't have strtok_r in the C library.\n@@ -1639,6 +1641,9 @@ ifdef NO_MKDTEMP\n \tCOMPAT_CFLAGS += -DNO_MKDTEMP\n \tCOMPAT_OBJS += compat/mkdtemp.o\n endif\n+ifdef MKDIR_WO_TRAILING_SLASH\n+\tCOMPAT_CFLAGS += -DMKDIR_WO_TRAILING_SLASH\n+endif\n ifdef NO_MKSTEMPS\n \tCOMPAT_CFLAGS += -DNO_MKSTEMPS\n endif\n"},{"id":"198539","messageId":"004601cd8d26$8475f8d0$8d61ea70$@schmitz-digital.de","threadId":"31465","inReplyTo":"7vliglyc5g.fsf@alter.siamese.dyndns.org","subject":"RE: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-09-07T18:28:02Z","receivedAt":"2012-09-07T18:28:02Z","isPatch":true,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"\n\n> -----Original Message-----\n> From: Junio C Hamano [mailto:gitster@pobox.com]\n> Sent: Friday, September 07, 2012 7:30 PM\n> To: Joachim Schmitz\n> Cc: git@vger.kernel.org\n> Subject: Re: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile\n> \n> \"Joachim Schmitz\" <jojo@schmitz-digital.de> writes:\n> \n> > Signed-off-by: Joachim Schmitz <jojo@schmitz-digital.de>\n> > ---\n> >  Makefile | 2 ++\n> >  1 file changed, 2 insertions(+)\n> >\n> > diff --git a/Makefile b/Makefile\n> > index ac49320..03e245a 100644\n> > --- a/Makefile\n> > +++ b/Makefile\n> > @@ -90,6 +90,8 @@ all::\n> >  #\n> >  # Define NO_MKDTEMP if you don't have mkdtemp in the C library.\n> >  #\n> > +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.\n> > +#\n> >  # Define NO_MKSTEMPS if you don't have mkstemps in the C library.\n> >  #\n> >  # Define NO_STRTOK_R if you don't have strtok_r in the C library.\n> \n> Not really.  \"make MKDIR_WO_TRAILING_SLASH=YesPlease\" won't do\n> anything.\n> \n> You would need at least something like this, no?\n>\n\nYes, that is better, thanks\n\n>  Makefile | 5 +++++\n>  1 file changed, 5 insertions(+)\n> \n> diff --git c/Makefile w/Makefile\n> index 66e8216..21b4816 100644\n> --- c/Makefile\n> +++ w/Makefile\n> @@ -90,6 +90,8 @@ all::\n>  #\n>  # Define NO_MKDTEMP if you don't have mkdtemp in the C library.\n>  #\n> +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.\n> +#\n>  # Define NO_MKSTEMPS if you don't have mkstemps in the C library.\n>  #\n>  # Define NO_STRTOK_R if you don't have strtok_r in the C library.\n> @@ -1639,6 +1641,9 @@ ifdef NO_MKDTEMP\n>  \tCOMPAT_CFLAGS += -DNO_MKDTEMP\n>  \tCOMPAT_OBJS += compat/mkdtemp.o\n>  endif\n> +ifdef MKDIR_WO_TRAILING_SLASH\n> +\tCOMPAT_CFLAGS += -DMKDIR_WO_TRAILING_SLASH\n> +endif\n>  ifdef NO_MKSTEMPS\n>  \tCOMPAT_CFLAGS += -DNO_MKSTEMPS\n>  endif\n"},{"id":"198567","messageId":"001c01cd8dd5$d58eabe0$80ac03a0$@schmitz-digital.de","threadId":"31465","inReplyTo":"7vliglyc5g.fsf@alter.siamese.dyndns.org","subject":"RE: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-09-08T15:23:00Z","receivedAt":"2012-09-08T15:23:00Z","isPatch":true,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"> From: Joachim Schmitz [mailto:jojo@schmitz-digital.de]\n> Sent: Friday, September 07, 2012 8:28 PM\n> To: 'Junio C Hamano'\n> Cc: 'git@vger.kernel.org'\n> Subject: RE: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile\n> \n> \n> \n> > -----Original Message-----\n> > From: Junio C Hamano [mailto:gitster@pobox.com]\n> > Sent: Friday, September 07, 2012 7:30 PM\n> > To: Joachim Schmitz\n> > Cc: git@vger.kernel.org\n> > Subject: Re: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile\n> >\n> > \"Joachim Schmitz\" <jojo@schmitz-digital.de> writes:\n> >\n> > > Signed-off-by: Joachim Schmitz <jojo@schmitz-digital.de>\n> > > ---\n> > >  Makefile | 2 ++\n> > >  1 file changed, 2 insertions(+)\n> > >\n> > > diff --git a/Makefile b/Makefile\n> > > index ac49320..03e245a 100644\n> > > --- a/Makefile\n> > > +++ b/Makefile\n> > > @@ -90,6 +90,8 @@ all::\n> > >  #\n> > >  # Define NO_MKDTEMP if you don't have mkdtemp in the C library.\n> > >  #\n> > > +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.\n> > > +#\n> > >  # Define NO_MKSTEMPS if you don't have mkstemps in the C library.\n> > >  #\n> > >  # Define NO_STRTOK_R if you don't have strtok_r in the C library.\n> >\n> > Not really.  \"make MKDIR_WO_TRAILING_SLASH=YesPlease\" won't do\n> > anything.\n> >\n> > You would need at least something like this, no?\n> >\n> \n> Yes, that is better, thanks\n\nThere's something missing though, to make it fully usable, see below\n> \n> >  Makefile | 5 +++++\n> >  1 file changed, 5 insertions(+)\n> >\n> > diff --git c/Makefile w/Makefile\n> > index 66e8216..21b4816 100644\n> > --- c/Makefile\n> > +++ w/Makefile\n> > @@ -90,6 +90,8 @@ all::\n> >  #\n> >  # Define NO_MKDTEMP if you don't have mkdtemp in the C library.\n> >  #\n> > +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.\n> > +#\n> >  # Define NO_MKSTEMPS if you don't have mkstemps in the C library.\n> >  #\n> >  # Define NO_STRTOK_R if you don't have strtok_r in the C library.\n> > @@ -1639,6 +1641,9 @@ ifdef NO_MKDTEMP\n> >  \tCOMPAT_CFLAGS += -DNO_MKDTEMP\n> >  \tCOMPAT_OBJS += compat/mkdtemp.o\n> >  endif\n> > +ifdef MKDIR_WO_TRAILING_SLASH\n> > +\tCOMPAT_CFLAGS += -DMKDIR_WO_TRAILING_SLASH\n\n+\tCOMPAT_OBJS += compat/mkdir.o\n\n> > +endif\n> >  ifdef NO_MKSTEMPS\n> >  \tCOMPAT_CFLAGS += -DNO_MKSTEMPS\n> >  endif\n\nBye, Jojo\n"}]}