{"thread":{"id":"31457","subject":"[PATCH] doc: move rev-list option - from git-log.txt to rev-list-options.txt","startedAt":"2012-09-06T14:28:03Z","lastAt":"2012-09-08T16:11:09Z","messageCount":4,"participants":["Nguyễn Thái Ngọc Duy","Michael J Gruber","Junio C Hamano","Nguyen Thai Ngoc Duy"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"198448","messageId":"1346941683-24832-1-git-send-email-pclouds@gmail.com","threadId":"31457","inReplyTo":null,"subject":"[PATCH] doc: move rev-list option - from git-log.txt to rev-list-options.txt","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2012-09-06T14:28:03Z","receivedAt":"2012-09-06T14:28:03Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"rev-list-options.txt is included in git-rev-list.txt. This makes sure\nrev-list man page also shows that, and at one place, together with\nequivalent options -n and --max-count.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy \n---\n Documentation/git-log.txt | 6 ++----\n Documentation/rev-list-options.txt | 3 ++-\n 2 tập tin đã bị thay đổi, 4 được thêm vào(+), 5 bị xóa(-)\n\ndiff --git a/Documentation/git-log.txt b/Documentation/git-log.txt\nindex 1f90620..585dac4 100644\n--- a/Documentation/git-log.txt\n+++ b/Documentation/git-log.txt\n@@ -24,10 +24,6 @@ each commit introduces are shown.\n OPTIONS\n -------\n \n--::\n-\tLimits the number of commits to show.\n-\tNote that this is a commit limiting option, see below.\n-\n ..::\n \tShow only commits between the named two commits. When\n \teither or is omitted, it defaults to\n@@ -137,6 +133,8 @@ Examples\n \tThis makes sense only when following a strict policy of merging all\n \ttopic branches when staying on a single integration branch.\n \n+`git log -3`::\n+\tLimits the number of commits to show to 3.\n \n Discussion\n ----------\ndiff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt\nindex def1340..1b15ea9 100644\n--- a/Documentation/rev-list-options.txt\n+++ b/Documentation/rev-list-options.txt\n@@ -8,7 +8,8 @@ ordering and formatting options, such as '--reverse'.\n \n --\n \n--n 'number'::\n+-::\n+-n ::\n --max-count=::\n \n \tLimit the number of commits to output.\n-- \n1.7.12.rc2.18.g61b472e\n"},{"id":"198508","messageId":"5049B54F.7020301@drmicha.warpmail.net","threadId":"31457","inReplyTo":"1346941683-24832-1-git-send-email-pclouds@gmail.com","subject":"Re: [PATCH] doc: move rev-list option - from git-log.txt to rev-list-options.txt","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2012-09-07T08:50:23Z","receivedAt":"2012-09-07T08:50:23Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Nguyễn Thái Ngọc Duy venit, vidit, dixit 06.09.2012 16:28:\n> rev-list-options.txt is included in git-rev-list.txt. This makes sure\n> rev-list man page also shows that, and at one place, together with\n> equivalent options -n and --max-count.\n> \n> Signed-off-by: Nguyễn Thái Ngọc Duy \n> ---\n> Documentation/git-log.txt | 6 ++----\n> Documentation/rev-list-options.txt | 3 ++-\n> 2 tập tin đã bị thay đổi, 4 được thêm vào(+), 5 bị xóa(-)\n\nThat is one reason why \"core.local=C\" (repo specific) and \"git -c\ncore.locale=C\" (can be used in an alias) would be useful ;)\n\n> \n> diff --git a/Documentation/git-log.txt b/Documentation/git-log.txt\n> index 1f90620..585dac4 100644\n> --- a/Documentation/git-log.txt\n> +++ b/Documentation/git-log.txt\n> @@ -24,10 +24,6 @@ each commit introduces are shown.\n> OPTIONS\n> -------\n> \n> --::\n> -\tLimits the number of commits to show.\n> -\tNote that this is a commit limiting option, see below.\n> -\n> ..::\n> \tShow only commits between the named two commits. When\n> \teither or is omitted, it defaults to\n> @@ -137,6 +133,8 @@ Examples\n> \tThis makes sense only when following a strict policy of merging all\n> \ttopic branches when staying on a single integration branch.\n> \n> +`git log -3`::\n> +\tLimits the number of commits to show to 3.\n> \n> Discussion\n> ----------\n> diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt\n> index def1340..1b15ea9 100644\n> --- a/Documentation/rev-list-options.txt\n> +++ b/Documentation/rev-list-options.txt\n> @@ -8,7 +8,8 @@ ordering and formatting options, such as '--reverse'.\n> \n> --\n> \n> --n 'number'::\n> +-::\n> +-n ::\n> --max-count=::\n> \n> \tLimit the number of commits to output.\n> \n\nThis looks OK.\n\nI noticed though that the man pages of git-log and git-rev-list still\nlook more different than they would need to, e.g. regarding the way\nlimitting by paths is explained more prominently with git-log. But that\nmay just be being more user friendly for git-log's man page than for git\nrev-list's, which is OK.\n\nMichael\n"},{"id":"198534","messageId":"7vwr05yctv.fsf@alter.siamese.dyndns.org","threadId":"31457","inReplyTo":"5049B54F.7020301@drmicha.warpmail.net","subject":"Re: [PATCH] doc: move rev-list option - from git-log.txt to rev-list-options.txt","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-09-07T17:14:52Z","receivedAt":"2012-09-07T17:14:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Michael J Gruber writes:\n\n> Nguyễn Thái Ngọc Duy venit, vidit, dixit 06.09.2012 16:28:\n>> rev-list-options.txt is included in git-rev-list.txt. This makes sure\n>> rev-list man page also shows that, and at one place, together with\n>> equivalent options -n and --max-count.\n>> \n>> Signed-off-by: Nguyễn Thái Ngọc Duy \n>> ---\n>> Documentation/git-log.txt | 6 ++----\n>> Documentation/rev-list-options.txt | 3 ++-\n>> 2 tập tin đã bị thay đổi, 4 được thêm vào(+), 5 bị xóa(-)\n>\n> That is one reason why \"core.local=C\" (repo specific) and \"git -c\n> core.locale=C\" (can be used in an alias) would be useful ;)\n\nOr \"LC_ALL=C LANG=C git format-patch ...\".\n\nIt does not bother me (even though I do not read Vietnamese), but\nthis has been brought up a few times, and we may want to revert the\ni18n of the diffstat summary. It does not seem to add much value to\nthe system but annoys people. After all, the \"upstream\" diffstat\ndoes not localizes this string (I just checked diffstat-1.55 with\nJan 2012 timestamp).\n"},{"id":"198569","messageId":"CACsJy8CmwvR+ZN5eoqpn=yj0GdmgWsOGQNpUK2GetktKuZ36iQ@mail.gmail.com","threadId":"31457","inReplyTo":"7vwr05yctv.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] doc: move rev-list option - from git-log.txt to rev-list-options.txt","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2012-09-08T16:11:09Z","receivedAt":"2012-09-08T16:11:09Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Sat, Sep 8, 2012 at 12:14 AM, Junio C Hamano wrote:\n> Michael J Gruber writes:\n>>> Documentation/git-log.txt | 6 ++----\n>>> Documentation/rev-list-options.txt | 3 ++-\n>>> 2 tập tin đã bị thay đổi, 4 được thêm vào(+), 5 bị xóa(-)\n>>\n>> That is one reason why \"core.local=C\" (repo specific) and \"git -c\n>> core.locale=C\" (can be used in an alias) would be useful ;)\n>\n> Or \"LC_ALL=C LANG=C git format-patch ...\".\n\nThe only problem is I forget to do that from time to time (and doing\nthat bothers me too)\n\n> It does not bother me (even though I do not read Vietnamese), but\n> this has been brought up a few times, and we may want to revert the\n> i18n of the diffstat summary. It does not seem to add much value to\n> the system but annoys people.\n\nThat's one step towards a better interface for non English speaking\nusers. \"git log\" interface for example still shows Author, Commit,\nDate in English and these strings are shared with format-patch.\nReverting back to English to me is a step back.\n\nThis brings back to a series I posted about two weeks ago and got no comments\n\nhttp://article.gmane.org/gmane.comp.version-control.git/204285\n\nI think it's a reasonable approach. Use English for machine interface,\notherwise a native language if available.\n\n> After all, the \"upstream\" diffstat\n> does not localizes this string (I just checked diffstat-1.55 with\n> Jan 2012 timestamp).\n-- \nDuy\n"}]}