{"thread":{"id":"31393","subject":"Re: [PATCH tip/core/rcu 0/5] Documentation and rcutorture changes","startedAt":"2012-08-30T23:22:16Z","lastAt":"2012-08-30T23:22:16Z","messageCount":1,"participants":["Josh Triplett"],"isPatch":true,"patchVersion":1,"patchTotal":5},"messages":[{"id":"198138","messageId":"20120830232216.GC11928@jtriplet-mobl1","threadId":"31393","inReplyTo":"20120830214603.GJ30381@linux.vnet.ibm.com","subject":"Re: [PATCH tip/core/rcu 0/5] Documentation and rcutorture changes","fromName":"Josh Triplett","fromEmail":"josh@joshtriplett.org","sentAt":"2012-08-30T23:22:16Z","receivedAt":"2012-08-30T23:22:16Z","isPatch":true,"sender":{"key":"josh@joshtriplett.org","avatar":"https://avatars.githubusercontent.com/u/162737?v=4"},"body":"On Thu, Aug 30, 2012 at 02:46:03PM -0700, Paul E. McKenney wrote:\n> On Thu, Aug 30, 2012 at 11:56:09AM -0700, Josh Triplett wrote:\n> > On Thu, Aug 30, 2012 at 11:44:48AM -0700, Paul E. McKenney wrote:\n> > > Hello!\n> > > \n> > > This series covers changes to rcutorture and documentation updates.\n> > > The individual patches in this series are as follows:\n> > > \n> > > 1.\tUpdate rcutorture default values so that casual rcutorture\n> > > \tusers will do more aggressive testing.\n> > > 2.\tMake rcutorture track CPU-hotplug latency statistics.\n> > > 3.\tDocument SRCU's new-found ability to be used by offline and\n> > > \tidle CPUs, and also emphasize SRCU's limitations.\n> > > 4.\tUse the new pr_*() interfaces in rcutorture.\n> > > 5.\tPrevent kthread-initialization races in rcutorture.\n> > > \n> > > \t\t\t\t\t\t\tThanx, Paul\n> > > \n> > > ------------------------------------------------------------------------\n> > > \n> > >  b/Documentation/RCU/checklist.txt |    6 +\n> > >  b/Documentation/RCU/whatisRCU.txt |    9 +-\n> > >  b/kernel/rcutorture.c             |    4 -\n> > >  kernel/rcutorture.c               |  152 +++++++++++++++++++++++---------------\n> > >  4 files changed, 108 insertions(+), 63 deletions(-)\n> > \n> > Something seems wrong with this diffstat; how'd the b/ prefixes get\n> > there, and why does it list kernel/rcutorture.c twice, once with and\n> > once without?\n> \n> Hmmm...  It seems quite reproducible.  I did the usual git-format-patch\n> and ran the resulting set of patches through diffstat.  I seem to have a\n> broken diffstat...\n> \n> However, git diff --stat v3.6-rc1..hotplug.2012.08.28a generates the\n> following:\n> \n>  kernel/rcutree.c       |   93 +++++++++++-------------------------------------\n>  kernel/rcutree.h       |    3 --\n>  kernel/rcutree_trace.c |    4 +-\n>  kernel/sched/core.c    |   41 ++++++++++-----------\n>  4 files changed, 43 insertions(+), 98 deletions(-)\n> \n> Which does look much better.\n\nYou might try generating your cover letter template via git format-patch\n--cover-letter, which will automatically give you a list of patches and\na git-produced diffstat; much easier than trying to format a cover\nletter by hand.  Meanwhile, you might consider sending your patches as a\nbug report to diffstat upstream: Thomas E. Dickey\n<dickey@invisible-island.net>.\n\n- Josh Triplett\n"}]}