{"thread":{"id":"3137","subject":"[PATCH] use \"git <command>\" instead of \"git-<command>\"","startedAt":"2006-01-24T10:52:24Z","lastAt":"2006-01-25T02:08:34Z","messageCount":2,"participants":["Uwe Zeisberger","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"15084","messageId":"20060124105224.GA6765@informatik.uni-freiburg.de","threadId":"3137","inReplyTo":null,"subject":"[PATCH] use \"git <command>\" instead of \"git-<command>\"","fromName":"Uwe Zeisberger","fromEmail":"zeisberg@informatik.uni-freiburg.de","sentAt":"2006-01-24T10:52:24Z","receivedAt":"2006-01-24T10:52:24Z","isPatch":true,"sender":{"key":"u.kleine-koenig@pengutronix.de","avatar":"https://gravatar.com/avatar/354b5e3ceb2806a2f1e1e382ac29ddbdad18288654da62b61eb13583a857eee7?d=mp&s=160"},"body":"Hello,\n\nOtherwise installations with gitexecdir != bindir are not able to determine the\nright version.\n\n---\n\n GIT-VERSION-GEN |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\n9d9d610164ec140f3fee21475b976d3e4b998991\ndiff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN\nindex e3cd9fa..2085ad3 100755\n--- a/GIT-VERSION-GEN\n+++ b/GIT-VERSION-GEN\n@@ -5,13 +5,13 @@ DEF_VER=v1.1.GIT\n \n # First try git-describe, then see if there is a version file\n # (included in release tarballs), then default\n-VN=$(git-describe --abbrev=4 HEAD 2>/dev/null | sed -e 's/-/./g') ||\n+VN=$(git describe --abbrev=4 HEAD 2>/dev/null | sed -e 's/-/./g') ||\n VN=$(cat version) ||\n VN=\"$DEF_VER\"\n \n VN=$(expr \"$VN\" : v*'\\(.*\\)')\n \n-dirty=$(sh -c 'git-diff-index --name-only HEAD' 2>/dev/null) || dirty=\n+dirty=$(sh -c 'git diff-index --name-only HEAD' 2>/dev/null) || dirty=\n case \"$dirty\" in\n '')\n \t;;\n-- \n1.1.4.g2eaa\n\nBest regards\nUwe\n\n-- \nUwe Zeisberger\n\nhttp://www.google.com/search?q=1+year+divided+by+3+in+seconds\n"},{"id":"15096","messageId":"7v64o93vq5.fsf@assigned-by-dhcp.cox.net","threadId":"3137","inReplyTo":"20060124105224.GA6765@informatik.uni-freiburg.de","subject":"Re: [PATCH] use \"git <command>\" instead of \"git-<command>\"","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-01-25T02:08:34Z","receivedAt":"2006-01-25T02:08:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Uwe Zeisberger <zeisberg@informatik.uni-freiburg.de> writes:\n\n> Otherwise installations with gitexecdir != bindir are not able\n> to determine the right version.\n\nTrue, but this part\n\n> -VN=$(git-describe --abbrev=4 HEAD 2>/dev/null | sed -e 's/-/./g') ||\n> +VN=$(git describe --abbrev=4 HEAD 2>/dev/null | sed -e 's/-/./g') ||\n>...\n\nhas a subtle issue, which the commit 026351a addresses, which\nwill hopefully become a non-issue given enough time.  Then it\nwould be safe to make this change.\n\nOf course, if/when I change the main Makefile to have different\ngitexecdir and bindir by default, it would become \"my problem\",\nbut until then...\n\n> -dirty=$(sh -c 'git-diff-index --name-only HEAD' 2>/dev/null) || dirty=\n> +dirty=$(sh -c 'git diff-index --name-only HEAD' 2>/dev/null) || dirty=\n\nOn the other hand, your patch is correct for this part.  The\nissue 026351a commit addressed does not apply.  An ancient 'git'\nthat did not have 'diff-index' (it was called 'diff-cache')\nwould have hit a breakage early on since 'describe' did not\nexist back then.\n"}]}