{"thread":{"id":"31357","subject":"[PATCH 2/3] t9020-*.sh: Fix urls passed to git-remote in test setup","startedAt":"2012-08-25T17:18:42Z","lastAt":"2012-08-25T17:18:42Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"197839","messageId":"503908F2.8010303@ramsay1.demon.co.uk","threadId":"31357","inReplyTo":null,"subject":"[PATCH 2/3] t9020-*.sh: Fix urls passed to git-remote in test setup","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2012-08-25T17:18:42Z","receivedAt":"2012-08-25T17:18:42Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nIn particular, the urls passed to git-remote have an extra '/' given\nafter the schema prefix, like so:\n\n    git remote add svnsim testsvn::sim:///$TEST_DIRECTORY/t9154/svn.dump\n    git remote add svnfile testsvn::file:///$TEST_DIRECTORY/t9154/svn.dump\n\nOnce the prefix is removed, the remainder of the url looks something\nlike \"//home/ramsay/git/t/t9154/svn.dump\", which is then interpreted\nas a network path. Since there is \"No such host or network path\"\ncalled \"//home\", this leads to the svnrdump_sim.py script to fail:\n\n  Traceback (most recent call last):\n    File \".../trash directory.t9020-remote-svn/svnrdump\", line 51, in ?\n      if writedump(url, r[0], r[1]): ret = 0\n    File \".../trash directory.t9020-remote-svn/svnrdump\", line 23, in writedump\n      f = open(filename, 'r');\n  IOError: [Errno 13] Permission denied: '//home/ramsay/git/t/t9154/svn.dump'\n\nIn order to fix the problem, we simply remove the extraneous '/'\ncharacter from the urls.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nHi Florian,\n\nThis test fails on cygwin. Could you please squash this into\ncommit 2d597d73 (\"Add a test script for remote-svn\", 20-08-2012).\n\nThanks!\n\nATB,\nRamsay Jones\n\n t/t9020-remote-svn.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t9020-remote-svn.sh b/t/t9020-remote-svn.sh\nindex 9ae9997..cd7604e 100755\n--- a/t/t9020-remote-svn.sh\n+++ b/t/t9020-remote-svn.sh\n@@ -13,8 +13,8 @@ init_git () {\n \tgit init &&\n \t#git remote add svnsim testsvn::sim:///$TEST_DIRECTORY/t9020/example.svnrdump\n \t# let's reuse an exisiting dump file!?\n-\tgit remote add svnsim testsvn::sim:///$TEST_DIRECTORY/t9154/svn.dump\n-\tgit remote add svnfile testsvn::file:///$TEST_DIRECTORY/t9154/svn.dump\n+\tgit remote add svnsim testsvn::sim://$TEST_DIRECTORY/t9154/svn.dump\n+\tgit remote add svnfile testsvn::file://$TEST_DIRECTORY/t9154/svn.dump\n }\n \n if test -e \"$GIT_BUILD_DIR/git-remote-testsvn\"\n-- \n1.7.12\n"}]}