{"thread":{"id":"31318","subject":"[PATCH] Don't use curl_easy_strerror prior to curl-7.12.0","startedAt":"2012-08-22T15:44:44Z","lastAt":"2012-08-24T05:30:01Z","messageCount":12,"participants":["Joachim Schmitz","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"197587","messageId":"002201cd807d$0e83d300$2b8b7900$@schmitz-digital.de","threadId":"31318","inReplyTo":null,"subject":"[PATCH] Don't use curl_easy_strerror prior to curl-7.12.0","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-08-22T15:44:44Z","receivedAt":"2012-08-22T15:44:44Z","isPatch":true,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"\nSigned-off-by: Joachim Schmitz \n---\n http.c | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/http.c b/http.c\nindex b61ac85..18bc6bf 100644\n--- a/http.c\n+++ b/http.c\n@@ -806,10 +806,12 @@ static int http_request(const char *url, void *result,\nint target, int options)\n ret = HTTP_REAUTH;\n }\n } else {\n+#if LIBCURL_VERSION_NUM >= 0x070c00\n if (!curl_errorstr[0])\n strlcpy(curl_errorstr,\n \ncurl_easy_strerror(results.curl_result),\n sizeof(curl_errorstr));\n+#endif\n ret = HTTP_ERROR;\n }\n } else {\n--\n1.7.12\n\nBye, Jojo\n"},{"id":"197601","messageId":"7v8vd6alqe.fsf@alter.siamese.dyndns.org","threadId":"31318","inReplyTo":"002201cd807d$0e83d300$2b8b7900$@schmitz-digital.de","subject":"Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-08-22T17:18:49Z","receivedAt":"2012-08-22T17:18:49Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Joachim Schmitz\" writes:\n\n> Signed-off-by: Joachim Schmitz \n\nAt the very least, please mention that this reverts be22d92 (http:\navoid empty error messages for some curl errors, 2011-09-05) on\nplatforms with older versions of libcURL.\n\n> ---\n> http.c | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/http.c b/http.c\n> index b61ac85..18bc6bf 100644\n> --- a/http.c\n> +++ b/http.c\n> @@ -806,10 +806,12 @@ static int http_request(const char *url, void *result,\n> int target, int options)\n> ret = HTTP_REAUTH;\n> }\n> } else {\n> +#if LIBCURL_VERSION_NUM >= 0x070c00\n> if (!curl_errorstr[0])\n> strlcpy(curl_errorstr,\n> \n> curl_easy_strerror(results.curl_result),\n> sizeof(curl_errorstr));\n> +#endif\n> ret = HTTP_ERROR;\n> }\n> } else {\n> --\n> 1.7.12\n>\n> Bye, Jojo\n"},{"id":"197605","messageId":"003001cd808b$9d505730$d7f10590$@schmitz-digital.de","threadId":"31318","inReplyTo":"7v8vd6alqe.fsf@alter.siamese.dyndns.org","subject":"RE: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-08-22T17:28:58Z","receivedAt":"2012-08-22T17:28:58Z","isPatch":true,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"> From: Junio C Hamano [mailto:gitster@pobox.com]\n> Sent: Wednesday, August 22, 2012 7:19 PM\n> To: Joachim Schmitz\n> Cc: git@vger.kernel.org\n> Subject: Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0\n> \n> \"Joachim Schmitz\" writes:\n> \n> > Signed-off-by: Joachim Schmitz \n> \n> At the very least, please mention that this reverts be22d92 (http:\n> avoid empty error messages for some curl errors, 2011-09-05) on platforms\n> with older versions of libcURL.\n\na) Of course I didn't know that, thanks for telling me.\nb) How and where to add that? In the Subject of an email, in the body, right\nat the front?\nLike this:\n----\n\nThis reverts be22d92 (http: avoid empty error messages for some curl errors,\n2011-09-05) on platforms with older versions of libcURL.\n\nSigned-off-by: Joachim Schmitz \n---\n http.c | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/http.c b/http.c\nindex b61ac85..18bc6bf 100644\n--- a/http.c\n+++ b/http.c\n@@ -806,10 +806,12 @@ static int http_request(const char *url, void *result,\nint target, int options)\n ret = HTTP_REAUTH;\n }\n } else {\n+#if LIBCURL_VERSION_NUM >= 0x070c00\n if (!curl_errorstr[0])\n strlcpy(curl_errorstr,\n \ncurl_easy_strerror(results.curl_result),\n sizeof(curl_errorstr));\n+#endif\n ret = HTTP_ERROR;\n }\n } else {\n--\n1.7.12\n\nBye, Jojo\n"},{"id":"197609","messageId":"7vk3wq964r.fsf@alter.siamese.dyndns.org","threadId":"31318","inReplyTo":"003001cd808b$9d505730$d7f10590$@schmitz-digital.de","subject":"Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-08-22T17:41:08Z","receivedAt":"2012-08-22T17:41:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Joachim Schmitz\" writes:\n\n> Like this:\n> ----\n>\n> This reverts be22d92 (http: avoid empty error messages for some curl errors,\n> 2011-09-05) on platforms with older versions of libcURL.\n>\n> Signed-off-by: Joachim Schmitz \n> ---\n\nPerfect ;-)\n\n> http.c | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/http.c b/http.c\n> index b61ac85..18bc6bf 100644\n> --- a/http.c\n> +++ b/http.c\n> @@ -806,10 +806,12 @@ static int http_request(const char *url, void *result,\n> int target, int options)\n> ret = HTTP_REAUTH;\n> }\n\nNow we need to see where these whitespace breakages are coming from\nand fix it, and I think it should be done earlier than later, as I\nexpect we will be seeing more patches from you in the coming weeks.\n\n> } else {\n> +#if LIBCURL_VERSION_NUM >= 0x070c00\n> if (!curl_errorstr[0])\n> strlcpy(curl_errorstr,\n> \n> curl_easy_strerror(results.curl_result),\n> sizeof(curl_errorstr));\n> +#endif\n> ret = HTTP_ERROR;\n> }\n> } else {\n> --\n> 1.7.12\n>\n> Bye, Jojo\n"},{"id":"197616","messageId":"003c01cd808f$f24e2a60$d6ea7f20$@schmitz-digital.de","threadId":"31318","inReplyTo":"7vk3wq964r.fsf@alter.siamese.dyndns.org","subject":"RE: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-08-22T17:59:58Z","receivedAt":"2012-08-22T17:59:58Z","isPatch":true,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"> From: Junio C Hamano [mailto:gitster@pobox.com]\n> Sent: Wednesday, August 22, 2012 7:41 PM\n> To: Joachim Schmitz\n> Cc: git@vger.kernel.org\n> Subject: Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0\n> \n> \"Joachim Schmitz\" writes:\n> \n> > Like this:\n> > ----\n> >\n> > This reverts be22d92 (http: avoid empty error messages for some curl\n> > errors,\n> > 2011-09-05) on platforms with older versions of libcURL.\n> >\n> > Signed-off-by: Joachim Schmitz \n> > ---\n> \n> Perfect ;-)\n> \n> > http.c | 2 ++\n> > 1 file changed, 2 insertions(+)\n> >\n> > diff --git a/http.c b/http.c\n> > index b61ac85..18bc6bf 100644\n> > --- a/http.c\n> > +++ b/http.c\n> > @@ -806,10 +806,12 @@ static int http_request(const char *url, void\n> > *result, int target, int options)\n> > ret = HTTP_REAUTH;\n> > }\n> \n> Now we need to see where these whitespace breakages are coming from and\n> fix it, and I think it should be done earlier than later, as I expect we\nwill be\n> seeing more patches from you in the coming weeks.\n\nOK, next attempt (this time I downloaded the patch file to my PC first and\nused Wordpad for copy/past rather than cat in a PuTTY session)\n---\n\nThis reverts be22d92 (http: avoid empty error messages for some curl errors,\n2011-09-05) on platforms with older versions of libcURL.\n\nSigned-off-by: Joachim Schmitz \n---\n http.c | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/http.c b/http.c\nindex b61ac85..18bc6bf 100644\n--- a/http.c\n+++ b/http.c\n@@ -806,10 +806,12 @@ static int http_request(const char *url, void *result,\nint target, int options)\n \t\t\t\tret = HTTP_REAUTH;\n \t\t\t}\n \t\t} else {\n+#if LIBCURL_VERSION_NUM >= 0x070c00\n \t\t\tif (!curl_errorstr[0])\n \t\t\t\tstrlcpy(curl_errorstr,\n \ncurl_easy_strerror(results.curl_result),\n \t\t\t\t\tsizeof(curl_errorstr));\n+#endif\n \t\t\tret = HTTP_ERROR;\n \t\t}\n \t} else {\n-- \n1.7.12\n\nBetter?\n\nBye, Jojo\n"},{"id":"197623","messageId":"7v7gsq94gd.fsf@alter.siamese.dyndns.org","threadId":"31318","inReplyTo":"003c01cd808f$f24e2a60$d6ea7f20$@schmitz-digital.de","subject":"Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-08-22T18:17:22Z","receivedAt":"2012-08-22T18:17:22Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Joachim Schmitz\" writes:\n\n>\n> This reverts be22d92 (http: avoid empty error messages for some curl errors,\n> 2011-09-05) on platforms with older versions of libcURL.\n>\n> Signed-off-by: Joachim Schmitz \n> ---\n> http.c | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/http.c b/http.c\n> index b61ac85..18bc6bf 100644\n> --- a/http.c\n> +++ b/http.c\n> @@ -806,10 +806,12 @@ static int http_request(const char *url, void *result,\n> int target, int options)\n\nLikewrapped X-<\n\n> \t\t\t\tret = HTTP_REAUTH;\n> \t\t\t}\n> \t\t} else {\n> +#if LIBCURL_VERSION_NUM >= 0x070c00\n> \t\t\tif (!curl_errorstr[0])\n> \t\t\t\tstrlcpy(curl_errorstr,\n> \n> curl_easy_strerror(results.curl_result),\n> \t\t\t\t\tsizeof(curl_errorstr));\n> +#endif\n> \t\t\tret = HTTP_ERROR;\n> \t\t}\n> \t} else {\n"},{"id":"197631","messageId":"004101cd8096$fce3a700$f6aaf500$@schmitz-digital.de","threadId":"31318","inReplyTo":"7v7gsq94gd.fsf@alter.siamese.dyndns.org","subject":"RE: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-08-22T18:50:22Z","receivedAt":"2012-08-22T18:50:22Z","isPatch":true,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"\n\n> -----Original Message-----\n> From: Junio C Hamano [mailto:gitster@pobox.com]\n> Sent: Wednesday, August 22, 2012 8:17 PM\n> To: Joachim Schmitz\n> Cc: git@vger.kernel.org\n> Subject: Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0\n> \n> \"Joachim Schmitz\" writes:\n> \n> >\n> > This reverts be22d92 (http: avoid empty error messages for some curl\n> > errors,\n> > 2011-09-05) on platforms with older versions of libcURL.\n> >\n> > Signed-off-by: Joachim Schmitz \n> > ---\n> > http.c | 2 ++\n> > 1 file changed, 2 insertions(+)\n> >\n> > diff --git a/http.c b/http.c\n> > index b61ac85..18bc6bf 100644\n> > --- a/http.c\n> > +++ b/http.c\n> > @@ -806,10 +806,12 @@ static int http_request(const char *url, void\n> > *result, int target, int options)\n> \n> Likewrapped X-<\n\nAny suggestion?\n"},{"id":"197659","messageId":"7vwr0q63po.fsf@alter.siamese.dyndns.org","threadId":"31318","inReplyTo":"004101cd8096$fce3a700$f6aaf500$@schmitz-digital.de","subject":"Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-08-22T21:01:39Z","receivedAt":"2012-08-22T21:01:39Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Joachim Schmitz\" writes:\n\n>> > diff --git a/http.c b/http.c\n>> > index b61ac85..18bc6bf 100644\n>> > --- a/http.c\n>> > +++ b/http.c\n>> > @@ -806,10 +806,12 @@ static int http_request(const char *url, void\n>> > *result, int target, int options)\n>> \n>> Likewrapped X-<\n>\n> Any suggestion?\n\nOther than \"don't wrap\" (or \"get a real MUA and MTA\" X-<),\nunfortunately no.\n\nI do not know if you have checked MUA specific hints section of\nDocumentation/SubmittingPatches; there may be environment specific\nhints described for a MUA you may have at hand (or not).\n"},{"id":"197662","messageId":"004601cd80a9$e79bace0$b6d306a0$@schmitz-digital.de","threadId":"31318","inReplyTo":"7vwr0q63po.fsf@alter.siamese.dyndns.org","subject":"RE: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-08-22T21:05:47Z","receivedAt":"2012-08-22T21:05:47Z","isPatch":true,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"> From: Junio C Hamano [mailto:gitster@pobox.com]\n> Sent: Wednesday, August 22, 2012 11:02 PM\n> To: Joachim Schmitz\n> Cc: git@vger.kernel.org\n> Subject: Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0\n> \n> \"Joachim Schmitz\" writes:\n> \n> >> > diff --git a/http.c b/http.c\n> >> > index b61ac85..18bc6bf 100644\n> >> > --- a/http.c\n> >> > +++ b/http.c\n> >> > @@ -806,10 +806,12 @@ static int http_request(const char *url, void\n> >> > *result, int target, int options)\n> >>\n> >> Likewrapped X-<\n> >\n> > Any suggestion?\n> \n> Other than \"don't wrap\" (or \"get a real MUA and MTA\" X-<), unfortunately\nno.\n> \n> I do not know if you have checked MUA specific hints section of\n> Documentation/SubmittingPatches; there may be environment specific hints\n> described for a MUA you may have at hand (or not).\n\nI checked, but Outlook isn't mentioned :-(\n\nBye, Jojo\n"},{"id":"197679","messageId":"000601cd8101$a6f81900$f4e84b00$@schmitz-digital.de","threadId":"31318","inReplyTo":"7vwr0q63po.fsf@alter.siamese.dyndns.org","subject":"RE: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-08-23T07:33:55Z","receivedAt":"2012-08-23T07:33:55Z","isPatch":true,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"> From: Joachim Schmitz [mailto:jojo@schmitz-digital.de]\n> Sent: Wednesday, August 22, 2012 11:06 PM\n> To: 'Junio C Hamano'\n> Cc: 'git@vger.kernel.org'\n> Subject: RE: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0\n> \n> > From: Junio C Hamano [mailto:gitster@pobox.com]\n> > Sent: Wednesday, August 22, 2012 11:02 PM\n> > To: Joachim Schmitz\n> > Cc: git@vger.kernel.org\n> > Subject: Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0\n> >\n> > \"Joachim Schmitz\" writes:\n> >\n> > >> > diff --git a/http.c b/http.c\n> > >> > index b61ac85..18bc6bf 100644\n> > >> > --- a/http.c\n> > >> > +++ b/http.c\n> > >> > @@ -806,10 +806,12 @@ static int http_request(const char *url, void\n> > >> > *result, int target, int options)\n> > >>\n> > >> Likewrapped X-<\n> > >\n> > > Any suggestion?\n> >\n> > Other than \"don't wrap\" (or \"get a real MUA and MTA\" X-<), unfortunately no.\n> >\n> > I do not know if you have checked MUA specific hints section of\n> > Documentation/SubmittingPatches; there may be environment specific hints\n> > described for a MUA you may have at hand (or not).\n> \n> I checked, but Outlook isn't mentioned :-(\n\nOK, Outlook inserts line breaks at position 76. I can't switch it off completely, but can set it to anything between 30 and 132. I\nset it to 132 now, does that look OK now?\n---\n\nThis reverts be22d92 (http: avoid empty error messages for some curl errors, 2011-09-05) on platforms with older versions of\nlibcURL.\n\nSigned-off-by: Joachim Schmitz \n---\n http.c | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/http.c b/http.c\nindex b61ac85..18bc6bf 100644\n--- a/http.c\n+++ b/http.c\n@@ -806,10 +806,12 @@ static int http_request(const char *url, void *result, int target, int options)\n \t\t\t\tret = HTTP_REAUTH;\n \t\t\t}\n \t\t} else {\n+#if LIBCURL_VERSION_NUM >= 0x070c00\n \t\t\tif (!curl_errorstr[0])\n \t\t\t\tstrlcpy(curl_errorstr,\n \t\t\t\t\tcurl_easy_strerror(results.curl_result),\n \t\t\t\t\tsizeof(curl_errorstr));\n+#endif\n \t\t\tret = HTTP_ERROR;\n \t\t}\n \t} else {\n-- \n1.7.12\n\n\nBye, Jojo\n"},{"id":"197738","messageId":"7vlih52tag.fsf@alter.siamese.dyndns.org","threadId":"31318","inReplyTo":"000601cd8101$a6f81900$f4e84b00$@schmitz-digital.de","subject":"Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-08-23T21:27:19Z","receivedAt":"2012-08-23T21:27:19Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Joachim Schmitz\" writes:\n\n>> From: Joachim Schmitz [mailto:jojo@schmitz-digital.de]\n>> Sent: Wednesday, August 22, 2012 11:06 PM\n>> To: 'Junio C Hamano'\n>> Cc: 'git@vger.kernel.org'\n>> Subject: RE: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0\n>> \n>> > From: Junio C Hamano [mailto:gitster@pobox.com]\n>> > Sent: Wednesday, August 22, 2012 11:02 PM\n>> > To: Joachim Schmitz\n>> > Cc: git@vger.kernel.org\n>> > Subject: Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0\n>> >\n>> > \"Joachim Schmitz\" writes:\n>> >\n>> > >> > diff --git a/http.c b/http.c\n>> > >> > index b61ac85..18bc6bf 100644\n>> > >> > --- a/http.c\n>> > >> > +++ b/http.c\n>> > >> > @@ -806,10 +806,12 @@ static int http_request(const char *url, void\n>> > >> > *result, int target, int options)\n>> > >>\n>> > >> Likewrapped X-<\n>> > >\n>> > > Any suggestion?\n>> >\n>> > Other than \"don't wrap\" (or \"get a real MUA and MTA\" X-<), unfortunately no.\n>> >\n>> > I do not know if you have checked MUA specific hints section of\n>> > Documentation/SubmittingPatches; there may be environment specific hints\n>> > described for a MUA you may have at hand (or not).\n>> \n>> I checked, but Outlook isn't mentioned :-(\n>\n> OK, Outlook inserts line breaks at position 76. I can't switch it off completely, but can set it to anything between 30 and 132. I\n> set it to 132 now, does that look OK now?\n\nYeah, modulo that with all the above noise and with \"---\" before the\nlog message you inserted by hand before the real commit log message,\nand also the log message is not properly line-wrapped, it is getting\ncloser to what is expected of a patch to be applied.\n\nI've applied it by hand and fixed the log message up, so no need to\nresend this particular one. Thanks.\n\n> ---\n>\n> This reverts be22d92 (http: avoid empty error messages for some curl errors, 2011-09-05) on platforms with older versions of\n> libcURL.\n>\n> Signed-off-by: Joachim Schmitz \n> ---\n> http.c | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/http.c b/http.c\n> index b61ac85..18bc6bf 100644\n> --- a/http.c\n> +++ b/http.c\n> @@ -806,10 +806,12 @@ static int http_request(const char *url, void *result, int target, int options)\n> \t\t\t\tret = HTTP_REAUTH;\n> \t\t\t}\n> \t\t} else {\n> +#if LIBCURL_VERSION_NUM >= 0x070c00\n> \t\t\tif (!curl_errorstr[0])\n> \t\t\t\tstrlcpy(curl_errorstr,\n> \t\t\t\t\tcurl_easy_strerror(results.curl_result),\n> \t\t\t\t\tsizeof(curl_errorstr));\n> +#endif\n> \t\t\tret = HTTP_ERROR;\n> \t\t}\n> \t} else {\n"},{"id":"197744","messageId":"002101cd81b9$828f1380$87ad3a80$@schmitz-digital.de","threadId":"31318","inReplyTo":"7vlih52tag.fsf@alter.siamese.dyndns.org","subject":"RE: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0","fromName":"Joachim Schmitz","fromEmail":"jojo@schmitz-digital.de","sentAt":"2012-08-24T05:30:01Z","receivedAt":"2012-08-24T05:30:01Z","isPatch":true,"sender":{"key":"jojo@schmitz-digital.de","avatar":"https://avatars.githubusercontent.com/u/1786669?v=4"},"body":"> From: Junio C Hamano [mailto:gitster@pobox.com]\n> Sent: Thursday, August 23, 2012 11:27 PM\n> To: Joachim Schmitz\n> Cc: git@vger.kernel.org\n> Subject: Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0\n> \n> \"Joachim Schmitz\" writes:\n> \n> >> From: Joachim Schmitz [mailto:jojo@schmitz-digital.de]\n> >> Sent: Wednesday, August 22, 2012 11:06 PM\n> >> To: 'Junio C Hamano'\n> >> Cc: 'git@vger.kernel.org'\n> >> Subject: RE: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0\n> >>\n> >> > From: Junio C Hamano [mailto:gitster@pobox.com]\n> >> > Sent: Wednesday, August 22, 2012 11:02 PM\n> >> > To: Joachim Schmitz\n> >> > Cc: git@vger.kernel.org\n> >> > Subject: Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0\n> >> >\n> >> > \"Joachim Schmitz\" writes:\n> >> >\n> >> > >> > diff --git a/http.c b/http.c\n> >> > >> > index b61ac85..18bc6bf 100644\n> >> > >> > --- a/http.c\n> >> > >> > +++ b/http.c\n> >> > >> > @@ -806,10 +806,12 @@ static int http_request(const char *url, void\n> >> > >> > *result, int target, int options)\n> >> > >>\n> >> > >> Likewrapped X-<\n> >> > >\n> >> > > Any suggestion?\n> >> >\n> >> > Other than \"don't wrap\" (or \"get a real MUA and MTA\" X-<), unfortunately no.\n> >> >\n> >> > I do not know if you have checked MUA specific hints section of\n> >> > Documentation/SubmittingPatches; there may be environment specific hints\n> >> > described for a MUA you may have at hand (or not).\n> >>\n> >> I checked, but Outlook isn't mentioned :-(\n> >\n> > OK, Outlook inserts line breaks at position 76. I can't switch it off completely, but can set it to anything between 30 and 132.\nI\n> > set it to 132 now, does that look OK now?\n> \n> Yeah, modulo that with all the above noise and with \"---\" before the\n> log message you inserted by hand before the real commit log message,\n\nOK, those are not allowed then? Or would they need to look different?\n\n> and also the log message is not properly line-wrapped, it is getting\n> closer to what is expected of a patch to be applied.\n> \n> I've applied it by hand and fixed the log message up, so no need to\n> resend this particular one. Thanks.\n\nThanks\n\n> > This reverts be22d92 (http: avoid empty error messages for some curl errors, 2011-09-05) on platforms with older versions of\n> > libcURL.\n\nYou meant that linewrap between \"of\" and libcURL?, Or well, that was the 132 position... Or do you want these messages being wrapped\nat <=80?\n\nBye, Jojo\n"}]}