{"thread":{"id":"31307","subject":"[PATCH] difftool: silence warning","startedAt":"2012-08-21T10:21:40Z","lastAt":"2012-08-21T10:21:40Z","messageCount":1,"participants":["Ross Lagerwall"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"197526","messageId":"1345544500-16277-1-git-send-email-rosslagerwall@gmail.com","threadId":"31307","inReplyTo":null,"subject":"[PATCH] difftool: silence warning","fromName":"Ross Lagerwall","fromEmail":"rosslagerwall@gmail.com","sentAt":"2012-08-21T10:21:40Z","receivedAt":"2012-08-21T10:21:40Z","isPatch":true,"sender":{"key":"rosslagerwall@gmail.com","avatar":"https://avatars.githubusercontent.com/u/878055?v=4"},"body":"Silence a warning given when running git difftool --dir-diff and\nthere are no changes.\nThis is because command_oneline returns undef when the command has no\noutput, not ''.\n\nSigned-off-by: Ross Lagerwall <rosslagerwall@gmail.com>\n---\n git-difftool.perl | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-difftool.perl b/git-difftool.perl\nindex 17d4de6..edd0493 100755\n--- a/git-difftool.perl\n+++ b/git-difftool.perl\n@@ -138,7 +138,7 @@ sub setup_dir_diff\n \n \tmy @gitargs = ('diff', '--raw', '--no-abbrev', '-z', @ARGV);\n \tmy $diffrtn = $diffrepo->command_oneline(@gitargs);\n-\texit(0) if (length($diffrtn) == 0);\n+\texit(0) unless defined($diffrtn);\n \n \t# Build index info for left and right sides of the diff\n \tmy $submodule_mode = '160000';\n-- \n1.7.11.4\n"}]}