{"thread":{"id":"31126","subject":"[PATCH 2/2] t7810-*.sh: Remove redundant test","startedAt":"2012-07-28T18:50:49Z","lastAt":"2012-07-28T18:50:49Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"196039","messageId":"50143489.1030606@ramsay1.demon.co.uk","threadId":"31126","inReplyTo":null,"subject":"[PATCH 2/2] t7810-*.sh: Remove redundant test","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2012-07-28T18:50:49Z","receivedAt":"2012-07-28T18:50:49Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSince commit bbc09c22 (\"grep: rip out support for external grep\",\n12-01-2010), test number 60 (\"grep -C1 hunk mark between files\") is\nessentially the same as test number 59.\n\nTest 59 was intended to verify the behaviour of git-grep resulting\nfrom multiple invocations of an external grep. As part of the test,\nit creates and adds 1024 files to the index, which is now wasted\neffort.\n\nRemove test 59, since it is now redundant.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n t/t7810-grep.sh | 11 -----------\n 1 file changed, 11 deletions(-)\n\ndiff --git a/t/t7810-grep.sh b/t/t7810-grep.sh\nindex 24e9b19..523d041 100755\n--- a/t/t7810-grep.sh\n+++ b/t/t7810-grep.sh\n@@ -399,17 +399,6 @@ test_expect_success 'grep -q, silently report matches' '\n \ttest_cmp empty actual\n '\n \n-# Create 1024 file names that sort between \"y\" and \"z\" to make sure\n-# the two files are handled by different calls to an external grep.\n-# This depends on MAXARGS in builtin-grep.c being 1024 or less.\n-c32=\"0 1 2 3 4 5 6 7 8 9 a b c d e f g h i j k l m n o p q r s t u v\"\n-test_expect_success 'grep -C1, hunk mark between files' '\n-\tfor a in $c32; do for b in $c32; do : >y-$a$b; done; done &&\n-\tgit add y-?? &&\n-\tgit grep -C1 \"^[yz]\" >actual &&\n-\ttest_cmp expected actual\n-'\n-\n test_expect_success 'grep -C1 hunk mark between files' '\n \tgit grep -C1 \"^[yz]\" >actual &&\n \ttest_cmp expected actual\n-- \n1.7.11.2\n"}]}