{"thread":{"id":"31106","subject":"[PATCH] i18n: leave \\n out of translated diffstat","startedAt":"2012-07-26T12:52:36Z","lastAt":"2012-07-26T17:46:58Z","messageCount":2,"participants":["Nguyễn Thái Ngọc Duy","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"195850","messageId":"1343307156-16528-1-git-send-email-pclouds@gmail.com","threadId":"31106","inReplyTo":null,"subject":"[PATCH] i18n: leave \\n out of translated diffstat","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2012-07-26T12:52:36Z","receivedAt":"2012-07-26T12:52:36Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"GETTEXT_POISON scrapes everything in translated strings, including \\n.\nt4205.12 however needs this \\n in matching the end result. Keep this\n\\n out of translation to make t4205.12 happy.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n I haven't followed recent i18n patches closely. Jiang may have\n already fixed this in one of his patches. Anyway just in case\n everybody does miss this..\n\n Should I resend parseopt i18n marking series now or wait until rc\n period is over?\n\n diff.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/diff.c b/diff.c\nindex 62cbe14..95706a5 100644\n--- a/diff.c\n+++ b/diff.c\n@@ -1397,7 +1397,7 @@ int print_stat_summary(FILE *fp, int files, int insertions, int deletions)\n \n \tif (!files) {\n \t\tassert(insertions == 0 && deletions == 0);\n-\t\treturn fputs(_(\" 0 files changed\\n\"), fp);\n+\t\treturn fprintf(fp, \"%s\\n\", _(\" 0 files changed\"));\n \t}\n \n \tstrbuf_addf(&sb,\n-- \n1.7.8\n"},{"id":"195875","messageId":"7va9ym8lf1.fsf@alter.siamese.dyndns.org","threadId":"31106","inReplyTo":"1343307156-16528-1-git-send-email-pclouds@gmail.com","subject":"Re: [PATCH] i18n: leave \\n out of translated diffstat","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-07-26T17:46:58Z","receivedAt":"2012-07-26T17:46:58Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:\n\n> diff --git a/diff.c b/diff.c\n> index 62cbe14..95706a5 100644\n> --- a/diff.c\n> +++ b/diff.c\n> @@ -1397,7 +1397,7 @@ int print_stat_summary(FILE *fp, int files, int insertions, int deletions)\n>  \n>  \tif (!files) {\n>  \t\tassert(insertions == 0 && deletions == 0);\n> -\t\treturn fputs(_(\" 0 files changed\\n\"), fp);\n> +\t\treturn fprintf(fp, \"%s\\n\", _(\" 0 files changed\"));\n>  \t}\n\nGood.\n"}]}