{"thread":{"id":"31091","subject":"Teach Makefile.PL to find .pm files on its own","startedAt":"2012-07-25T03:21:08Z","lastAt":"2012-07-25T23:37:56Z","messageCount":16,"participants":["Michael G. Schwern","Junio C Hamano","Michael G Schwern","Jonathan Nieder","Eric Wong"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"195695","messageId":"1343186471-1024-1-git-send-email-schwern@pobox.com","threadId":"31091","inReplyTo":null,"subject":"Teach Makefile.PL to find .pm files on its own","fromName":"Michael G. Schwern","fromEmail":"schwern@pobox.com","sentAt":"2012-07-25T03:21:08Z","receivedAt":"2012-07-25T03:21:08Z","isPatch":false,"sender":{"key":"schwern@pobox.com","avatar":"https://avatars.githubusercontent.com/u/25888?v=4"},"body":"This makes it so you no longer must edit the Makefile.PL every time you\nadd, rename or delete a Perl module. This is convenient, and I'm about\nto extract a bunch of .pm files out of git-svn.\n\nYou still have to edit the Makefile. That parallel build system should be\nable to be removed at a later date and replaced with the right Makefile.PL\nflags.\n\nPatch 1 and 2 are just things I noticed in the Makefile.PL along the way.\nPatch 3 is the meat. It doesn't depend on 1 & 2 but I figured it would\nbe silly to send them separately.\n"},{"id":"195696","messageId":"1343186471-1024-2-git-send-email-schwern@pobox.com","threadId":"31091","inReplyTo":"1343186471-1024-1-git-send-email-schwern@pobox.com","subject":"[PATCH 1/3] Quiet warning if Makefile.PL is run with -w and no --localedir","fromName":"Michael G. Schwern","fromEmail":"schwern@pobox.com","sentAt":"2012-07-25T03:21:09Z","receivedAt":"2012-07-25T03:21:09Z","isPatch":true,"sender":{"key":"schwern@pobox.com","avatar":"https://avatars.githubusercontent.com/u/25888?v=4"},"body":"From: \"Michael G. Schwern\" \n\nUsually it isn't, but its nice if it can be run with warnings on.\n\nSigned-off-by: Michael G Schwern \n---\n perl/Makefile.PL | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/perl/Makefile.PL b/perl/Makefile.PL\nindex b54b04a..87e1f62 100644\n--- a/perl/Makefile.PL\n+++ b/perl/Makefile.PL\n@@ -6,7 +6,8 @@ use Getopt::Long;\n # Sanity: die at first unknown option\n Getopt::Long::Configure qw/ pass_through /;\n \n-GetOptions(\"localedir=s\" => \\my $localedir);\n+my $localedir = '';\n+GetOptions(\"localedir=s\" => \\$localedir);\n \n sub MY::postamble {\n \treturn <<'MAKE_FRAG';\n-- \n1.7.11.1\n"},{"id":"195697","messageId":"1343186471-1024-3-git-send-email-schwern@pobox.com","threadId":"31091","inReplyTo":"1343186471-1024-1-git-send-email-schwern@pobox.com","subject":"[PATCH 2/3] Don't lose Error.pm if $@ gets clobbered.","fromName":"Michael G. Schwern","fromEmail":"schwern@pobox.com","sentAt":"2012-07-25T03:21:10Z","receivedAt":"2012-07-25T03:21:10Z","isPatch":true,"sender":{"key":"schwern@pobox.com","avatar":"https://avatars.githubusercontent.com/u/25888?v=4"},"body":"From: \"Michael G. Schwern\" \n\nIn older Perls, sometimes $@ can become unset between the eval and\nchecking $@. Its safer to check the eval directly.\n\nSigned-off-by: Michael G Schwern \n---\n perl/Makefile.PL | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\ndiff --git a/perl/Makefile.PL b/perl/Makefile.PL\nindex 87e1f62..887fa1b 100644\n--- a/perl/Makefile.PL\n+++ b/perl/Makefile.PL\n@@ -41,8 +41,7 @@ my %pm = (\n \n # We come with our own bundled Error.pm. It's not in the set of default\n # Perl modules so install it if it's not available on the system yet.\n-eval { require Error };\n-if ($@ || $Error::VERSION < 0.15009) {\n+if ( !eval { require Error } || $Error::VERSION < 0.15009) {\n \t$pm{'private-Error.pm'} = '$(INST_LIBDIR)/Error.pm';\n }\n \n-- \n1.7.11.1\n"},{"id":"195698","messageId":"1343186471-1024-4-git-send-email-schwern@pobox.com","threadId":"31091","inReplyTo":"1343186471-1024-1-git-send-email-schwern@pobox.com","subject":"[PATCH 3/3] The Makefile.PL will now find .pm files itself.","fromName":"Michael G. Schwern","fromEmail":"schwern@pobox.com","sentAt":"2012-07-25T03:21:11Z","receivedAt":"2012-07-25T03:21:11Z","isPatch":true,"sender":{"key":"schwern@pobox.com","avatar":"https://avatars.githubusercontent.com/u/25888?v=4"},"body":"From: \"Michael G. Schwern\" \n\nIt is no longer necessary to manually add new .pm files to the\nMakefile.PL. This makes it easier to add modules.\n\nIt is still necessary to add them to the Makefile, but that extra work\nshould be removed at a future date.\n\nSigned-off-by: Michael G Schwern \n---\n perl/Makefile.PL | 29 ++++++++++++++++-------------\n 1 file changed, 16 insertions(+), 13 deletions(-)\n\ndiff --git a/perl/Makefile.PL b/perl/Makefile.PL\nindex 887fa1b..3f29ba9 100644\n--- a/perl/Makefile.PL\n+++ b/perl/Makefile.PL\n@@ -2,6 +2,10 @@ use strict;\n use warnings;\n use ExtUtils::MakeMaker;\n use Getopt::Long;\n+use File::Find;\n+\n+# Don't forget to update the perl/Makefile, too.\n+# Don't forget to test with NO_PERL_MAKEMAKER=YesPlease\n \n # Sanity: die at first unknown option\n Getopt::Long::Configure qw/ pass_through /;\n@@ -25,19 +29,18 @@ endif\n MAKE_FRAG\n }\n \n-# XXX. When editing this list:\n-#\n-# * Please update perl/Makefile, too.\n-# * Don't forget to test with NO_PERL_MAKEMAKER=YesPlease\n-my %pm = (\n-\t'Git.pm' => '$(INST_LIBDIR)/Git.pm',\n-\t'Git/I18N.pm' => '$(INST_LIBDIR)/Git/I18N.pm',\n-\t'Git/SVN/Memoize/YAML.pm' => '$(INST_LIBDIR)/Git/SVN/Memoize/YAML.pm',\n-\t'Git/SVN/Fetcher.pm' => '$(INST_LIBDIR)/Git/SVN/Fetcher.pm',\n-\t'Git/SVN/Editor.pm' => '$(INST_LIBDIR)/Git/SVN/Editor.pm',\n-\t'Git/SVN/Prompt.pm' => '$(INST_LIBDIR)/Git/SVN/Prompt.pm',\n-\t'Git/SVN/Ra.pm' => '$(INST_LIBDIR)/Git/SVN/Ra.pm',\n-);\n+# Find all the .pm files in \"Git/\" and Git.pm\n+my %pm;\n+find sub {\n+\treturn unless /\\.pm$/;\n+\n+\t# sometimes File::Find prepends a ./ Strip it.\n+\tmy $pm_path = $File::Find::name;\n+\t$pm_path =~ s{^\\./}{};\n+\n+\t$pm{$pm_path} = '$(INST_LIBDIR)/'.$pm_path;\n+}, \"Git\", \"Git.pm\";\n+\n \n # We come with our own bundled Error.pm. It's not in the set of default\n # Perl modules so install it if it's not available on the system yet.\n-- \n1.7.11.1\n"},{"id":"195766","messageId":"7vhasvdbk9.fsf@alter.siamese.dyndns.org","threadId":"31091","inReplyTo":"1343186471-1024-1-git-send-email-schwern@pobox.com","subject":"Re: Teach Makefile.PL to find .pm files on its own","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-07-25T16:56:22Z","receivedAt":"2012-07-25T16:56:22Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Looks sensible. Will queue.\n\nThanks.\n"},{"id":"195781","messageId":"5010567B.1060907@pobox.com","threadId":"31091","inReplyTo":"7vhasvdbk9.fsf@alter.siamese.dyndns.org","subject":"Re: Teach Makefile.PL to find .pm files on its own","fromName":"Michael G Schwern","fromEmail":"schwern@pobox.com","sentAt":"2012-07-25T20:26:35Z","receivedAt":"2012-07-25T20:26:35Z","isPatch":false,"sender":{"key":"schwern@pobox.com","avatar":"https://avatars.githubusercontent.com/u/25888?v=4"},"body":"On 2012.7.25 9:56 AM, Junio C Hamano wrote:\n> Looks sensible. Will queue.\n> \n> Thanks.\n\nThanks!\n\nWhat's the lag time on it showing up in the repo, and which branch will it\nappear in?\n\nAlso I just realized I've been basing my work on master. Should I move to maint?\n\n\n-- \nIf you want the truth to stand clear before you, never be for or against.\nThe struggle between \"for\" and \"against\" is the mind's worst disease.\n -- Sent-ts'an\n"},{"id":"195782","messageId":"7vehnzbmyt.fsf@alter.siamese.dyndns.org","threadId":"31091","inReplyTo":"5010567B.1060907@pobox.com","subject":"Re: Teach Makefile.PL to find .pm files on its own","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-07-25T20:32:58Z","receivedAt":"2012-07-25T20:32:58Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Michael G Schwern writes:\n\n> What's the lag time on it showing up in the repo, and which branch will it\n> appear in?\n\nThere is nothing special in this topic, so it is likely to start on\n'pu', and unlikely to come to 'master' before 1.7.12 ships sometime\nnext month.\n\n> Also I just realized I've been basing my work on master. Should I move to maint?\n\nI don't think so. It is not fixing any urgent breakage (iow, by\nbeing told about .pm explicitly, it knows about them just fine\nwithout being taught how to find them).\n"},{"id":"195787","messageId":"20120725211143.GA5455@burratino","threadId":"31091","inReplyTo":"1343186471-1024-4-git-send-email-schwern@pobox.com","subject":"Re: [PATCH 3/3] The Makefile.PL will now find .pm files itself.","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2012-07-25T21:11:44Z","receivedAt":"2012-07-25T21:11:44Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nMichael G. Schwern wrote:\n\n> It is no longer necessary to manually add new .pm files to the\n> Makefile.PL. This makes it easier to add modules.\n\nThanks! Sorry I missed this.\n\n[...]\n> --- a/perl/Makefile.PL\n> +++ b/perl/Makefile.PL\n> @@ -2,6 +2,10 @@ use strict;\n> use warnings;\n> use ExtUtils::MakeMaker;\n> use Getopt::Long;\n> +use File::Find;\n> +\n> +# Don't forget to update the perl/Makefile, too.\n> +# Don't forget to test with NO_PERL_MAKEMAKER=YesPlease\n\nIn a previous apartment I lived in, there was a note taped to the\nlightswitch reminding us to turn off the heat, take keys with us, and\nlock the door. The note was useful because by force of habit we would\nbe turning off the light, and as a result see the note, on the way\nout.\n\nWho are these comments in perl/Makefile.PL addressed to? Why would\nsuch a person be looking at perl/Makefile.PL? Sorry to sound like a\nbroken record, but I don't think these questions were answered yet.\n\nHow about this patch for squashing in, which would avoid the question\nand save me from having to worry that my words are going to stay in\nthis file after the no-makemaker option no longer exists because\nnobody looks at them here?\n\ndiff --git i/perl/Makefile.PL w/perl/Makefile.PL\nindex 3d88a6b9..377fd042 100644\n--- i/perl/Makefile.PL\n+++ w/perl/Makefile.PL\n@@ -4,9 +4,6 @@ use ExtUtils::MakeMaker;\n use Getopt::Long;\n use File::Find;\n \n-# Don't forget to update the perl/Makefile, too.\n-# Don't forget to test with NO_PERL_MAKEMAKER=YesPlease\n-\n # Sanity: die at first unknown option\n Getopt::Long::Configure qw/ pass_through /;\n \n"},{"id":"195788","messageId":"50106136.5000404@pobox.com","threadId":"31091","inReplyTo":"7vehnzbmyt.fsf@alter.siamese.dyndns.org","subject":"Re: Teach Makefile.PL to find .pm files on its own","fromName":"Michael G Schwern","fromEmail":"schwern@pobox.com","sentAt":"2012-07-25T21:12:22Z","receivedAt":"2012-07-25T21:12:22Z","isPatch":false,"sender":{"key":"schwern@pobox.com","avatar":"https://avatars.githubusercontent.com/u/25888?v=4"},"body":"On 2012.7.25 1:32 PM, Junio C Hamano wrote:\n> Michael G Schwern writes:\n> \n>> What's the lag time on it showing up in the repo, and which branch will it\n>> appear in?\n> \n> There is nothing special in this topic, so it is likely to start on\n> 'pu', and unlikely to come to 'master' before 1.7.12 ships sometime\n> next month.\n\nOk.\n\n\n>> Also I just realized I've been basing my work on master. Should I move to maint?\n> \n> I don't think so. It is not fixing any urgent breakage (iow, by\n> being told about .pm explicitly, it knows about them just fine\n> without being taught how to find them).\n\nHow about the git-svn SVN 1.7 fix in general? All of these patch sets I'm\nsending build on one another, is that going to be a problem? It's going to\ncome in about six parts.\n\n1) Makefile.PL .pm auto-find\n2) Extract Git::SVN from git-svn\n3) Extract the other modules from git-svn\n4) Create and use accessors for paths and urls\n5) Make the accessors canonicalize\n6) Fix misc canonicalization issues\n\nThis is #1. #2 was submitted last night. #3 will be coming today. #4 should\nprobably wait until #3 is at least in pu and I stop moving around large chunks\nof code.\n\n#1 to #4 are all refactorings with no functional changes. #5 and #6 will be\ntricky to provide as small commits while keeping all tests passing in SVN 1.6.\n We'll see when I get there after doing the rebasing necessary to separate #4,\n#5 and #6.\n\n\n-- \n10. Not allowed to purchase anyone's soul on government time.\n -- The 213 Things Skippy Is No Longer Allowed To Do In The U.S. Army\n http://skippyslist.com/list/\n"},{"id":"195791","messageId":"20120725213112.GG4732@burratino","threadId":"31091","inReplyTo":"20120725211143.GA5455@burratino","subject":"Re: [PATCH 3/3] The Makefile.PL will now find .pm files itself.","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2012-07-25T21:31:12Z","receivedAt":"2012-07-25T21:31:12Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Jonathan Nieder wrote:\n> Michael G. Schwern wrote:\n\n>> --- a/perl/Makefile.PL\n>> +++ b/perl/Makefile.PL\n>> @@ -2,6 +2,10 @@ use strict;\n>> use warnings;\n>> use ExtUtils::MakeMaker;\n>> use Getopt::Long;\n>> +use File::Find;\n>> +\n>> +# Don't forget to update the perl/Makefile, too.\n>> +# Don't forget to test with NO_PERL_MAKEMAKER=YesPlease\n[...]\n> Who are these comments in perl/Makefile.PL addressed to? Why would\n> such a person be looking at perl/Makefile.PL? Sorry to sound like a\n> broken record, but I don't think these questions were answered yet.\n\nTo maybe answer my own question: are these comments addressed to\npeople making other changes to perl/Makefile.PL, rather than people\nadding new modules?\n\nThat could make sense --- it would just be a change in purpose from\nthe original comments. It also means there's no reminder when adding\nnew modules to list them in perl/Makefile any more, but that's\nprobably inevitable as long as we don't have a perl coding style\ndocument.\n\nHoping that clarifies,\nJonathan\n"},{"id":"195792","messageId":"501069E9.2000009@pobox.com","threadId":"31091","inReplyTo":"20120725211143.GA5455@burratino","subject":"Re: [PATCH 3/3] The Makefile.PL will now find .pm files itself.","fromName":"Michael G Schwern","fromEmail":"schwern@pobox.com","sentAt":"2012-07-25T21:49:29Z","receivedAt":"2012-07-25T21:49:29Z","isPatch":true,"sender":{"key":"schwern@pobox.com","avatar":"https://avatars.githubusercontent.com/u/25888?v=4"},"body":"On 2012.7.25 2:11 PM, Jonathan Nieder wrote:\n>> --- a/perl/Makefile.PL\n>> +++ b/perl/Makefile.PL\n>> @@ -2,6 +2,10 @@ use strict;\n>> use warnings;\n>> use ExtUtils::MakeMaker;\n>> use Getopt::Long;\n>> +use File::Find;\n>> +\n>> +# Don't forget to update the perl/Makefile, too.\n>> +# Don't forget to test with NO_PERL_MAKEMAKER=YesPlease\n> \n> In a previous apartment I lived in, there was a note taped to the\n> lightswitch reminding us to turn off the heat, take keys with us, and\n> lock the door. The note was useful because by force of habit we would\n> be turning off the light, and as a result see the note, on the way\n> out.\n> \n> Who are these comments in perl/Makefile.PL addressed to?\n\nSomebody adding, renaming or deleting a .pm file.\n\n> Why would such a person be looking at perl/Makefile.PL?\n\nBecause sometimes they do wacky things, especially in non-Perl projects, its\ngood to check.\n\n> Sorry to sound like a broken record, but I don't think these questions\n> were answered yet.\n\nThe instructions are still necessary and I don't know where to put them so\nthey have a better chance to be seen. At least somebody adding a .pm file\nmight glance inside the Makefile.PL.\n\n\n> How about this patch for squashing in, which would avoid the question\n> and save me from having to worry that my words are going to stay in\n> this file after the no-makemaker option no longer exists because\n> nobody looks at them here?\n\nIf somebody eliminates NO_PERL_MAKEMAKER they'd grep the tree for all its\noccurrences. I'd rather keep the instructions in there, because having two\nbuild systems is downright wacky. In fact, I'd go on to say that an\nexplanation should be added to the Makefile as well.\n\nThis is out of scope for what I wanted this patch to do, and I really don't\nhave a horse in this race. For my purposes, I just preserved the comment. If\nit goes away that's ok, too.\n\nLater on I can help getting rid of the second build system.\n\n\n> diff --git i/perl/Makefile.PL w/perl/Makefile.PL\n> index 3d88a6b9..377fd042 100644\n> --- i/perl/Makefile.PL\n> +++ w/perl/Makefile.PL\n> @@ -4,9 +4,6 @@ use ExtUtils::MakeMaker;\n> use Getopt::Long;\n> use File::Find;\n> \n> -# Don't forget to update the perl/Makefile, too.\n> -# Don't forget to test with NO_PERL_MAKEMAKER=YesPlease\n> -\n> # Sanity: die at first unknown option\n> Getopt::Long::Configure qw/ pass_through /;\n\n\n\n-- \n31. Not allowed to let sock puppets take responsibility for any of my\n actions.\n -- The 213 Things Skippy Is No Longer Allowed To Do In The U.S. Army\n http://skippyslist.com/list/\n"},{"id":"195795","messageId":"20120725215617.GI4732@burratino","threadId":"31091","inReplyTo":"501069E9.2000009@pobox.com","subject":"Re: [PATCH 3/3] The Makefile.PL will now find .pm files itself.","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2012-07-25T21:56:17Z","receivedAt":"2012-07-25T21:56:17Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Michael G Schwern wrote:\n> On 2012.7.25 2:11 PM, Jonathan Nieder wrote:\n\n>> Who are these comments in perl/Makefile.PL addressed to?\n>\n> Somebody adding, renaming or deleting a .pm file.\n>\n>> Why would such a person be looking at perl/Makefile.PL?\n>\n> Because sometimes they do wacky things\n\nNot convincing at all. ;-)\n\nBut my made-up justification about people making other changes to\nperl/Makefile.PL convinced me, so keeping the comments seems fine to\nme now.\n\n[...]\n> For my purposes, I just preserved the comment.\n\nThat's what I feared and how cruft collects. Sorry for the lack of\nclarity.\n\nThanks,\nJonathan\n"},{"id":"195800","messageId":"7vsjcfa3ha.fsf@alter.siamese.dyndns.org","threadId":"31091","inReplyTo":"50106136.5000404@pobox.com","subject":"Re: Teach Makefile.PL to find .pm files on its own","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-07-25T22:19:13Z","receivedAt":"2012-07-25T22:19:13Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Michael G Schwern writes:\n\n>>> Also I just realized I've been basing my work on master. Should I move to maint?\n>> \n>> I don't think so. It is not fixing any urgent breakage (iow, by\n>> being told about .pm explicitly, it knows about them just fine\n>> without being taught how to find them).\n>\n> How about the git-svn SVN 1.7 fix in general? All of these patch sets I'm\n> sending build on one another, is that going to be a problem? It's going to\n> come in about six parts.\n\nJudging from the rate of the discussion this is progressing, I was\nimagining that this series would be ready by 1.7.13 at the earliest,\npossibly back-merged to 1.7.12.X maintenance series, and 1.7.11.X\nmaintenance series is no longer relevant by then.\n\nBut I certainly do not mind seeing the series based on earlier\nmaintenance releases, e.g. maint-1.7.9. There however are tons of\nother git-svn.perl and perl/ updates since then, so basing the\nseries on the current maint branch to abandon 1.7.10.X and earlier\nbut still leaving the door open to downmerge to 1.7.11.X may be a\ngood trade-off.\n"},{"id":"195803","messageId":"5010798E.6020401@pobox.com","threadId":"31091","inReplyTo":"7vsjcfa3ha.fsf@alter.siamese.dyndns.org","subject":"Re: Teach Makefile.PL to find .pm files on its own","fromName":"Michael G Schwern","fromEmail":"schwern@pobox.com","sentAt":"2012-07-25T22:56:14Z","receivedAt":"2012-07-25T22:56:14Z","isPatch":false,"sender":{"key":"schwern@pobox.com","avatar":"https://avatars.githubusercontent.com/u/25888?v=4"},"body":"On 2012.7.25 3:19 PM, Junio C Hamano wrote:\n> Michael G Schwern writes:\n>> How about the git-svn SVN 1.7 fix in general? All of these patch sets I'm\n>> sending build on one another, is that going to be a problem? It's going to\n>> come in about six parts.\n> \n> Judging from the rate of the discussion this is progressing, I was\n> imagining that this series would be ready by 1.7.13 at the earliest,\n> possibly back-merged to 1.7.12.X maintenance series, and 1.7.11.X\n> maintenance series is no longer relevant by then.\n> \n> But I certainly do not mind seeing the series based on earlier\n> maintenance releases, e.g. maint-1.7.9. There however are tons of\n> other git-svn.perl and perl/ updates since then, so basing the\n> series on the current maint branch to abandon 1.7.10.X and earlier\n> but still leaving the door open to downmerge to 1.7.11.X may be a\n> good trade-off.\n\nSo... is that master or maint? Just let me know which one.\n\n\n-- \n91. I am not authorized to initiate Jihad.\n -- The 213 Things Skippy Is No Longer Allowed To Do In The U.S. Army\n http://skippyslist.com/list/\n"},{"id":"195805","messageId":"7vk3xra07x.fsf@alter.siamese.dyndns.org","threadId":"31091","inReplyTo":"5010798E.6020401@pobox.com","subject":"Re: Teach Makefile.PL to find .pm files on its own","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-07-25T23:29:38Z","receivedAt":"2012-07-25T23:29:38Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Michael G Schwern writes:\n\n> On 2012.7.25 3:19 PM, Junio C Hamano wrote:\n>> Michael G Schwern writes:\n>>> How about the git-svn SVN 1.7 fix in general? All of these patch sets I'm\n>>> sending build on one another, is that going to be a problem? It's going to\n>>> come in about six parts.\n>> \n>> Judging from the rate of the discussion this is progressing, I was\n>> imagining that this series would be ready by 1.7.13 at the earliest,\n>> possibly back-merged to 1.7.12.X maintenance series, and 1.7.11.X\n>> maintenance series is no longer relevant by then.\n>> \n>> But I certainly do not mind seeing the series based on earlier\n>> maintenance releases, e.g. maint-1.7.9. There however are tons of\n>> other git-svn.perl and perl/ updates since then, so basing the\n>> series on the current maint branch to abandon 1.7.10.X and earlier\n>> but still leaving the door open to downmerge to 1.7.11.X may be a\n>> good trade-off.\n>\n> So... is that master or maint? Just let me know which one.\n\nI do not care too deeply either way, and in the end I think Eric\nshould have the final say.\n\nGiven that git://git.bogomips.org/git-svn.git/ has 'master' but\nnothing to build on 'maint', I would imagine that basing on master\nis just fine.\n\nThanks.\n"},{"id":"195806","messageId":"20120725233755.GA9036@dcvr.yhbt.net","threadId":"31091","inReplyTo":"7vk3xra07x.fsf@alter.siamese.dyndns.org","subject":"Re: Teach Makefile.PL to find .pm files on its own","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2012-07-25T23:37:56Z","receivedAt":"2012-07-25T23:37:56Z","isPatch":false,"sender":{"key":"e@80x24.org","avatar":null},"body":"Junio C Hamano wrote:\n> Michael G Schwern writes:\n> > So... is that master or maint? Just let me know which one.\n> \n> I do not care too deeply either way, and in the end I think Eric\n> should have the final say.\n> \n> Given that git://git.bogomips.org/git-svn.git/ has 'master' but\n> nothing to build on 'maint', I would imagine that basing on master\n> is just fine.\n\nYes, \"master\" is fine.\n"}]}