{"thread":{"id":"31002","subject":"[PATCH 6/6] t4012: Make --shortstat more robust","startedAt":"2012-07-11T22:13:27Z","lastAt":"2012-07-12T04:44:51Z","messageCount":3,"participants":["Alexander Strasser","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":6},"messages":[{"id":"194943","messageId":"20120711221327.GA21382@akuma","threadId":"31002","inReplyTo":null,"subject":"[PATCH 6/6] t4012: Make --shortstat more robust","fromName":"Alexander Strasser","fromEmail":"eclipse7@gmx.net","sentAt":"2012-07-11T22:13:27Z","receivedAt":"2012-07-11T22:13:27Z","isPatch":true,"sender":{"key":"eclipse7@gmx.net","avatar":"https://avatars.githubusercontent.com/u/4342576?v=4"},"body":"The --shortstat test depends on the same scenario as the\n--stat test. Use the part of the same expected result for\nthe --stat test to avoid duplicating it manually.\n\nSigned-off-by: Alexander Strasser <eclipse7@gmx.net>\n---\n t/t4012-diff-binary.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh\nindex 81a9e8c..a3f6030 100755\n--- a/t/t4012-diff-binary.sh\n+++ b/t/t4012-diff-binary.sh\n@@ -38,9 +38,9 @@ test_expect_success 'apply --stat output for binary file change' '\n '\n \n test_expect_success 'diff --shortstat output for binary file change' '\n-\techo \" 4 files changed, 2 insertions(+), 2 deletions(-)\" >expected &&\n+\ttail -1 expected >expect &&\n \tgit diff --shortstat >current &&\n-\ttest_i18ncmp expected current\n+\ttest_i18ncmp expect current\n '\n \n test_expect_success 'diff --shortstat output for binary file change only' '\n-- \n1.7.10.2.552.gaa3bb87\n"},{"id":"194947","messageId":"7vr4sic4e7.fsf@alter.siamese.dyndns.org","threadId":"31002","inReplyTo":"20120711221327.GA21382@akuma","subject":"Re: [PATCH 6/6] t4012: Make --shortstat more robust","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-07-11T22:35:44Z","receivedAt":"2012-07-11T22:35:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alexander Strasser <eclipse7@gmx.net> writes:\n\n> The --shortstat test depends on the same scenario as the --stat\n> test. Use the part of the same expected result for the --stat test\n> to avoid duplicating it manually.\n\n> diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh\n> index 81a9e8c..a3f6030 100755\n> --- a/t/t4012-diff-binary.sh\n> +++ b/t/t4012-diff-binary.sh\n> @@ -38,9 +38,9 @@ test_expect_success 'apply --stat output for binary file change' '\n>  '\n>  \n>  test_expect_success 'diff --shortstat output for binary file change' '\n> -\techo \" 4 files changed, 2 insertions(+), 2 deletions(-)\" >expected &&\n> +\ttail -1 expected >expect &&\n\n\"(tail|head) -n 1\" is preferred.  There are the same POSIX.1\nviolations in a handful of other scripts, 5526, 7502, 7800 and\n9146.\n\n>  \tgit diff --shortstat >current &&\n> -\ttest_i18ncmp expected current\n> +\ttest_i18ncmp expect current\n>  '\n>  \n>  test_expect_success 'diff --shortstat output for binary file change only' '\n\nOther than that, the series looked good.  Thanks.\n"},{"id":"194951","messageId":"20120712044451.GA23758@akuma","threadId":"31002","inReplyTo":"7vr4sic4e7.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 6/6] t4012: Make --shortstat more robust","fromName":"Alexander Strasser","fromEmail":"eclipse7@gmx.net","sentAt":"2012-07-12T04:44:51Z","receivedAt":"2012-07-12T04:44:51Z","isPatch":true,"sender":{"key":"eclipse7@gmx.net","avatar":"https://avatars.githubusercontent.com/u/4342576?v=4"},"body":"Hi,\n\n  seems I managed to omit a word in the short log message:\n  t4012: Make --shortstat *test* more robust\n\nJunio C Hamano wrote:\n> Alexander Strasser <eclipse7@gmx.net> writes:\n> \n> > The --shortstat test depends on the same scenario as the --stat\n> > test. Use the part of the same expected result for the --stat test\n> > to avoid duplicating it manually.\n> \n> > diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh\n> > index 81a9e8c..a3f6030 100755\n> > --- a/t/t4012-diff-binary.sh\n> > +++ b/t/t4012-diff-binary.sh\n> > @@ -38,9 +38,9 @@ test_expect_success 'apply --stat output for binary file change' '\n> >  '\n> >  \n> >  test_expect_success 'diff --shortstat output for binary file change' '\n> > -\techo \" 4 files changed, 2 insertions(+), 2 deletions(-)\" >expected &&\n> > +\ttail -1 expected >expect &&\n> \n> \"(tail|head) -n 1\" is preferred.  There are the same POSIX.1\n> violations in a handful of other scripts, 5526, 7502, 7800 and\n> 9146.\n\n  OK, got it.\n\n> >  \tgit diff --shortstat >current &&\n> > -\ttest_i18ncmp expected current\n> > +\ttest_i18ncmp expect current\n> >  '\n> >  \n> >  test_expect_success 'diff --shortstat output for binary file change only' '\n> \n> Other than that, the series looked good.  Thanks.\n\n  I will wait a bit longer for comments and then resend a corrected\nversion. Thanks for the quick reply.\n\n  Alexander\n"}]}