{"thread":{"id":"31000","subject":"[PATCH 3/6] t4012: Actually quote the sed script","startedAt":"2012-07-11T22:12:41Z","lastAt":"2012-07-12T22:26:52Z","messageCount":3,"participants":["Alexander Strasser","Zbigniew Jędrzejewski-Szmek"],"isPatch":true,"patchVersion":1,"patchTotal":6},"messages":[{"id":"194941","messageId":"20120711221241.GA21342@akuma","threadId":"31000","inReplyTo":null,"subject":"[PATCH 3/6] t4012: Actually quote the sed script","fromName":"Alexander Strasser","fromEmail":"eclipse7@gmx.net","sentAt":"2012-07-11T22:12:41Z","receivedAt":"2012-07-11T22:12:41Z","isPatch":true,"sender":{"key":"eclipse7@gmx.net","avatar":"https://avatars.githubusercontent.com/u/4342576?v=4"},"body":"The nested quoting is not needed in this cases, thus the previous\nversion did work just fine. Never the less the usage is misleading,\nso just achieve nested quoting by using double quotes instead. Lower\nthe probability of breakage in the future and make the code easier\nto read.\n\nNOTE: Just dropping the single quotes around the sed arguments would\n      have also been possible.\n\nSigned-off-by: Alexander Strasser <eclipse7@gmx.net>\n---\n t/t4012-diff-binary.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh\nindex 3c54269..60c2f6c 100755\n--- a/t/t4012-diff-binary.sh\n+++ b/t/t4012-diff-binary.sh\n@@ -64,7 +64,7 @@ test_expect_success 'apply --numstat understands diff --binary format' '\n # apply needs to be able to skip the binary material correctly\n # in order to report the line number of a corrupt patch.\n test_expect_success 'apply detecting corrupt patch correctly' '\n-\t git diff | sed -e 's/-CIT/xCIT/' >broken &&\n+\t git diff | sed -e \"s/-CIT/xCIT/\" >broken &&\n \t if git apply --stat --summary broken 2>detected\n \t then\n \t\techo unhappy - should have detected an error\n@@ -79,7 +79,7 @@ test_expect_success 'apply detecting corrupt patch correctly' '\n '\n \n test_expect_success 'apply detecting corrupt patch correctly' '\n-\t git diff --binary | sed -e 's/-CIT/xCIT/' >broken &&\n+\t git diff --binary | sed -e \"s/-CIT/xCIT/\" >broken &&\n \t if git apply --stat --summary broken 2>detected\n \t then\n \t\techo unhappy - should have detected an error\n-- \n1.7.10.2.552.gaa3bb87\n"},{"id":"194961","messageId":"4FFEBFE2.5030206@in.waw.pl","threadId":"31000","inReplyTo":"20120711221241.GA21342@akuma","subject":"Re: [PATCH 3/6] t4012: Actually quote the sed script","fromName":"Zbigniew Jędrzejewski-Szmek","fromEmail":"zbyszek@in.waw.pl","sentAt":"2012-07-12T12:15:30Z","receivedAt":"2012-07-12T12:15:30Z","isPatch":true,"sender":{"key":"zbyszek@in.waw.pl","avatar":"https://avatars.githubusercontent.com/u/349618?v=4"},"body":"On 07/12/2012 12:12 AM, Alexander Strasser wrote:\n> The nested quoting is not needed in this cases, thus the previous\n> version did work just fine. Never the less the usage is misleading,\n> so just achieve nested quoting by using double quotes instead. Lower\n> the probability of breakage in the future and make the code easier\n> to read.\n\nHi,\n\nI have some spelling corrections (minor, but since you intend to re-roll\nanyway, I'll post them), and one more thing which could be corrected\n(below).\n\n3/6: s/Never the less/Nevertheless/\n4/6: s/masquerading/masking/     (masquerade means to \"mask oneself\")\n\n>  \t if git apply --stat --summary broken 2>detected\n>  \t then\n>  \t\techo unhappy - should have detected an error\n> @@ -79,7 +79,7 @@ test_expect_success 'apply detecting corrupt patch correctly' '\n>  '\n>  \n>  test_expect_success 'apply detecting corrupt patch correctly' '\n> -\t git diff --binary | sed -e 's/-CIT/xCIT/' >broken &&\n> +\t git diff --binary | sed -e \"s/-CIT/xCIT/\" >broken &&\n>  \t if git apply --stat --summary broken 2>detected\n>  \t then\n>  \t\techo unhappy - should have detected an error\nI think this can be changed to:\n   test_must_fail git apply --stat --summary broken 2>detected\n\n-\nZbyszek\n"},{"id":"194992","messageId":"20120712222652.GB2782@akuma","threadId":"31000","inReplyTo":"4FFEBFE2.5030206@in.waw.pl","subject":"Re: [PATCH 3/6] t4012: Actually quote the sed script","fromName":"Alexander Strasser","fromEmail":"eclipse7@gmx.net","sentAt":"2012-07-12T22:26:52Z","receivedAt":"2012-07-12T22:26:52Z","isPatch":true,"sender":{"key":"eclipse7@gmx.net","avatar":"https://avatars.githubusercontent.com/u/4342576?v=4"},"body":"Hi Zbigniew,\n\nZbigniew Jędrzejewski-Szmek wrote:\n> On 07/12/2012 12:12 AM, Alexander Strasser wrote:\n[...]\n> I have some spelling corrections (minor, but since you intend to re-roll\n> anyway, I'll post them), and one more thing which could be corrected\n> (below).\n> \n> 3/6: s/Never the less/Nevertheless/\n> 4/6: s/masquerading/masking/     (masquerade means to \"mask oneself\")\n[...]\n> >  \t if git apply --stat --summary broken 2>detected\n> >  \t then\n> >  \t\techo unhappy - should have detected an error\n> I think this can be changed to:\n>    test_must_fail git apply --stat --summary broken 2>detected\n\n  Thank you for your sharp feedback. I will implement the requested\nchanges for the re-roll.\n\n  Alexander\n"}]}