{"thread":{"id":"30978","subject":"[PATCH] git-remote-mediawiki: update comments to reflect credential support","startedAt":"2012-07-08T16:18:28Z","lastAt":"2012-07-09T02:17:16Z","messageCount":2,"participants":["Matthieu Moy","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"194790","messageId":"1341764308-9508-1-git-send-email-Matthieu.Moy@imag.fr","threadId":"30978","inReplyTo":null,"subject":"[PATCH] git-remote-mediawiki: update comments to reflect credential support","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@imag.fr","sentAt":"2012-07-08T16:18:28Z","receivedAt":"2012-07-08T16:18:28Z","isPatch":true,"sender":{"key":"git@matthieu-moy.fr","avatar":"https://avatars.githubusercontent.com/u/14709?v=4"},"body":"\nSigned-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>\n---\n\nJunio, can you add this to mm/credential-plumbing in pu, or better,\nsquash it into the last patch of the serie (i.e. a7271ad1dccaf1,\ngit-remote-mediawiki: add credential support)?\n\nThanks,\n\n contrib/mw-to-git/git-remote-mediawiki | 7 +------\n 1 file changed, 1 insertion(+), 6 deletions(-)\n\ndiff --git a/contrib/mw-to-git/git-remote-mediawiki b/contrib/mw-to-git/git-remote-mediawiki\nindex 539718e..c07b4f0 100755\n--- a/contrib/mw-to-git/git-remote-mediawiki\n+++ b/contrib/mw-to-git/git-remote-mediawiki\n@@ -26,9 +26,6 @@\n # - Git renames could be turned into MediaWiki renames (see TODO\n #   below)\n #\n-# - login/password support requires the user to write the password\n-#   cleartext in a file (see TODO below).\n-#\n # - No way to import \"one page, and all pages included in it\"\n #\n # - Multiple remote MediaWikis have not been very well tested.\n@@ -74,9 +71,7 @@ my @tracked_categories = split(/[ \\n]/, run_git(\"config --get-all remote.\". $rem\n chomp(@tracked_categories);\n \n my $wiki_login = run_git(\"config --get remote.\". $remotename .\".mwLogin\");\n-# TODO: ideally, this should be able to read from keyboard, but we're\n-# inside a remote helper, so our stdin is connect to git, not to a\n-# terminal.\n+# Note: mwPassword is discourraged. Use the credential system instead.\n my $wiki_passwd = run_git(\"config --get remote.\". $remotename .\".mwPassword\");\n my $wiki_domain = run_git(\"config --get remote.\". $remotename .\".mwDomain\");\n chomp($wiki_login);\n-- \n1.7.11.1.147.g47a574d\n"},{"id":"194796","messageId":"7vd345n0er.fsf@alter.siamese.dyndns.org","threadId":"30978","inReplyTo":"1341764308-9508-1-git-send-email-Matthieu.Moy@imag.fr","subject":"Re: [PATCH] git-remote-mediawiki: update comments to reflect credential support","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-07-09T02:17:16Z","receivedAt":"2012-07-09T02:17:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"thanks; done.\n"}]}