{"thread":{"id":"30950","subject":"[PATCH] t3404: make test 57 work with dash and others","startedAt":"2012-07-04T11:32:04Z","lastAt":"2012-07-05T22:29:17Z","messageCount":2,"participants":["Michael J Gruber","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"194614","messageId":"40eccb55835575b4a73131d1dced857ba7d4ecc3.1341401445.git.git@drmicha.warpmail.net","threadId":"30950","inReplyTo":null,"subject":"[PATCH] t3404: make test 57 work with dash and others","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2012-07-04T11:32:04Z","receivedAt":"2012-07-04T11:32:04Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"The construct\n\nVAR=value test_must_fail command args\n\nworks only for some shells (such as bash) but not others (such as dash)\nbecause VAR=value does not end up in the environment for command when it\nis called by the shell function test_must_fail. That is why we write\n\n( VAR=value &&\nexport VAR &&\ntest_must_fail command args)\n\nin most places already, bar the newly introduced 57 from\nb64b7fe (Add tests for rebase -i --root without --onto, 2012-06-26).\n\nMake test 57 use that construct also.\n\nSigned-off-by: Michael J Gruber <git@drmicha.warpmail.net>\n---\n t/t3404-rebase-interactive.sh | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)\n\ndiff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh\nindex 6ffc9c2..2f060ec 100755\n--- a/t/t3404-rebase-interactive.sh\n+++ b/t/t3404-rebase-interactive.sh\n@@ -777,7 +777,9 @@ test_expect_success 'rebase -i --root retain root commit author and message' '\n \n test_expect_success 'rebase -i --root temporary sentinel commit' '\n \tgit checkout B &&\n-\tFAKE_LINES=\"2\" test_must_fail git rebase -i --root &&\n+\t( FAKE_LINES=\"2\" &&\n+\texport FAKE_LINES &&\n+\ttest_must_fail git rebase -i --root ) &&\n \tgit cat-file commit HEAD | grep \"^tree 4b825dc642cb\" &&\n \tgit rebase --abort\n '\n-- \n1.7.11.1.214.g6a2db03\n"},{"id":"194680","messageId":"7v8vexrgea.fsf@alter.siamese.dyndns.org","threadId":"30950","inReplyTo":"40eccb55835575b4a73131d1dced857ba7d4ecc3.1341401445.git.git@drmicha.warpmail.net","subject":"Re: [PATCH] t3404: make test 57 work with dash and others","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-07-05T22:29:17Z","receivedAt":"2012-07-05T22:29:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks!\n"}]}