{"thread":{"id":"30819","subject":"Incorrect v1.7.10.4 tag on github?","startedAt":"2012-06-15T16:51:00Z","lastAt":"2012-07-02T21:58:48Z","messageCount":9,"participants":["Graham Ballantyne","Jeff King","Junio C Hamano","Dan Johnson","Scott Chacon"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"193713","messageId":"77A5E1CD-836A-4747-9E62-42C25C0D8B7D@sfu.ca","threadId":"30819","inReplyTo":null,"subject":"Incorrect v1.7.10.4 tag on github?","fromName":"Graham Ballantyne","fromEmail":"grahamb@sfu.ca","sentAt":"2012-06-15T16:51:00Z","receivedAt":"2012-06-15T16:51:00Z","isPatch":false,"sender":{"key":"grahamb@sfu.ca","avatar":null},"body":"I just downloaded the 1.7.10.4 tag from github. After compiling and installing, git --version returns \"git version 1.7.10.3\". I think that tag might be pointing to the wrong commit? \n\n-- \nGraham Ballantyne\ngrahamb@sfu.ca\n\nIT Services\nSimon Fraser University\nBurnaby, BC V5A 1S6\nwww.sfu.ca/itservices\n\n\nSponsor me in the Ride to Conquer Cancer -- 300km from Vancouver to Seattle.\nhttp://conquercancer.ca/goto/grahamballantyne\n\n"},{"id":"193718","messageId":"20120615182534.GB14843@sigill.intra.peff.net","threadId":"30819","inReplyTo":"77A5E1CD-836A-4747-9E62-42C25C0D8B7D@sfu.ca","subject":"Re: Incorrect v1.7.10.4 tag on github?","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-06-15T18:25:34Z","receivedAt":"2012-06-15T18:25:34Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Jun 15, 2012 at 09:51:00AM -0700, Graham Ballantyne wrote:\n\n> I just downloaded the 1.7.10.4 tag from github. After compiling and\n> installing, git --version returns \"git version 1.7.10.3\". I think that\n> tag might be pointing to the wrong commit?\n\nLooks like 121f71f (Git 1.7.10.4, 2012-06-03) forgot to update DEF_VAR\nin GIT-VERSION-GEN. Operator error from the maintainer?\n\nIt builds with the right version from the git repository (which runs\ngit-describe and sees we are on the v1.7.10.4 tag), but exporting the\ntag's contents and building fails. I suspect that the git-1.7.10.4\ntarball on kernel.org would also have the same problem.\n\n-Peff\n"},{"id":"193724","messageId":"7vvcis9ylx.fsf@alter.siamese.dyndns.org","threadId":"30819","inReplyTo":"20120615182534.GB14843@sigill.intra.peff.net","subject":"Re: Incorrect v1.7.10.4 tag on github?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-06-15T19:14:18Z","receivedAt":"2012-06-15T19:14:18Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> On Fri, Jun 15, 2012 at 09:51:00AM -0700, Graham Ballantyne wrote:\n>\n>> I just downloaded the 1.7.10.4 tag from github. After compiling and\n>> installing, git --version returns \"git version 1.7.10.3\". I think that\n>> tag might be pointing to the wrong commit?\n>\n> Looks like 121f71f (Git 1.7.10.4, 2012-06-03) forgot to update DEF_VAR\n> in GIT-VERSION-GEN. Operator error from the maintainer?\n\nThanks for noticing.\n\n> It builds with the right version from the git repository (which runs\n> git-describe and sees we are on the v1.7.10.4 tag), but exporting the\n> tag's contents and building fails. I suspect that the git-1.7.10.4\n> tarball on kernel.org would also have the same problem.\n\nIt builds correctly if you download the tarball from the official\nlocation in the [ANNOUNCE] message. This is because the build\nprocedure for the official tarball does a bit more than just running\n\"git archive-tar\", which is what gitweb download interface does\n(namely, it adds the correct \"version\" file).\n"},{"id":"193725","messageId":"20120615191723.GA26651@sigill.intra.peff.net","threadId":"30819","inReplyTo":"7vvcis9ylx.fsf@alter.siamese.dyndns.org","subject":"Re: Incorrect v1.7.10.4 tag on github?","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-06-15T19:17:23Z","receivedAt":"2012-06-15T19:17:23Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Jun 15, 2012 at 12:14:18PM -0700, Junio C Hamano wrote:\n\n> > It builds with the right version from the git repository (which runs\n> > git-describe and sees we are on the v1.7.10.4 tag), but exporting the\n> > tag's contents and building fails. I suspect that the git-1.7.10.4\n> > tarball on kernel.org would also have the same problem.\n> \n> It builds correctly if you download the tarball from the official\n> location in the [ANNOUNCE] message. This is because the build\n> procedure for the official tarball does a bit more than just running\n> \"git archive-tar\", which is what gitweb download interface does\n> (namely, it adds the correct \"version\" file).\n\nThanks. I should have checked before responding. If it is just the\noutput of \"git archive\", and the problem is restricted to one version,\nthen I am not too worried about it. Re-tagging is out of the question,\nanyway.\n\n-Peff\n"},{"id":"194470","messageId":"CAPBPrnspD3uC6_wd7nqMUVgHSt4Frwy8UaYL6fU73kJKX6=XWQ@mail.gmail.com","threadId":"30819","inReplyTo":"7vvcis9ylx.fsf@alter.siamese.dyndns.org","subject":"Re: Incorrect v1.7.10.4 tag on github?","fromName":"Dan Johnson","fromEmail":"computerdruid@gmail.com","sentAt":"2012-07-02T19:52:31Z","receivedAt":"2012-07-02T19:52:31Z","isPatch":false,"sender":{"key":"computerdruid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/34696?v=4"},"body":"On Fri, Jun 15, 2012 at 3:14 PM, Junio C Hamano wrote:\n> Jeff King writes:\n>\n>> On Fri, Jun 15, 2012 at 09:51:00AM -0700, Graham Ballantyne wrote:\n>>\n>>> I just downloaded the 1.7.10.4 tag from github. After compiling and\n>>> installing, git --version returns \"git version 1.7.10.3\". I think that\n>>> tag might be pointing to the wrong commit?\n>>\n>> Looks like 121f71f (Git 1.7.10.4, 2012-06-03) forgot to update DEF_VAR\n>> in GIT-VERSION-GEN. Operator error from the maintainer?\n>\n> Thanks for noticing.\n>\n>> It builds with the right version from the git repository (which runs\n>> git-describe and sees we are on the v1.7.10.4 tag), but exporting the\n>> tag's contents and building fails. I suspect that the git-1.7.10.4\n>> tarball on kernel.org would also have the same problem.\n>\n> It builds correctly if you download the tarball from the official\n> location in the [ANNOUNCE] message. This is because the build\n> procedure for the official tarball does a bit more than just running\n> \"git archive-tar\", which is what gitweb download interface does\n> (namely, it adds the correct \"version\" file).\n\nJunio,\nI just noticed that the download buttons (for tarballs) on gitscm.com\nall point to the github tag list ( https://github.com/git/git/tags )\ninstead of the location pointed to by your [ANNOUNCE] message (\nhttp://code.google.com/p/git-core/downloads/list )\n\nIf you do something special as part of releasing these tarballs, is\nthis something that should be corrected? I can look at the source and\ndo a pull request for gitscm.com a little later, if needed.\n\n-- \n-Dan Johnson\n"},{"id":"194472","messageId":"20120702200815.GA3179@sigill.intra.peff.net","threadId":"30819","inReplyTo":"CAPBPrnspD3uC6_wd7nqMUVgHSt4Frwy8UaYL6fU73kJKX6=XWQ@mail.gmail.com","subject":"Re: Incorrect v1.7.10.4 tag on github?","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-07-02T20:08:15Z","receivedAt":"2012-07-02T20:08:15Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Jul 02, 2012 at 03:52:31PM -0400, Dan Johnson wrote:\n\n> > It builds correctly if you download the tarball from the official\n> > location in the [ANNOUNCE] message. This is because the build\n> > procedure for the official tarball does a bit more than just running\n> > \"git archive-tar\", which is what gitweb download interface does\n> > (namely, it adds the correct \"version\" file).\n> \n> I just noticed that the download buttons (for tarballs) on gitscm.com\n> all point to the github tag list ( https://github.com/git/git/tags )\n> instead of the location pointed to by your [ANNOUNCE] message (\n> http://code.google.com/p/git-core/downloads/list )\n\nIck. Yeah, I would think it would definitely want to point to Junio's\nbuilt tarballs, because they contain the built 'configure' script.\nOtherwise, the downloader would need to have autoconf installed if they\nwanted to use configure.\n\n> If you do something special as part of releasing these tarballs, is\n> this something that should be corrected? I can look at the source and\n> do a pull request for gitscm.com a little later, if needed.\n\nI suspect that the tarballs link on git-scm.com should at the very least\npoint to:\n\n http://code.google.com/p/git-core/downloads/list\n\nThat list is a little overwhelming because it contains the html and\nmanpage tarballs, too. It might make sense to provide a cut-down list\n(e.g., only source tarballs, and only the latest for each minor version,\nand omit -rc candidates for already-released versions). But that would\nbe a lot more involved.\n\n-Peff\n"},{"id":"194474","messageId":"7v7gulzxme.fsf@alter.siamese.dyndns.org","threadId":"30819","inReplyTo":"CAPBPrnspD3uC6_wd7nqMUVgHSt4Frwy8UaYL6fU73kJKX6=XWQ@mail.gmail.com","subject":"Re: Incorrect v1.7.10.4 tag on github?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-07-02T21:00:57Z","receivedAt":"2012-07-02T21:00:57Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Dan Johnson writes:\n\n> Junio,\n> I just noticed that the download buttons (for tarballs) on gitscm.com\n> all point to the github tag list ( https://github.com/git/git/tags )\n> instead of the location pointed to by your [ANNOUNCE] message (\n> http://code.google.com/p/git-core/downloads/list )\n\nThanks for noticing, but what GitHub does is outside my control.\nLuckily I see Peff is in the loop so this will hopefully be resolved\nshortly ;-).\n\n> If you do something special as part of releasing these tarballs, is\n> this something that should be corrected?\n\nI do not do anything special other than \"make dist\", but obviously\nanybody's \"list of tags\" that drive \"git archive\" won't run it, so\nit is a wrong thing to point at, regardless of who hosts it.\n"},{"id":"194476","messageId":"CAP2yMaLy3sBwybMH2LYs9Sg0AigZ-_tAx4SbHOrwr3T6GfLSaw@mail.gmail.com","threadId":"30819","inReplyTo":"7v7gulzxme.fsf@alter.siamese.dyndns.org","subject":"Re: Incorrect v1.7.10.4 tag on github?","fromName":"Scott Chacon","fromEmail":"schacon@gmail.com","sentAt":"2012-07-02T21:11:32Z","receivedAt":"2012-07-02T21:11:32Z","isPatch":false,"sender":{"key":"schacon@gmail.com","avatar":"https://gravatar.com/avatar/9b13a8a078e1dcf8588c4eea9554445d51ebed6c41b51f56f4d96738130b05c6?d=mp&s=160"},"body":"Hey,\n\nOn Mon, Jul 2, 2012 at 2:00 PM, Junio C Hamano wrote:\n>> I just noticed that the download buttons (for tarballs) on gitscm.com\n>> all point to the github tag list ( https://github.com/git/git/tags )\n>> instead of the location pointed to by your [ANNOUNCE] message (\n>> http://code.google.com/p/git-core/downloads/list )\n>\n>> If you do something special as part of releasing these tarballs, is\n>> this something that should be corrected?\n>\n> I do not do anything special other than \"make dist\", but obviously\n> anybody's \"list of tags\" that drive \"git archive\" won't run it, so\n> it is a wrong thing to point at, regardless of who hosts it.\n\nThanks for letting me know - I didn't realize that the built tarballs\nwere different from the tagged commit trees. I will update the links.\n\nScott\n"},{"id":"194479","messageId":"7vy5n1ygdj.fsf@alter.siamese.dyndns.org","threadId":"30819","inReplyTo":"CAP2yMaLy3sBwybMH2LYs9Sg0AigZ-_tAx4SbHOrwr3T6GfLSaw@mail.gmail.com","subject":"Re: Incorrect v1.7.10.4 tag on github?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-07-02T21:58:48Z","receivedAt":"2012-07-02T21:58:48Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Scott Chacon writes:\n\n> Thanks for letting me know - I didn't realize that the built tarballs\n> were different from the tagged commit trees. I will update the links.\n\nThanks.\n"}]}