{"thread":{"id":"30811","subject":"[PATCH] git-http-fetch: remove unused cmd_http_fetch","startedAt":"2012-06-14T20:23:37Z","lastAt":"2012-06-15T18:40:59Z","messageCount":5,"participants":["Luka Perkov","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"193672","messageId":"20120614202336.GA3755@w500.iskon.local","threadId":"30811","inReplyTo":null,"subject":"[PATCH] git-http-fetch: remove unused cmd_http_fetch","fromName":"Luka Perkov","fromEmail":"lists@lukaperkov.net","sentAt":"2012-06-14T20:23:37Z","receivedAt":"2012-06-14T20:23:37Z","isPatch":true,"sender":{"key":"lists@lukaperkov.net","avatar":null},"body":"It was left out from commit 1088261f6fc90324014b5306cca4171987da85ce\n\nSigned-off-by: Luka Perkov \n---\n\n builtin.h | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/builtin.h b/builtin.h\nindex 338f540..f5b8ed1 100644\n--- a/builtin.h\n+++ b/builtin.h\n@@ -83,7 +83,6 @@ extern int cmd_get_tar_commit_id(int argc, const char **argv, const char *prefix\n extern int cmd_grep(int argc, const char **argv, const char *prefix);\n extern int cmd_hash_object(int argc, const char **argv, const char *prefix);\n extern int cmd_help(int argc, const char **argv, const char *prefix);\n-extern int cmd_http_fetch(int argc, const char **argv, const char *prefix);\n extern int cmd_index_pack(int argc, const char **argv, const char *prefix);\n extern int cmd_init_db(int argc, const char **argv, const char *prefix);\n extern int cmd_log(int argc, const char **argv, const char *prefix);\n"},{"id":"193707","messageId":"20120615162136.GC4572@sigill.intra.peff.net","threadId":"30811","inReplyTo":"20120614202336.GA3755@w500.iskon.local","subject":"Re: [PATCH] git-http-fetch: remove unused cmd_http_fetch","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-06-15T16:21:36Z","receivedAt":"2012-06-15T16:21:36Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Jun 14, 2012 at 10:23:37PM +0200, Luka Perkov wrote:\n\n> It was left out from commit 1088261f6fc90324014b5306cca4171987da85ce\n\nThis commit message left me scratching my head. Did we get rid of\nhttp-fetch? If not, then don't we still need cmd_http_fetch? Or did we\njust make it not a builtin, in which case we wouldn't be getting rid of\ncmd_http_fetch, but rather converting it to main?\n\nReading the 1088261, I find the answer: we did make it not a builtin,\nand it was indeed converted into \"main\". But its _declaration_ hung\naround.\n\nSo maybe a better commit message would be:\n\n Subject: builtin.h: drop cmd_http_fetch declaration\n\n This was converted from a builtin into a stand-alone program by\n 1088261f6fc90324014b5306cca4171987da85ce, but that commit forgot to\n drop the declaration.\n\nOther than that, the patch looks obviously correct.\n\n-Peff\n\nPS There seem to be some other similar declarations: at least\n cmd_upload_tar and cmd_pickaxe.\n"},{"id":"193714","messageId":"7vaa04bg5q.fsf@alter.siamese.dyndns.org","threadId":"30811","inReplyTo":"20120615162136.GC4572@sigill.intra.peff.net","subject":"Re: [PATCH] git-http-fetch: remove unused cmd_http_fetch","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-06-15T18:09:53Z","receivedAt":"2012-06-15T18:09:53Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> PS There seem to be some other similar declarations: at least\n> cmd_upload_tar and cmd_pickaxe.\n\nThanks.\n\n$ sed -ne 's/^extern int \\(cmd_[^(]*\\)(.*/\\1/p' builtin.h | sort >/var/tmp/1\n$ nm -g git| sed -ne 's/^[0-9a-f]* T cmd_/cmd_/p' | sort > /var/tmp/2\n$ comm -3 /var/tmp/[12]\n\nfinds only the two you mentioned, so how about doing it this way?\n\n-- >8 --\nFrom: Luka Perkov \nDate: Thu, 14 Jun 2012 22:23:37 +0200\nSubject: [PATCH] builtin.h: remove unused cmd_ declarations\n\nThese were left in builtin.h after they were converted into\nstand-alone programs or removed after experiments finished.\n\nSigned-off-by: Luka Perkov \nHelped-by: Jeff King \nSigned-off-by: Junio C Hamano \n---\n builtin.h | 3 ---\n 1 file changed, 3 deletions(-)\n\ndiff --git a/builtin.h b/builtin.h\nindex 20427d2..3e44816 100644\n--- a/builtin.h\n+++ b/builtin.h\n@@ -58,7 +58,6 @@ extern int cmd_gc(int argc, const char **argv, const char *prefix);\n extern int cmd_get_tar_commit_id(int argc, const char **argv, const char *prefix);\n extern int cmd_grep(int argc, const char **argv, const char *prefix);\n extern int cmd_help(int argc, const char **argv, const char *prefix);\n-extern int cmd_http_fetch(int argc, const char **argv, const char *prefix);\n extern int cmd_init_db(int argc, const char **argv, const char *prefix);\n extern int cmd_log(int argc, const char **argv, const char *prefix);\n extern int cmd_log_reflog(int argc, const char **argv, const char *prefix);\n@@ -76,7 +75,6 @@ extern int cmd_mktree(int argc, const char **argv, const char *prefix);\n extern int cmd_mv(int argc, const char **argv, const char *prefix);\n extern int cmd_name_rev(int argc, const char **argv, const char *prefix);\n extern int cmd_pack_objects(int argc, const char **argv, const char *prefix);\n-extern int cmd_pickaxe(int argc, const char **argv, const char *prefix);\n extern int cmd_prune(int argc, const char **argv, const char *prefix);\n extern int cmd_prune_packed(int argc, const char **argv, const char *prefix);\n extern int cmd_push(int argc, const char **argv, const char *prefix);\n@@ -104,7 +102,6 @@ extern int cmd_unpack_objects(int argc, const char **argv, const char *prefix);\n extern int cmd_update_index(int argc, const char **argv, const char *prefix);\n extern int cmd_update_ref(int argc, const char **argv, const char *prefix);\n extern int cmd_upload_archive(int argc, const char **argv, const char *prefix);\n-extern int cmd_upload_tar(int argc, const char **argv, const char *prefix);\n extern int cmd_verify_tag(int argc, const char **argv, const char *prefix);\n extern int cmd_version(int argc, const char **argv, const char *prefix);\n extern int cmd_whatchanged(int argc, const char **argv, const char *prefix);\n-- \n1.7.11.rc3.30.g3bdace2\n"},{"id":"193717","messageId":"20120615181636.GA14843@sigill.intra.peff.net","threadId":"30811","inReplyTo":"7vaa04bg5q.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] git-http-fetch: remove unused cmd_http_fetch","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-06-15T18:16:36Z","receivedAt":"2012-06-15T18:16:36Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Jun 15, 2012 at 11:09:53AM -0700, Junio C Hamano wrote:\n\n> Jeff King writes:\n> \n> > PS There seem to be some other similar declarations: at least\n> > cmd_upload_tar and cmd_pickaxe.\n> \n> Thanks.\n> \n> $ sed -ne 's/^extern int \\(cmd_[^(]*\\)(.*/\\1/p' builtin.h | sort >/var/tmp/1\n> $ nm -g git| sed -ne 's/^[0-9a-f]* T cmd_/cmd_/p' | sort > /var/tmp/2\n> $ comm -3 /var/tmp/[12]\n> \n> finds only the two you mentioned, so how about doing it this way?\n\nI used a slightly grosser grep that looked in \"*.c\", and come up with\nonly those 2. Patch looks good to me.\n\n-Peff\n"},{"id":"193720","messageId":"20120615184059.GA27940@w500.iskon.local","threadId":"30811","inReplyTo":"20120615162136.GC4572@sigill.intra.peff.net","subject":"Re: [PATCH] git-http-fetch: remove unused cmd_http_fetch","fromName":"Luka Perkov","fromEmail":"lists@lukaperkov.net","sentAt":"2012-06-15T18:40:59Z","receivedAt":"2012-06-15T18:40:59Z","isPatch":true,"sender":{"key":"lists@lukaperkov.net","avatar":null},"body":"On Fri, Jun 15, 2012 at 12:21:36PM -0400, Jeff King wrote:\n> On Thu, Jun 14, 2012 at 10:23:37PM +0200, Luka Perkov wrote:\n> \n> > It was left out from commit 1088261f6fc90324014b5306cca4171987da85ce\n> \n> This commit message left me scratching my head. Did we get rid of\n> http-fetch? If not, then don't we still need cmd_http_fetch? Or did we\n> just make it not a builtin, in which case we wouldn't be getting rid of\n> cmd_http_fetch, but rather converting it to main?\n> \n> Reading the 1088261, I find the answer: we did make it not a builtin,\n> and it was indeed converted into \"main\". But its _declaration_ hung\n> around.\n> \n> So maybe a better commit message would be:\n> \n> Subject: builtin.h: drop cmd_http_fetch declaration\n> \n> This was converted from a builtin into a stand-alone program by\n> 1088261f6fc90324014b5306cca4171987da85ce, but that commit forgot to\n> drop the declaration.\n\nI agree. Sorry for the confusing message.\n\n> Other than that, the patch looks obviously correct.\n> \n> -Peff\n> \n> PS There seem to be some other similar declarations: at least\n> cmd_upload_tar and cmd_pickaxe.\n\nI noticed only cmd_http_fetch when I was hacking a patch for OpenWrt.\n\nLuka\n"}]}