{"thread":{"id":"30776","subject":"Cover letter for the last patch","startedAt":"2012-06-12T06:03:52Z","lastAt":"2012-06-12T06:03:52Z","messageCount":1,"participants":["jaseem abid"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"193416","messageId":"CAH-tXsCn+9t5dAq6ujNTvWL5Gz_Cw5nRLzwVjxw6-t8Hhwg4Aw@mail.gmail.com","threadId":"30776","inReplyTo":null,"subject":"Cover letter for the last patch","fromName":"jaseem abid","fromEmail":"jaseemabid@gmail.com","sentAt":"2012-06-12T06:03:52Z","receivedAt":"2012-06-12T06:03:52Z","isPatch":false,"sender":{"key":"jaseemabid@gmail.com","avatar":"https://gravatar.com/avatar/8b0432c96e4d3c8a9a96c9961ee842df7b7a869744da9c25187a51a992eabd81?d=mp&s=160"},"body":"Dear list,\n\nSorry,  I think i missed the cover letter for the last patch.\n\n[PATCH/RFC] gitweb: Adding jasmine test suite files for the browser\n\nJavaScript in gitweb is almost completely handwritten.\nIt is reimplementing things JavaScript library authors did a lot of times\nalready. Porting the current code to a library version was proposed as a gsoc\nproject this year. [ So I think I can skip why this patch is relevant]\n\nA common suggestion was to add tests to the new JavaScript code. Deciding the\ntesting framework took much more time than expected after several discussions.\nPeople wanted tests that could be run in console with TAP so that it will\nintegrate well with the existing system but since the code is ultimately going\nto be run in a browser, tests in the browser was more important.\n\nAfter a lot of discussions here and on #git-devel, I have used jasmine BDD\nframework, nodejs and jasmine TAP reporter to solve the issues. The specs are\nwritten for the browser and a makefile generates t/t9503-gitweb-javascript.js\nwhich can be run in a console to produce TAP output.\n\n\nThis patch series is for review only. If everyone is ok with the new testing\nframework, I will be able to send a patch with actual code in a week or 2. This\npatch series adds few sample tests to the existing code, and makes it run in a\nbrowser and console.\n\nI have added gitweb/test/README with instructions on the new test.\n\nPlease eyeball the changes to t/Makefile as I am not very sure if that is the\nbest way to do it.\n\nReviews most welcome.\n\n\n\n-- \nJaseem Abid\nhttp://jaseemabid.github.com\n"}]}