{"thread":{"id":"30671","subject":"[PATCH/RFC] Makefile: add missing GIT-VERSION-FILE dependency","startedAt":"2012-05-31T14:10:44Z","lastAt":"2012-05-31T19:42:11Z","messageCount":2,"participants":["Erik Faye-Lund","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"192580","messageId":"1338473444-8960-1-git-send-email-kusmabite@gmail.com","threadId":"30671","inReplyTo":null,"subject":"[PATCH/RFC] Makefile: add missing GIT-VERSION-FILE dependency","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2012-05-31T14:10:44Z","receivedAt":"2012-05-31T14:10:44Z","isPatch":true,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"In 20fc9bc (Set HTTP user agent to git/GIT_VERSION, 2006-04-04),\nhttp.o started recording GIT_VERSION, but http.o wasn't added\nto the list of files that depends on GIT-VERSION-FILE.\n\nFix this, so mofications to GIT-VERSION-FILE will result in an\nupdated user-agent string.\n\nSigned-off-by: Erik Faye-Lund <kusmabite@gmail.com>\n---\n\nI stumbled over this while debugging something related. Perhaps this\nfix is worth applying?\n\nThere's a similar issue with generation of assembly-listings, but I\nfigured that was intended for inspection of the generated code; the\nversion string probably doesn't matter in such cases.\n\nDunno...\n\n Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Makefile b/Makefile\nindex c09a679..59e2b25 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2104,7 +2104,7 @@ configure: configure.ac\n \t$(RM) $<+\n \n # These can record GIT_VERSION\n-git.o git.spec \\\n+git.o git.spec http.o \\\n \t$(patsubst %.sh,%,$(SCRIPT_SH)) \\\n \t$(patsubst %.perl,%,$(SCRIPT_PERL)) \\\n \t: GIT-VERSION-FILE\n-- \n1.7.11.rc0.6836.gdf573d9\n"},{"id":"192617","messageId":"7vy5o85e98.fsf@alter.siamese.dyndns.org","threadId":"30671","inReplyTo":"1338473444-8960-1-git-send-email-kusmabite@gmail.com","subject":"Re: [PATCH/RFC] Makefile: add missing GIT-VERSION-FILE dependency","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-05-31T19:42:11Z","receivedAt":"2012-05-31T19:42:11Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Erik Faye-Lund <kusmabite@gmail.com> writes:\n\n> In 20fc9bc (Set HTTP user agent to git/GIT_VERSION, 2006-04-04),\n> http.o started recording GIT_VERSION, but http.o wasn't added\n> to the list of files that depends on GIT-VERSION-FILE.\n> ...\n> diff --git a/Makefile b/Makefile\n> index c09a679..59e2b25 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -2104,7 +2104,7 @@ configure: configure.ac\n>  \t$(RM) $<+\n>  \n>  # These can record GIT_VERSION\n> -git.o git.spec \\\n> +git.o git.spec http.o \\\n>  \t$(patsubst %.sh,%,$(SCRIPT_SH)) \\\n>  \t$(patsubst %.perl,%,$(SCRIPT_PERL)) \\\n>  \t: GIT-VERSION-FILE\n\nMakes sense to me.  Thanks.\n"}]}