{"thread":{"id":"30507","subject":"[PATCH 3/3] http: rename HTTP_REAUTH to HTTP_AUTH_RETRY","startedAt":"2012-05-11T13:14:08Z","lastAt":"2012-05-11T13:14:08Z","messageCount":1,"participants":["Nelson Benitez Leon"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"191390","messageId":"4FAD10A0.6040306@seap.minhap.es","threadId":"30507","inReplyTo":null,"subject":"[PATCH 3/3] http: rename HTTP_REAUTH to HTTP_AUTH_RETRY","fromName":"Nelson Benitez Leon","fromEmail":"nelsonjesus.benitez@seap.minhap.es","sentAt":"2012-05-11T13:14:08Z","receivedAt":"2012-05-11T13:14:08Z","isPatch":true,"sender":{"key":"nelsonjesus.benitez@seap.minhap.es","avatar":null},"body":"The semantics of HTTP_REAUTH have been always more\nof a retry rather than a re-authentication, so we\nrename it to HTTP_AUTH_RETRY to make it more clear.\n\nSigned-off-by: Nelson Benitez Leon <nbenitezl@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n http.c |    6 +++---\n http.h |    2 +-\n 2 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/http.c b/http.c\nindex d34d741..0023119 100644\n--- a/http.c\n+++ b/http.c\n@@ -817,7 +817,7 @@ static int http_request(const char *url, void *result, int target, int options)\n \t\t\t} else {\n \t\t\t\tcredential_fill(&http_auth);\n \t\t\t\tinit_curl_http_auth(slot->curl);\n-\t\t\t\tret = HTTP_REAUTH;\n+\t\t\t\tret = HTTP_AUTH_RETRY;\n \t\t\t}\n \t\t} else if (results.http_code == 407) { /* Proxy authentication failure */\n \t\t\tif (proxy_auth.username && proxy_auth.password) {\n@@ -826,7 +826,7 @@ static int http_request(const char *url, void *result, int target, int options)\n \t\t\t} else {\n \t\t\t\tcredential_fill(&proxy_auth);\n \t\t\t\tset_proxy_auth(slot->curl);\n-\t\t\t\tret = HTTP_REAUTH;\n+\t\t\t\tret = HTTP_AUTH_RETRY;\n \t\t\t}\n \t\t} else {\n \t\t\tif (!curl_errorstr[0])\n@@ -856,7 +856,7 @@ static int http_request_reauth(const char *url, void *result, int target,\n \n \tdo {\n \t\tret = http_request(url, result, target, options);\n-\t} while (ret == HTTP_REAUTH);\n+\t} while (ret == HTTP_AUTH_RETRY);\n \n \treturn ret;\n }\ndiff --git a/http.h b/http.h\nindex 915c286..629bbcf 100644\n--- a/http.h\n+++ b/http.h\n@@ -123,7 +123,7 @@ extern char *get_remote_object_url(const char *url, const char *hex,\n #define HTTP_MISSING_TARGET\t1\n #define HTTP_ERROR\t\t2\n #define HTTP_START_FAILED\t3\n-#define HTTP_REAUTH\t4\n+#define HTTP_AUTH_RETRY\t4\n #define HTTP_NOAUTH\t5\n \n /*\n-- \n1.7.7.6\n"}]}