{"thread":{"id":"3048","subject":"[PATCH - maint review] describe: do not silently ignore indescribable commits","startedAt":"2006-01-12T00:05:05Z","lastAt":"2006-01-12T00:05:05Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"14515","messageId":"7vu0cajopa.fsf@assigned-by-dhcp.cox.net","threadId":"3048","inReplyTo":null,"subject":"[PATCH - maint review] describe: do not silently ignore indescribable commits","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-01-12T00:05:05Z","receivedAt":"2006-01-12T00:05:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"We silently ignored indescribable commits without complaining.\nComplain and die instead.\n\nSigned-off-by: Junio C Hamano <junkio@cox.net>\n\n---\n * For 1.1.2\n\n describe.c |    5 +++--\n 1 files changed, 3 insertions(+), 2 deletions(-)\n\n8c23b6fae2e5cd8475885b015f0bb992d19921db\ndiff --git a/describe.c b/describe.c\nindex a0180f5..5548a16 100644\n--- a/describe.c\n+++ b/describe.c\n@@ -124,10 +124,11 @@ static void describe(struct commit *cmit\n \t\tif (n) {\n \t\t\tprintf(\"%s-g%s\\n\", n->path,\n \t\t\t       find_unique_abbrev(cmit->object.sha1, abbrev));\n-\t\t\tbreak;\n+\t\t\tclear_commit_marks(cmit, SEEN);\n+\t\t\treturn;\n \t\t}\n \t}\n-\tclear_commit_marks(cmit, SEEN);\n+\tdie(\"cannot describe '%s'\", sha1_to_hex(cmit->object.sha1));\n }\n \n int main(int argc, char **argv)\n-- \n1.1.1-g8ecb\n"}]}