{"thread":{"id":"30452","subject":"git-p4: planned view wildcard support","startedAt":"2012-05-06T23:46:20Z","lastAt":"2012-05-07T15:28:33Z","messageCount":4,"participants":["Matthew Mendell","Pete Wyckoff"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"190949","messageId":"CAF0RQx-0M4iUHgGdH=RE_UFmLLZH8uy4kkMW=XspNzGm-vsyEg@mail.gmail.com","threadId":"30452","inReplyTo":null,"subject":"git-p4: planned view wildcard support","fromName":"Matthew Mendell","fromEmail":"matthew.mendell@gmail.com","sentAt":"2012-05-06T23:46:20Z","receivedAt":"2012-05-06T23:46:20Z","isPatch":false,"sender":{"key":"matthew.mendell@gmail.com","avatar":null},"body":"Hello,\n\nIs there any plan for the git-p4.py script to support the \"*\" wildcard\nin a p4 client?\n\nThe specific test that exposes this unsupported feature:\n./t9809-git-p4-client-view.sh\n...\nok 4 - unsupported view wildcard *\n\nThanks,\n-Matt\n"},{"id":"190985","messageId":"20120507104443.GA20372@padd.com","threadId":"30452","inReplyTo":"CAF0RQx-0M4iUHgGdH=RE_UFmLLZH8uy4kkMW=XspNzGm-vsyEg@mail.gmail.com","subject":"Re: git-p4: planned view wildcard support","fromName":"Pete Wyckoff","fromEmail":"pw@padd.com","sentAt":"2012-05-07T10:44:43Z","receivedAt":"2012-05-07T10:44:43Z","isPatch":false,"sender":{"key":"pw@padd.com","avatar":null},"body":"matthew.mendell@gmail.com wrote on Sun, 06 May 2012 16:46 -0700:\n> Is there any plan for the git-p4.py script to support the \"*\" wildcard\n> in a p4 client?\n> \n> The specific test that exposes this unsupported feature:\n> ./t9809-git-p4-client-view.sh\n> ...\n> ok 4 - unsupported view wildcard *\n\nIt hasn't been on anybody's priority list so far that I know, but\nthis would be not too hard to implement in theory.\n\nThe code changes would need to alter just one class.  In\nView.Path, functions Path.find_wildcards, match_wildcards and\nfill_in_wildcards, if you're interested in giving it a try.\n\nCan you constrain your use of \"*\" a bit?  What makes these\nwildcards difficult is all the edge cases.  For instance, is\nthere ever more than one \"*\"?  Is it combined with \"...\"?  Are\nthere multiple lines in the client spec with wildcards?  Some\nabstracted examples would be interesting.\n\n\t\t-- Pete\n"},{"id":"191003","messageId":"CAF0RQx_0EYGiTd36WMtjeBwJL1cxsGTe44=P+btEfWn+5Hq5yg@mail.gmail.com","threadId":"30452","inReplyTo":"20120507104443.GA20372@padd.com","subject":"Re: git-p4: planned view wildcard support","fromName":"Matthew Mendell","fromEmail":"matthew.mendell@gmail.com","sentAt":"2012-05-07T15:19:51Z","receivedAt":"2012-05-07T15:19:51Z","isPatch":false,"sender":{"key":"matthew.mendell@gmail.com","avatar":null},"body":"On Mon, May 7, 2012 at 3:44 AM, Pete Wyckoff <pw@padd.com> wrote:\n> matthew.mendell@gmail.com wrote on Sun, 06 May 2012 16:46 -0700:\n>> Is there any plan for the git-p4.py script to support the \"*\" wildcard\n>> in a p4 client?\n>>\n>> The specific test that exposes this unsupported feature:\n>> ./t9809-git-p4-client-view.sh\n>> ...\n>> ok 4 - unsupported view wildcard *\n>\n> It hasn't been on anybody's priority list so far that I know, but\n> this would be not too hard to implement in theory.\n>\n> The code changes would need to alter just one class.  In\n> View.Path, functions Path.find_wildcards, match_wildcards and\n> fill_in_wildcards, if you're interested in giving it a try.\n>\n> Can you constrain your use of \"*\" a bit?  What makes these\n> wildcards difficult is all the edge cases.  For instance, is\n> there ever more than one \"*\"?  Is it combined with \"...\"?  Are\n> there multiple lines in the client spec with wildcards?  Some\n> abstracted examples would be interesting.\n>\n>                -- Pete\n\nHi Pete,\n\nYeah, I have been perusing the code and would like to give it a shot.\nIs it ok to initially add partial support for the easy cases?\nMy usage of \"*\" is straight forward:\n\n//depot/project/* //my_clientspec/depot/project/*\n\nThanks,\n-Matt\n"},{"id":"191006","messageId":"20120507152833.GA30191@padd.com","threadId":"30452","inReplyTo":"CAF0RQx_0EYGiTd36WMtjeBwJL1cxsGTe44=P+btEfWn+5Hq5yg@mail.gmail.com","subject":"Re: git-p4: planned view wildcard support","fromName":"Pete Wyckoff","fromEmail":"pw@padd.com","sentAt":"2012-05-07T15:28:33Z","receivedAt":"2012-05-07T15:28:33Z","isPatch":false,"sender":{"key":"pw@padd.com","avatar":null},"body":"matthew.mendell@gmail.com wrote on Mon, 07 May 2012 08:19 -0700:\n> On Mon, May 7, 2012 at 3:44 AM, Pete Wyckoff <pw@padd.com> wrote:\n> > matthew.mendell@gmail.com wrote on Sun, 06 May 2012 16:46 -0700:\n> >> Is there any plan for the git-p4.py script to support the \"*\" wildcard\n> >> in a p4 client?\n> >>\n> >> The specific test that exposes this unsupported feature:\n> >> ./t9809-git-p4-client-view.sh\n> >> ...\n> >> ok 4 - unsupported view wildcard *\n> >\n> > It hasn't been on anybody's priority list so far that I know, but\n> > this would be not too hard to implement in theory.\n> >\n> > The code changes would need to alter just one class.  In\n> > View.Path, functions Path.find_wildcards, match_wildcards and\n> > fill_in_wildcards, if you're interested in giving it a try.\n> >\n> > Can you constrain your use of \"*\" a bit?  What makes these\n> > wildcards difficult is all the edge cases.  For instance, is\n> > there ever more than one \"*\"?  Is it combined with \"...\"?  Are\n> > there multiple lines in the client spec with wildcards?  Some\n> > abstracted examples would be interesting.\n> \n> Yeah, I have been perusing the code and would like to give it a shot.\n> Is it ok to initially add partial support for the easy cases?\n> My usage of \"*\" is straight forward:\n> \n> //depot/project/* //my_clientspec/depot/project/*\n\nThat one does seem like it wouldn't be too hard.  Similar to\ntrailing \"...\", but matching only one path component.\n\nAs long as git-p4 can reliably detect when it can deal\nwith a *, I think partial support would be just fine.\n\nI'll help think about test cases and such once you have\nsome code that's ready to look at.  Thanks!\n\n\t\t-- Pete\n"}]}