{"thread":{"id":"30332","subject":"[PATCH] git p4: fix unit tests","startedAt":"2012-04-25T08:16:53Z","lastAt":"2012-04-25T15:18:58Z","messageCount":3,"participants":["Luke Diamand","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"190047","messageId":"1335341814-1598-1-git-send-email-luke@diamand.org","threadId":"30332","inReplyTo":null,"subject":"[PATCHv1] git p4: fix for submit/edit unit test","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2012-04-25T08:16:53Z","receivedAt":"2012-04-25T08:16:53Z","isPatch":false,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"My P4EDITOR changes broke the submit/edit \"git p4\" unit test.\nThis fixes it.\n\nJunio - would you prefer me to resubmit the entire series?\n\nThanks\nLuke\n\n\nLuke Diamand (1):\n  git p4: fix unit tests\n\n t/t9805-git-p4-skip-submit-edit.sh |    2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n-- \n1.7.10.473.g0796\n"},{"id":"190046","messageId":"1335341814-1598-2-git-send-email-luke@diamand.org","threadId":"30332","inReplyTo":"1335341814-1598-1-git-send-email-luke@diamand.org","subject":"[PATCH] git p4: fix unit tests","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2012-04-25T08:16:54Z","receivedAt":"2012-04-25T08:16:54Z","isPatch":true,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"The submit-edit tests relied on P4EDITOR being unset. Set it\nexplicitly to an empty string.\n\nSigned-off-by: Luke Diamand <luke@diamand.org>\n---\n t/t9805-git-p4-skip-submit-edit.sh |    2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t9805-git-p4-skip-submit-edit.sh b/t/t9805-git-p4-skip-submit-edit.sh\nindex 4a72f79..353dcfb 100755\n--- a/t/t9805-git-p4-skip-submit-edit.sh\n+++ b/t/t9805-git-p4-skip-submit-edit.sh\n@@ -91,7 +91,7 @@ test_expect_success 'no config, edited' '\n \t\tcd \"$git\" &&\n \t\techo line >>file1 &&\n \t\tgit commit -a -m \"change 5\" &&\n-\t\tEDITOR=\"\\\"$ed\\\"\" git p4 submit &&\n+\t\tP4EDITOR=\"\" EDITOR=\"\\\"$ed\\\"\" git p4 submit &&\n \t\tp4 changes //depot/... >wc &&\n \t\ttest_line_count = 5 wc\n \t)\n-- \n1.7.10.473.g0796\n"},{"id":"190061","messageId":"xmqq4ns7et5p.fsf@junio.mtv.corp.google.com","threadId":"30332","inReplyTo":"1335341814-1598-1-git-send-email-luke@diamand.org","subject":"Re: [PATCHv1] git p4: fix for submit/edit unit test","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-04-25T15:18:58Z","receivedAt":"2012-04-25T15:18:58Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luke Diamand <luke@diamand.org> writes:\n\n> My P4EDITOR changes broke the submit/edit \"git p4\" unit test.\n> This fixes it.\n>\n> Junio - would you prefer me to resubmit the entire series?\n\nIt is too late for replacement, as the series is in 'next'.  Incremental\nupdates like you did is good.\n\nThanks.\n"}]}