{"thread":{"id":"30303","subject":"[PATCH] revert: add missing va_end","startedAt":"2012-04-21T21:15:19Z","lastAt":"2012-04-22T05:20:02Z","messageCount":2,"participants":["Christian Couder","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"189816","messageId":"20120421211520.2797.87418.chriscool@tuxfamily.org","threadId":"30303","inReplyTo":null,"subject":"[PATCH] revert: add missing va_end","fromName":"Christian Couder","fromEmail":"chriscool@tuxfamily.org","sentAt":"2012-04-21T21:15:19Z","receivedAt":"2012-04-21T21:15:19Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"\nSigned-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\n builtin/revert.c |    1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/builtin/revert.c b/builtin/revert.c\nindex e6840f2..e4ed023 100644\n--- a/builtin/revert.c\n+++ b/builtin/revert.c\n@@ -86,6 +86,7 @@ static void verify_opt_mutually_compatible(const char *me, ...)\n \t\t\t\tbreak;\n \t\t}\n \t}\n+\tva_end(ap);\n \n \tif (opt1 && opt2)\n \t\tdie(_(\"%s: %s cannot be used with %s\"),\tme, opt1, opt2);\n-- \n1.7.10.rc0.17.g74595\n"},{"id":"189829","messageId":"xmqqd370mjgd.fsf@junio.mtv.corp.google.com","threadId":"30303","inReplyTo":"20120421211520.2797.87418.chriscool@tuxfamily.org","subject":"Re: [PATCH] revert: add missing va_end","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-04-22T05:20:02Z","receivedAt":"2012-04-22T05:20:02Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Christian Couder <chriscool@tuxfamily.org> writes:\n\n> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>\n> ---\n>  builtin/revert.c |    1 +\n>  1 file changed, 1 insertion(+)\n>\n> diff --git a/builtin/revert.c b/builtin/revert.c\n> index e6840f2..e4ed023 100644\n> --- a/builtin/revert.c\n> +++ b/builtin/revert.c\n> @@ -86,6 +86,7 @@ static void verify_opt_mutually_compatible(const char *me, ...)\n>  \t\t\t\tbreak;\n>  \t\t}\n>  \t}\n> +\tva_end(ap);\n\nYeah, the original from v1.7.8-rc0~141^2~2 is obviously wrong.  Thanks.\n"}]}