{"thread":{"id":"30175","subject":"[PATCH] send-email: make annotate configurable","startedAt":"2012-04-07T00:29:09Z","lastAt":"2012-04-11T15:46:34Z","messageCount":7,"participants":["Felipe Contreras","Junio C Hamano","Matthieu Moy"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"188711","messageId":"1333758550-9187-1-git-send-email-felipe.contreras@gmail.com","threadId":"30175","inReplyTo":null,"subject":"[PATCH] send-email: make annotate configurable","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-04-07T00:29:09Z","receivedAt":"2012-04-07T00:29:09Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Some people always do --annotate, lets not force them to always type\nthat.\n\nSigned-off-by: Felipe Contreras \n---\n Documentation/config.txt | 1 +\n Documentation/git-send-email.txt | 5 +++--\n git-send-email.perl | 3 ++-\n 3 files changed, 6 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex c081657..90c9e1b 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -1828,6 +1828,7 @@ sendemail..*::\n \n sendemail.aliasesfile::\n sendemail.aliasfiletype::\n+sendemail.annotate::\n sendemail.bcc::\n sendemail.cc::\n sendemail.cccmd::\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 3241170..2106fea 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -45,8 +45,9 @@ Composing\n ~~~~~~~~~\n \n --annotate::\n-\tReview and edit each patch you're about to send. See the\n-\tCONFIGURATION section for 'sendemail.multiedit'.\n+\tReview and edit each patch you're about to send. Default is the value\n+\tof 'sendemail.annotate'. See the CONFIGURATION section for\n+\t'sendemail.multiedit'.\n \n --bcc=
::\n \tSpecify a \"Bcc:\" value for each email. Default is the value of\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex ef30c55..6ef2d34 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -210,7 +210,8 @@ my %config_bool_settings = (\n \"signedoffbycc\" => [\\$signed_off_by_cc, undef],\n \"signedoffcc\" => [\\$signed_off_by_cc, undef], # Deprecated\n \"validate\" => [\\$validate, 1],\n- \"multiedit\" => [\\$multiedit, undef]\n+ \"multiedit\" => [\\$multiedit, undef],\n+ \"annotate\" => [\\$annotate, undef]\n );\n \n my %config_settings = (\n-- \n1.7.10\n"},{"id":"188718","messageId":"7vy5q8xhkb.fsf@alter.siamese.dyndns.org","threadId":"30175","inReplyTo":"1333758550-9187-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH] send-email: make annotate configurable","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-04-07T05:00:04Z","receivedAt":"2012-04-07T05:00:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n> Some people always do --annotate, lets not force them to always type\n> that.\n\nThanks.\n\nAs long as there is --no-annotate to cancel a configured value for\none-shot invocation (I didn't check, but it should be added if there isn't\nalready one), I think this change makes sense (I admit that I do not use\nthe --annotate option myself, though).\n\nAre there any other bool-ish command line option that deserves to have\ncorresponding configuration variable? Is this the only one that is\nmissing the configuration counterpart?\n"},{"id":"188729","messageId":"vpqaa2n7rvd.fsf@bauges.imag.fr","threadId":"30175","inReplyTo":"7vy5q8xhkb.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] send-email: make annotate configurable","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2012-04-07T10:34:14Z","receivedAt":"2012-04-07T10:34:14Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Junio C Hamano writes:\n\n> Felipe Contreras writes:\n>\n>> Some people always do --annotate, lets not force them to always type\n>> that.\n>\n> Thanks.\n>\n> As long as there is --no-annotate to cancel a configured value for\n> one-shot invocation (I didn't check, but it should be added if there isn't\n> already one), I think this change makes sense (I admit that I do not use\n> the --annotate option myself, though).\n\nI almost always use --annotate, so this option definitely makes sense\nfor me (I usually call send-email through an alias that adds --annotate\nanyway).\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"},{"id":"188799","messageId":"7vwr5owzgz.fsf@alter.siamese.dyndns.org","threadId":"30175","inReplyTo":"vpqaa2n7rvd.fsf@bauges.imag.fr","subject":"Re: [PATCH] send-email: make annotate configurable","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-04-09T18:07:40Z","receivedAt":"2012-04-09T18:07:40Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Matthieu Moy writes:\n\n> Junio C Hamano writes:\n> ...\n>> As long as there is --no-annotate to cancel a configured value for\n>> one-shot invocation (I didn't check, but it should be added if there isn't\n>> already one), I think this change makes sense (I admit that I do not use\n>> the --annotate option myself, though).\n>\n> I almost always use --annotate, so this option definitely makes sense\n> for me (I usually call send-email through an alias that adds --annotate\n> anyway).\n\nI do not doubt the usefulness of it, but if there is no --no-annotate, it\nwould make the new variable unusable for those who would never run it\nwithout --annotate option; while you said \"almost always\", you didn't give\nus any useful information, so I had to check ;-) It turns out that\n\n $ git send-email --no-annotate writes:\n\n> I do not doubt the usefulness of it, but if there is no --no-annotate, it\n> would make the new variable unusable for those who would never run it\n> without --annotate option\n\nSorry; I meant to say \"for those who mostly but not always run it with\nthe --annotate option\".\n"},{"id":"188936","messageId":"vpqaa2i61ty.fsf@bauges.imag.fr","threadId":"30175","inReplyTo":"7vlim4vfk7.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] send-email: make annotate configurable","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2012-04-11T09:43:21Z","receivedAt":"2012-04-11T09:43:21Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Junio C Hamano writes:\n\n> Junio C Hamano writes:\n>\n>> I do not doubt the usefulness of it, but if there is no --no-annotate, it\n>> would make the new variable unusable for those who would never run it\n>> without --annotate option\n>\n> Sorry; I meant to say \"for those who mostly but not always run it with\n> the --annotate option\".\n\nActually, I guess you also meant \"and who sometimes use older versions\nof Git\", since the --no-annotate is there for people who always use the\nnew version.\n\nI don't think we can do anything for it. Any patch that introduces a new\ncommand-line option has the same issue. The only solution is on the user\nside: use only features that work for all versions of Git you use. In\nthis case, it means \"wait for all your machines to upgrade Git before\nsetting sendemail.annotate\".\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"},{"id":"188971","messageId":"7v62d6nued.fsf@alter.siamese.dyndns.org","threadId":"30175","inReplyTo":"vpqaa2i61ty.fsf@bauges.imag.fr","subject":"Re: [PATCH] send-email: make annotate configurable","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-04-11T15:46:34Z","receivedAt":"2012-04-11T15:46:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Matthieu Moy writes:\n\n> Junio C Hamano writes:\n>\n>> Junio C Hamano writes:\n>>\n>>> I do not doubt the usefulness of it, but if there is no --no-annotate, it\n>>> would make the new variable unusable for those who would never run it\n>>> without --annotate option\n>>\n>> Sorry; I meant to say \"for those who mostly but not always run it with\n>> the --annotate option\".\n>\n> Actually, I guess you also meant \"and who sometimes use older versions\n> of Git\", since the --no-annotate is there for people who always use the\n> new version.\n\nNot really. I didn't even have that in mind, and I agree with below.\n\n> I don't think we can do anything for it. Any patch that introduces a new\n> command-line option has the same issue. The only solution is on the user\n> side: use only features that work for all versions of Git you use. In\n> this case, it means \"wait for all your machines to upgrade Git before\n> setting sendemail.annotate\".\n\nAnd for that to work well, it is most sensible for the version that\nintroduces the configuration variable to make sure that the --no-annotate\ncommand line override also is there, as the override becomes even more\nnecessary because of the configuration variable.\n"}]}