{"thread":{"id":"30163","subject":"[PATCH RESEND] send-email: add 'specify-author' option","startedAt":"2012-04-06T12:21:13Z","lastAt":"2012-04-12T17:40:26Z","messageCount":14,"participants":["Felipe Contreras","Junio C Hamano","Thomas Rast","Michael Witten"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"188652","messageId":"1333714876-21895-1-git-send-email-felipe.contreras@gmail.com","threadId":"30163","inReplyTo":null,"subject":"[PATCH RESEND] send-email: add 'specify-author' option","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-04-06T12:21:13Z","receivedAt":"2012-04-06T12:21:13Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Some mail servers (Microsoft Exchange) mangle the 'From' header, so\nwhile applying the patches, the author has to be fixed manually.\n\nThis option allows to always specify the author of the commit in the\nbody of the message, even if the committer is the author.\n\nSigned-off-by: Felipe Contreras \n---\n Documentation/git-send-email.txt | 4 ++++\n git-send-email.perl | 9 +++++++--\n t/t9001-send-email.sh | 12 ++++++++++++\n 3 files changed, 23 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 3241170..9bd1379 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -126,6 +126,10 @@ The --to option must be repeated for each user you want on the to list.\n +\n Note that no attempts whatsoever are made to validate the encoding.\n \n+--specify-author::\n+\tAlways specify the author of the commit in the body of the message,\n+\teven if the committer is the author. This is useful if the 'From'\n+\theader is mangled by some mail server.\n \n Sending\n ~~~~~~~\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex ef30c55..f18ad16 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -57,6 +57,8 @@ git send-email [options] \n --annotate * Review each patch that will be sent in an editor.\n --compose * Open an editor for introduction.\n --8bit-encoding * Encoding to assume 8bit mails if undeclared\n+ --specify-author * Always specify the author of the commit in\n+\t\t\t the body of the message.\n \n Sending:\n --envelope-sender * Email envelope sender.\n@@ -198,6 +200,7 @@ my ($identity, $aliasfiletype, @alias_files, $smtp_domain);\n my ($validate, $confirm);\n my (@suppress_cc);\n my ($auto_8bit_encoding);\n+my ($specify_author);\n \n my ($debug_net_smtp) = 0;\t\t# Net::SMTP, see send_message()\n \n@@ -210,7 +213,8 @@ my %config_bool_settings = (\n \"signedoffbycc\" => [\\$signed_off_by_cc, undef],\n \"signedoffcc\" => [\\$signed_off_by_cc, undef], # Deprecated\n \"validate\" => [\\$validate, 1],\n- \"multiedit\" => [\\$multiedit, undef]\n+ \"multiedit\" => [\\$multiedit, undef],\n+ \"specifyauthor\" => [\\$specify_author, undef],\n );\n \n my %config_settings = (\n@@ -316,6 +320,7 @@ my $rc = GetOptions(\"h\" => \\$help,\n \t\t \"format-patch!\" => \\$format_patch,\n \t\t \"8bit-encoding=s\" => \\$auto_8bit_encoding,\n \t\t \"force\" => \\$force,\n+\t\t \"specify-author!\" => \\$specify_author,\n \t );\n \n usage() if $help;\n@@ -1310,7 +1315,7 @@ foreach my $t (@files) {\n \t\t$subject = quote_rfc2047($subject, $auto_8bit_encoding);\n \t}\n \n-\tif (defined $author and $author ne $sender) {\n+\tif (defined $author and ($author ne $sender or $specify_author)) {\n \t\t$message = \"From: $author\\n\\n$message\";\n \t\tif (defined $author_encoding) {\n \t\t\tif ($has_content_type) {\ndiff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\nindex 8c12c65..1dab17e 100755\n--- a/t/t9001-send-email.sh\n+++ b/t/t9001-send-email.sh\n@@ -281,6 +281,18 @@ test_expect_success $PREREQ 'Author From: not in message body' '\n \t! grep \"From: A \" msgbody1\n '\n \n+test_expect_success $PREREQ 'Author From: in message body (forced)' '\n+\tclean_fake_sendmail &&\n+\tgit send-email \\\n+\t\t--from=\"A \" \\\n+\t\t--to=nobody@example.com \\\n+\t\t--smtp-server=\"$(pwd)/fake.sendmail\" \\\n+\t\t--specify-author \\\n+\t\t$patches &&\n+\tsed \"1,/^\\$/d\" < msgtxt1 > msgbody1 &&\n+\tgrep \"From: A \" msgbody1\n+'\n+\n test_expect_success $PREREQ 'allow long lines with --no-validate' '\n \tgit send-email \\\n \t\t--from=\"Example \" \\\n-- \n1.7.9.6\n"},{"id":"188654","messageId":"CAMP44s0J5mzq+=WQ8KdYxXp2TNAYbA_X6qVVWgLg-=8rdOmEgg@mail.gmail.com","threadId":"30163","inReplyTo":"1333714876-21895-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH RESEND] send-email: add 'specify-author' option","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-04-06T12:32:55Z","receivedAt":"2012-04-06T12:32:55Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Fri, Apr 6, 2012 at 3:21 PM, Felipe Contreras\n wrote:\n> Some mail servers (Microsoft Exchange) mangle the 'From' header, so\n> while applying the patches, the author has to be fixed manually.\n>\n> This option allows to always specify the author of the commit in the\n> body of the message, even if the committer is the author.\n>\n> Signed-off-by: Felipe Contreras \n\nSome recipients don't exist any more; you might want to reply to this\nmessage instead.\n\nCheers.\n\n-- \nFelipe Contreras\n"},{"id":"188666","messageId":"7vobr4236g.fsf@alter.siamese.dyndns.org","threadId":"30163","inReplyTo":"1333714876-21895-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH RESEND] send-email: add 'specify-author' option","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-04-06T17:14:15Z","receivedAt":"2012-04-06T17:14:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n> Some mail servers (Microsoft Exchange) mangle the 'From' header, so\n> while applying the patches, the author has to be fixed manually.\n>\n> This option allows to always specify the author of the commit in the\n> body of the message, even if the committer is the author.\n>\n> Signed-off-by: Felipe Contreras \n> ---\n\nI wouldn't say that the existing option names to send-email are great, but\nI have to say that the one added by this is simply horrible ;-)\n\nThe first paragraph of the proposed commit log message states the problem\nit tries to address very clearly, which is good, but is \"From: \" the only\nthing that needs this? I am wondering if this should be named and behave\nmore like \"--duplicate-header\" or \"--in-body-header\".\n"},{"id":"188682","messageId":"CAMP44s1b=HfhPNkmiEjPnQpupd0FPBNgVyp5Sw=zFVTdqmJXEg@mail.gmail.com","threadId":"30163","inReplyTo":"7vobr4236g.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH RESEND] send-email: add 'specify-author' option","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-04-06T19:42:16Z","receivedAt":"2012-04-06T19:42:16Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Fri, Apr 6, 2012 at 8:14 PM, Junio C Hamano wrote:\n> Felipe Contreras writes:\n>\n>> Some mail servers (Microsoft Exchange) mangle the 'From' header, so\n>> while applying the patches, the author has to be fixed manually.\n>>\n>> This option allows to always specify the author of the commit in the\n>> body of the message, even if the committer is the author.\n>>\n>> Signed-off-by: Felipe Contreras \n>> ---\n>\n> I wouldn't say that the existing option names to send-email are great, but\n> I have to say that the one added by this is simply horrible ;-)\n>\n> The first paragraph of the proposed commit log message states the problem\n> it tries to address very clearly, which is good, but is \"From: \" the only\n> thing that needs this?  I am wondering if this should be named and behave\n> more like \"--duplicate-header\" or \"--in-body-header\".\n\nI have never seen any other 'in-body-header' other than From, and I\ndon't see how that would be useful. Anybody else?\n\n-- \nFelipe Contreras\n"},{"id":"188683","messageId":"87d37kr6a9.fsf@thomas.inf.ethz.ch","threadId":"30163","inReplyTo":"1333714876-21895-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH RESEND] send-email: add 'specify-author' option","fromName":"Thomas Rast","fromEmail":"trast@inf.ethz.ch","sentAt":"2012-04-06T19:47:58Z","receivedAt":"2012-04-06T19:47:58Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Felipe Contreras writes:\n\n> Some mail servers (Microsoft Exchange) mangle the 'From' header, so\n> while applying the patches, the author has to be fixed manually.\n>\n> This option allows to always specify the author of the commit in the\n> body of the message, even if the committer is the author.\n\nI imagine a user forced to send her email over such a broken server\nwould have this problem all the time. Wouldn't a config option be in\norder?\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"},{"id":"188686","messageId":"7vbon41ugg.fsf@alter.siamese.dyndns.org","threadId":"30163","inReplyTo":"CAMP44s1b=HfhPNkmiEjPnQpupd0FPBNgVyp5Sw=zFVTdqmJXEg@mail.gmail.com","subject":"Re: [PATCH RESEND] send-email: add 'specify-author' option","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-04-06T20:22:39Z","receivedAt":"2012-04-06T20:22:39Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n> On Fri, Apr 6, 2012 at 8:14 PM, Junio C Hamano wrote:\n>> Felipe Contreras writes:\n>>\n>>> Some mail servers (Microsoft Exchange) mangle the 'From' header, so\n>>> while applying the patches, the author has to be fixed manually.\n>> ...\n>> I wouldn't say that the existing option names to send-email are great, but\n>> I have to say that the one added by this is simply horrible ;-)\n>>\n>> The first paragraph of the proposed commit log message states the problem\n>> it tries to address very clearly, which is good, but is \"From: \" the only\n>> thing that needs this? I am wondering if this should be named and behave\n>> more like \"--duplicate-header\" or \"--in-body-header\".\n>\n> I have never seen any other 'in-body-header' other than From, and I\n> don't see how that would be useful. Anybody else?\n\nThe \"Subject:\" is very often used in the wild, when responding to an\nexisting discussion thread with a patch, without changing the topic of the\nthread (I would say it is used more than \"From: \" override).\n\nWhen using send-email to start a thread anew, this use case is much less\nof a problem, but I wouldn't be surprised if a broken MSA/MTA mangled the\nsubject (especially imagine a non-ASCII ones) incorrectly which would be\nhelped with exactly the same in-body-header mechanism.\n\nYou probably meant \"I do not want to hear from Junio\" by your last\nhalf-sentence, but I replied anyway ;-).\n"},{"id":"188693","messageId":"CAMP44s3rBSsMQfa4QPsGyfOi2uf6neY4aADFRCuJXhnFJV=2tQ@mail.gmail.com","threadId":"30163","inReplyTo":"87d37kr6a9.fsf@thomas.inf.ethz.ch","subject":"Re: [PATCH RESEND] send-email: add 'specify-author' option","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-04-06T21:30:04Z","receivedAt":"2012-04-06T21:30:04Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Fri, Apr 6, 2012 at 10:47 PM, Thomas Rast wrote:\n> Felipe Contreras writes:\n>\n>> Some mail servers (Microsoft Exchange) mangle the 'From' header, so\n>> while applying the patches, the author has to be fixed manually.\n>>\n>> This option allows to always specify the author of the commit in the\n>> body of the message, even if the committer is the author.\n>\n> I imagine a user forced to send her email over such a broken server\n> would have this problem all the time.  Wouldn't a config option be in\n> order?\n\nThere is a config option, but I guess I forgot to add the documentation.\n\nCheers.\n\n-- \nFelipe Contreras\n"},{"id":"188697","messageId":"CAMP44s1m2exUVRTzcBJrY8hnWxF+uEt58AQOP5vKiA3tfeRXRQ@mail.gmail.com","threadId":"30163","inReplyTo":"7vbon41ugg.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH RESEND] send-email: add 'specify-author' option","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-04-06T21:48:26Z","receivedAt":"2012-04-06T21:48:26Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Fri, Apr 6, 2012 at 11:22 PM, Junio C Hamano wrote:\n> Felipe Contreras writes:\n>\n>> On Fri, Apr 6, 2012 at 8:14 PM, Junio C Hamano wrote:\n>>> Felipe Contreras writes:\n>>>\n>>>> Some mail servers (Microsoft Exchange) mangle the 'From' header, so\n>>>> while applying the patches, the author has to be fixed manually.\n>>> ...\n>>> I wouldn't say that the existing option names to send-email are great, but\n>>> I have to say that the one added by this is simply horrible ;-)\n>>>\n>>> The first paragraph of the proposed commit log message states the problem\n>>> it tries to address very clearly, which is good, but is \"From: \" the only\n>>> thing that needs this?  I am wondering if this should be named and behave\n>>> more like \"--duplicate-header\" or \"--in-body-header\".\n>>\n>> I have never seen any other 'in-body-header' other than From, and I\n>> don't see how that would be useful. Anybody else?\n>\n> The \"Subject:\" is very often used in the wild, when responding to an\n> existing discussion thread with a patch, without changing the topic of the\n> thread (I would say it is used more than \"From: \" override).\n\nHmm, but that is different, isn't it?\n\nAFAIK people use this format:\n\n---\n$headers\n\nMessage\n\nPatch (format-patch output: headers, commit message, diff)\n---\n\nIn this case 'git am' would ignore the patch headers. The only way\n'git am' would override $headers, is if the first part of the body has\nnew headers:\n\n---\n$headers\n\n$patch_headers\n\n$patch_commit_message\n\n$patch_diff\n---\n\nIOW; if there's no message at the beginning of the body.\n\n> When using send-email to start a thread anew, this use case is much less\n> of a problem, but I wouldn't be surprised if a broken MSA/MTA mangled the\n> subject (especially imagine a non-ASCII ones) incorrectly which would be\n> helped with exactly the same in-body-header mechanism.\n\nI can't foresee that, but I guess we can do it anyway. So which would\nbe the fields to repeat? From, Date, and Subject?\n\n> You probably meant \"I do not want to hear from Junio\" by your last\n> half-sentence, but I replied anyway ;-).\n\nI meant I wanted to know which fields would be useful to put in the body.\n\nCheers.\n\n-- \nFelipe Contreras\n"},{"id":"188702","messageId":"7vobr4ze5z.fsf@alter.siamese.dyndns.org","threadId":"30163","inReplyTo":"CAMP44s1m2exUVRTzcBJrY8hnWxF+uEt58AQOP5vKiA3tfeRXRQ@mail.gmail.com","subject":"Re: [PATCH RESEND] send-email: add 'specify-author' option","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-04-06T22:30:32Z","receivedAt":"2012-04-06T22:30:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n>> The \"Subject:\" is very often used in the wild, when responding to an\n>> existing discussion thread with a patch, without changing the topic of the\n>> thread (I would say it is used more than \"From: \" override).\n>\n> Hmm, but that is different, isn't it?\n>\n> AFAIK people use this format:\n>\n> ---\n> $headers\n>\n> Message\n>\n> Patch (format-patch output: headers, commit message, diff)\n> ---\n>\n> In this case 'git am' would ignore the patch headers. The only way\n> 'git am' would override $headers, is if the first part of the body has\n> new headers:\n>\n> ---\n> $headers\n>\n> $patch_headers\n>\n> $patch_commit_message\n>\n> $patch_diff\n> ---\n>\n> IOW; if there's no message at the beginning of the body.\n\nYour notation is a bit unclear to me, but I take that $headers mean the\ne-mail headers, and $patch_headers mean what we often call \"in-body\"\nheaders; in other words, your patch is \"duplicate my authorship in\n$patch_headers because my MSA/MTA mangles my name in $headers.\" Am I\nfollowing you well so far?\n\nWhat I meant to say was that perhaps the approach can help the same class\nof issues where other fields in $headers can be corrupted and the user\nwants duplicate in \"in-body\", assuming that it is less likely to be eaten,\nand non-ASCII subject was one example that immediately came to my mind.\n\nSo in that sense, it is not much a different issue.\n\n> I can't foresee that, but I guess we can do it anyway. So which would\n> be the fields to repeat? From, Date, and Subject?\n\nI would say From and Subject are equally worth considering.\n"},{"id":"188730","messageId":"CAMP44s0D1RXteHvCrsmaKVcfaK4SRArXf_nF7by2jJkgatkG-A@mail.gmail.com","threadId":"30163","inReplyTo":"7vobr4ze5z.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH RESEND] send-email: add 'specify-author' option","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2012-04-07T11:46:29Z","receivedAt":"2012-04-07T11:46:29Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Sat, Apr 7, 2012 at 1:30 AM, Junio C Hamano wrote:\n> Felipe Contreras writes:\n>\n>>> The \"Subject:\" is very often used in the wild, when responding to an\n>>> existing discussion thread with a patch, without changing the topic of the\n>>> thread (I would say it is used more than \"From: \" override).\n>>\n>> Hmm, but that is different, isn't it?\n>>\n>> AFAIK people use this format:\n>>\n>> ---\n>> $headers\n>>\n>> Message\n>>\n>> Patch (format-patch output: headers, commit message, diff)\n>> ---\n>>\n>> In this case 'git am' would ignore the patch headers. The only way\n>> 'git am' would override $headers, is if the first part of the body has\n>> new headers:\n>>\n>> ---\n>> $headers\n>>\n>> $patch_headers\n>>\n>> $patch_commit_message\n>>\n>> $patch_diff\n>> ---\n>>\n>> IOW; if there's no message at the beginning of the body.\n>\n> Your notation is a bit unclear to me, but I take that $headers mean the\n> e-mail headers, and $patch_headers mean what we often call \"in-body\"\n> headers; in other words, your patch is \"duplicate my authorship in\n> $patch_headers because my MSA/MTA mangles my name in $headers.\"  Am I\n> following you well so far?\n\nYes, but 'git send-email' already does that; when the author and\nsender are not the same.\n\n> What I meant to say was that perhaps the approach can help the same class\n> of issues where other fields in $headers can be corrupted and the user\n> wants duplicate in \"in-body\", assuming that it is less likely to be eaten,\n> and non-ASCII subject was one example that immediately came to my mind.\n>\n> So in that sense, it is not much a different issue.\n\nNo, but it requires new code, whereas my patch only exercises existing code.\n\n>> I can't foresee that, but I guess we can do it anyway. So which would\n>> be the fields to repeat? From, Date, and Subject?\n>\n> I would say From and Subject are equally worth considering.\n\nSo only From and Subject? Not Date?\n\nCheers.\n\n-- \nFelipe Contreras\n"},{"id":"188758","messageId":"7vehryygpk.fsf@alter.siamese.dyndns.org","threadId":"30163","inReplyTo":"CAMP44s0D1RXteHvCrsmaKVcfaK4SRArXf_nF7by2jJkgatkG-A@mail.gmail.com","subject":"Re: [PATCH RESEND] send-email: add 'specify-author' option","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-04-08T04:45:27Z","receivedAt":"2012-04-08T04:45:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n> So only From and Subject? Not Date?\n\nI do not foresee MSA/MTA breaking a Date field; RFC2822 dates are\nASCII-only no?\n"},{"id":"189111","messageId":"fd7f09d9f7ad4ce2a32e850c0f21cc4c-mfwitten@gmail.com","threadId":"30163","inReplyTo":"CAMP44s1b=HfhPNkmiEjPnQpupd0FPBNgVyp5Sw=zFVTdqmJXEg@mail.gmail.com","subject":"Re: [PATCH RESEND] send-email: add 'specify-author' option","fromName":"Michael Witten","fromEmail":"mfwitten@gmail.com","sentAt":null,"receivedAt":"2012-04-12T15:36:12Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"On Fri, 6 Apr 2012 22:42:16 +0300, Felipe Contreras wrote:\n\n> On Fri, Apr 6, 2012 at 8:14 PM, Junio C Hamano wrote:\n>> Felipe Contreras writes:\n>>\n>>> Some mail servers (Microsoft Exchange) mangle the 'From' header, so\n>>> while applying the patches, the author has to be fixed manually.\n>>>\n>>> This option allows to always specify the author of the commit in the\n>>> body of the message, even if the committer is the author.\n>>>\n>>> Signed-off-by: Felipe Contreras \n>>> ---\n>>\n>> I wouldn't say that the existing option names to send-email are great, but\n>> I have to say that the one added by this is simply horrible ;-)\n>>\n>> The first paragraph of the proposed commit log message states the problem\n>> it tries to address very clearly, which is good, but is \"From: \" the only\n>> thing that needs this? I am wondering if this should be named and behave\n>> more like \"--duplicate-header\" or \"--in-body-header\".\n>\n> I have never seen any other 'in-body-header' other than From, and I\n> don't see how that would be useful. Anybody else?\n\nI sometimes like to set an explicit in-body `Date' header. However, Junio\nhas disagreed vocally about this practice:\n\n Subject: Dates in Commits and other issues of style\n (Re: [RFC 2/5] Pretty Print: show tz when using DATE_LOCAL)\n Message-ID: <811b01a9-f10e-4444-9e5e-581adaf059c2-mfwitten@gmail.com>\n http://article.gmane.org/gmane.comp.version-control.git/171936\n\nSincerely,\nMichael Witten\n"},{"id":"189115","messageId":"87520431c0b04cd4b78aac481d81002b-mfwitten@gmail.com","threadId":"30163","inReplyTo":"7vobr4ze5z.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH RESEND] send-email: add 'specify-author' option","fromName":"Michael Witten","fromEmail":"mfwitten@gmail.com","sentAt":null,"receivedAt":"2012-04-12T15:58:49Z","isPatch":true,"sender":{"key":"mfwitten@gmail.com","avatar":"https://avatars.githubusercontent.com/u/597101?v=4"},"body":"On Fri, 06 Apr 2012 15:30:32 -0700, Junio C Hamano wrote:\n\n> Felipe Contreras writes:\n>\n>> I can't foresee that, but I guess we can do it anyway. So which would\n>> be the fields to repeat? From, Date, and Subject?\n> \n> I would say From and Subject are equally worth considering.\n\nFamous last words: \"I can't foresee that.\"\n\nMy impression from Junio's initial comment:\n\n>>> The first paragraph of the proposed commit log message states the problem\n>>> it tries to address very clearly, which is good, but is \"From: \" the only\n>>> thing that needs this? I am wondering if this should be named and behave\n>>> more like \"--duplicate-header\" or \"--in-body-header\".\n\nis that a more general solution should be sought, particularly because we\nindeed can't foresee people's needs. I envisioned `--in-body-header' taking\nas an argument a colon-separated list of headers that should be inlined;\nlet the user mix and match as he pleases, and save us trouble in the\nfuture when new headers pop up (I can't forsee that happening, but, well,\nwho knows?).\n\nNaturally, a configuration variable could be useful.\n\nSincerely,\nMichael Witten\n"},{"id":"189122","messageId":"7vr4vs6e7p.fsf@alter.siamese.dyndns.org","threadId":"30163","inReplyTo":"fd7f09d9f7ad4ce2a32e850c0f21cc4c-mfwitten@gmail.com","subject":"Re: [PATCH RESEND] send-email: add 'specify-author' option","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-04-12T17:40:26Z","receivedAt":"2012-04-12T17:40:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Michael Witten writes:\n\n> I sometimes like to set an explicit in-body `Date' header. However, Junio\n> has disagreed vocally about this practice:\n>\n> Subject: Dates in Commits and other issues of style\n> (Re: [RFC 2/5] Pretty Print: show tz when using DATE_LOCAL)\n> Message-ID: <811b01a9-f10e-4444-9e5e-581adaf059c2-mfwitten@gmail.com>\n> http://article.gmane.org/gmane.comp.version-control.git/171936\n\nI do not want to see that used for patches meant for me to pick up from\nmbox; the reason is explained in the message the cited one is in response\nto.\n\nIt is an entirely different matter if such a \"feature\" should or should\nnot exist in the tool. I do not think I would use it myself, and as I\nsaid, I do not want anybody to use it when sending patches to this list,\nbut that does not mean Git should not support it.\n"}]}