{"thread":{"id":"3007","subject":"[PATCH] .gitignore git-describe","startedAt":"2006-01-08T14:15:46Z","lastAt":"2006-01-09T06:11:19Z","messageCount":8,"participants":["Andreas Ericsson","Timo Hirvonen","H. Peter Anvin","Linus Torvalds"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"14306","messageId":"20060108141457.8C4E85BE8F@nox.op5.se","threadId":"3007","inReplyTo":null,"subject":"[PATCH] .gitignore git-describe","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2006-01-08T14:15:46Z","receivedAt":"2006-01-08T14:15:46Z","isPatch":true,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"Signed-off-by: Andreas Ericsson <ae@op5.se>\n\n---\n\n .gitignore |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\n265df952d4c61f60eae42261aeea90e9b6d8e414\ndiff --git a/.gitignore b/.gitignore\nindex 1a9090b..4335061 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -23,6 +23,7 @@ git-count-objects\n git-cvsexportcommit\n git-cvsimport\n git-daemon\n+git-describe\n git-diff\n git-diff-files\n git-diff-index\n-- \n1.0.7-gb38d1\n"},{"id":"14307","messageId":"20060108164038.89e4439f.tihirvon@gmail.com","threadId":"3007","inReplyTo":"20060108141457.8C4E85BE8F@nox.op5.se","subject":"git-format-patch Date header","fromName":"Timo Hirvonen","fromEmail":"tihirvon@gmail.com","sentAt":"2006-01-08T14:40:38Z","receivedAt":"2006-01-08T14:40:38Z","isPatch":false,"sender":{"key":"tihirvon@gmail.com","avatar":null},"body":"\ngit-format-patch uses \"date '+%s %z'\" format for the Date header.\nSylpheed does not understand this format.  How common this convention\nis?  Should we change git-format-patch to use more standard date format?\n\nOTOH, I like the %s format because it is so simple and easy to parse :)\n\n-- \nhttp://onion.dynserv.net/~timo/\n"},{"id":"14308","messageId":"43C12DE9.8010906@op5.se","threadId":"3007","inReplyTo":"20060108164038.89e4439f.tihirvon@gmail.com","subject":"Re: git-format-patch Date header","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2006-01-08T15:21:13Z","receivedAt":"2006-01-08T15:21:13Z","isPatch":false,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"Timo Hirvonen wrote:\n> git-format-patch uses \"date '+%s %z'\" format for the Date header.\n> Sylpheed does not understand this format.  How common this convention\n> is?  Should we change git-format-patch to use more standard date format?\n> \n> OTOH, I like the %s format because it is so simple and easy to parse :)\n> \n\nActually, that's what's printed in the commit message, so any change \nwould have to be put there and that would break backwards compatibility \nfor new tools that might want to use it.\n\nOn an unrelated note, please don't start a new thread by replying to an \nold message. It's very confusing to follow and people may not see your \nmessage. This time it was doubly so because the next mail in my inbox is \na patch for git-format-patch, to which I thought you replied.\n\n-- \nAndreas Ericsson                   andreas.ericsson@op5.se\nOP5 AB                             www.op5.se\nTel: +46 8-230225                  Fax: +46 8-230231\n"},{"id":"14309","messageId":"20060108173736.199df297.tihirvon@gmail.com","threadId":"3007","inReplyTo":"43C12DE9.8010906@op5.se","subject":"Re: git-format-patch Date header","fromName":"Timo Hirvonen","fromEmail":"tihirvon@gmail.com","sentAt":"2006-01-08T15:37:36Z","receivedAt":"2006-01-08T15:37:36Z","isPatch":false,"sender":{"key":"tihirvon@gmail.com","avatar":null},"body":"On Sun, 08 Jan 2006 16:21:13 +0100\nAndreas Ericsson <ae@op5.se> wrote:\n\n> Timo Hirvonen wrote:\n> > git-format-patch uses \"date '+%s %z'\" format for the Date header.\n> > Sylpheed does not understand this format.  How common this convention\n> > is?  Should we change git-format-patch to use more standard date format?\n> > \n> > OTOH, I like the %s format because it is so simple and easy to parse :)\n> > \n> \n> Actually, that's what's printed in the commit message, so any change \n> would have to be put there and that would break backwards compatibility \n> for new tools that might want to use it.\n\nSo fixing Sylpheed (and maybe other email clients too) is the right\nsolution...\n\n> On an unrelated note, please don't start a new thread by replying to an \n> old message. It's very confusing to follow and people may not see your \n> message. This time it was doubly so because the next mail in my inbox is \n> a patch for git-format-patch, to which I thought you replied.\n\nSorry.  I replied to your message because it was the message having Date\nheader in the \"%s %z\" format.\n\n-- \nhttp://onion.dynserv.net/~timo/\n"},{"id":"14311","messageId":"43C13369.4090809@op5.se","threadId":"3007","inReplyTo":"20060108173736.199df297.tihirvon@gmail.com","subject":"Re: git-format-patch Date header","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2006-01-08T15:44:41Z","receivedAt":"2006-01-08T15:44:41Z","isPatch":false,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"Timo Hirvonen wrote:\n> On Sun, 08 Jan 2006 16:21:13 +0100\n> Andreas Ericsson <ae@op5.se> wrote:\n> \n> \n>>Timo Hirvonen wrote:\n>>\n>>>git-format-patch uses \"date '+%s %z'\" format for the Date header.\n>>>Sylpheed does not understand this format.  How common this convention\n>>>is?  Should we change git-format-patch to use more standard date format?\n>>>\n>>>OTOH, I like the %s format because it is so simple and easy to parse :)\n>>>\n>>\n>>Actually, that's what's printed in the commit message, so any change \n>>would have to be put there and that would break backwards compatibility \n>>for new tools that might want to use it.\n> \n> \n> So fixing Sylpheed (and maybe other email clients too) is the right\n> solution...\n> \n\nNopes. In this case fixing my home-hacked git-send-patch script is the \nright thing to do. git-format-patch has always printed that format, \nthough, so the error lies with me and the patch I sent. I shall have to \nre-visit it after reading rfc 822 a bit more closely.\n\n> \n>>On an unrelated note, please don't start a new thread by replying to an \n>>old message. It's very confusing to follow and people may not see your \n>>message. This time it was doubly so because the next mail in my inbox is \n>>a patch for git-format-patch, to which I thought you replied.\n> \n> \n> Sorry.  I replied to your message because it was the message having Date\n> header in the \"%s %z\" format.\n> \n\nI just noticed. Thanks, and sorry.\n\n-- \nAndreas Ericsson                   andreas.ericsson@op5.se\nOP5 AB                             www.op5.se\nTel: +46 8-230225                  Fax: +46 8-230231\n"},{"id":"14323","messageId":"43C18CC7.3050509@zytor.com","threadId":"3007","inReplyTo":"43C13369.4090809@op5.se","subject":"Re: git-format-patch Date header","fromName":"H. Peter Anvin","fromEmail":"hpa@zytor.com","sentAt":"2006-01-08T22:05:59Z","receivedAt":"2006-01-08T22:05:59Z","isPatch":false,"sender":{"key":"hpa@zytor.com","avatar":null},"body":"Andreas Ericsson wrote:\n> \n> Nopes. In this case fixing my home-hacked git-send-patch script is the \n> right thing to do. git-format-patch has always printed that format, \n> though, so the error lies with me and the patch I sent. I shall have to \n> re-visit it after reading rfc 822 a bit more closely.\n> \n\nRFC 2822, please.\n\n\t-hpa\n"},{"id":"14326","messageId":"43C1A08B.8080007@op5.se","threadId":"3007","inReplyTo":"43C18CC7.3050509@zytor.com","subject":"Re: git-format-patch Date header","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2006-01-08T23:30:19Z","receivedAt":"2006-01-08T23:30:19Z","isPatch":false,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"H. Peter Anvin wrote:\n> Andreas Ericsson wrote:\n> \n>>\n>> Nopes. In this case fixing my home-hacked git-send-patch script is the \n>> right thing to do. git-format-patch has always printed that format, \n>> though, so the error lies with me and the patch I sent. I shall have \n>> to re-visit it after reading rfc 822 a bit more closely.\n>>\n> \n> RFC 2822, please.\n> \n\nRight you are.\n\n-- \nAndreas Ericsson                   andreas.ericsson@op5.se\nOP5 AB                             www.op5.se\nTel: +46 8-230225                  Fax: +46 8-230231\n"},{"id":"14341","messageId":"Pine.LNX.4.64.0601082207510.3169@g5.osdl.org","threadId":"3007","inReplyTo":"43C12DE9.8010906@op5.se","subject":"Re: git-format-patch Date header","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2006-01-09T06:11:19Z","receivedAt":"2006-01-09T06:11:19Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Sun, 8 Jan 2006, Andreas Ericsson wrote:\n> \n> Actually, that's what's printed in the commit message, so any change \n> would have to be put there and that would break backwards compatibility \n> for new tools that might want to use it.\n\nNo, git should always take the date in any of a million different formats, \nand always turn it into \"seconds + timezone\" internally.\n\nThe fact that git-format-patch also prints it out in the internal format \nis unambiguous (nice) but human-unreadable (bad). \n\nThere are other unambiguous formats it could use, notably standard rfc2822 \nformat (\"date -R\").\n\nThe git \"show_date()\" function hopefully does exactly that rfc2822 format, \nbut you'd have to make a helper program to do the conversion in \ngit-format-patch.sh.\n\n\t\tLinus\n"}]}