{"thread":{"id":"30034","subject":"[PATCH] gitweb(1): Fixed improper use of \"it's\" when it should be \"its\"","startedAt":"2012-03-23T13:13:44Z","lastAt":"2012-03-23T18:19:48Z","messageCount":7,"participants":["David Waitzman","Ben Walton","D Waitzman","Thomas Rast","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"187568","messageId":"0316A9BA-627B-4B43-8BF1-392DD7408146@bbn.com","threadId":"30034","inReplyTo":null,"subject":"[PATCH] gitweb(1): Fixed improper use of \"it's\" when it should be \"its\"","fromName":"David Waitzman","fromEmail":"djw@bbn.com","sentAt":"2012-03-23T13:13:44Z","receivedAt":"2012-03-23T13:13:44Z","isPatch":true,"sender":{"key":"djw@bbn.com","avatar":null},"body":"This is a trivial patch to correct the english in the man page.\n\nSigned-off-by: David Waitzman \n\n---\n Documentation/gitweb.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt\nindex 605a085..065c54e 100644\n--- a/Documentation/gitweb.txt\n+++ b/Documentation/gitweb.txt\n@@ -14,7 +14,7 @@ gitweb.\n \n DESCRIPTION\n -----------\n-Gitweb provides a web interface to git repositories. It's features include:\n+Gitweb provides a web interface to git repositories. Its features include:\n \n * Viewing multiple Git repositories with common root.\n * Browsing every revision of the repository.\n@@ -60,7 +60,7 @@ to gitweb. The list of projects is generated by default by scanning the\n more exact; gitweb is not interested in a working area, and is best suited\n to showing \"bare\" repositories).\n \n-The name of repository in gitweb is path to it's `$GIT_DIR` (it's object\n+The name of repository in gitweb is path to its `$GIT_DIR` (its object\n database) relative to `$projectroot`. Therefore the repository $repo can be\n found at \"$projectroot/$repo\".\n \n-- \n1.7.9.GIT\n\n"},{"id":"187572","messageId":"1332509111-sup-2763@pinkfloyd.chass.utoronto.ca","threadId":"30034","inReplyTo":"0316A9BA-627B-4B43-8BF1-392DD7408146@bbn.com","subject":"Re: [PATCH] gitweb(1): Fixed improper use of \"it's\" when it should be \"its\"","fromName":"Ben Walton","fromEmail":"bwalton@artsci.utoronto.ca","sentAt":"2012-03-23T13:27:02Z","receivedAt":"2012-03-23T13:27:02Z","isPatch":true,"sender":{"key":"bdwalton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/396061?v=4"},"body":"Excerpts from David Waitzman's message of Fri Mar 23 09:13:44 -0400 2012:\n\nHi David,\n\n> This is a trivial patch to correct the english in the man page.\n\nGood catch!\n\n> -The name of repository in gitweb is path to it's `$GIT_DIR` (it's object\n> +The name of repository in gitweb is path to its `$GIT_DIR` (its object\n\n\nMight I suggest that this be:\n\n+The name of the repository in gitweb is the path to its `$GIT_DIR` (its object\n\nNote the inserted _the_'s.\n\nThanks\n-Ben\n--\nBen Walton\nSystems Programmer - CHASS\nUniversity of Toronto\nC:416.407.5610 | W:416.978.4302\n"},{"id":"187573","messageId":"53140318-34FA-4EF1-80F9-CFAD8828B3A1@bbn.com","threadId":"30034","inReplyTo":"1332509111-sup-2763@pinkfloyd.chass.utoronto.ca","subject":"[PATCH] gitweb(1) Fixed English issues","fromName":"David Waitzman","fromEmail":"djw@bbn.com","sentAt":"2012-03-23T14:49:55Z","receivedAt":"2012-03-23T14:49:55Z","isPatch":true,"sender":{"key":"djw@bbn.com","avatar":null},"body":"This is a trivial patch to correct the english in the man page. Ben Walton suggested an additional english fix which I have added and squashed with my change.\n\n-----\nFixed improper use of \"it's\" when it should be \"its\".\nAdded missing \"the\"; noted by Ben Walton bwalton@artsci.utoronto.ca\n\n Signed-off-by: David Waitzman \n---\n Documentation/gitweb.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt\nindex 605a085..59bdc3e 100644\n--- a/Documentation/gitweb.txt\n+++ b/Documentation/gitweb.txt\n@@ -14,7 +14,7 @@ gitweb.\n \n DESCRIPTION\n -----------\n-Gitweb provides a web interface to git repositories. It's features include:\n+Gitweb provides a web interface to git repositories. Its features include:\n \n * Viewing multiple Git repositories with common root.\n * Browsing every revision of the repository.\n@@ -60,7 +60,7 @@ to gitweb. The list of projects is generated by default by scanning the\n more exact; gitweb is not interested in a working area, and is best suited\n to showing \"bare\" repositories).\n \n-The name of repository in gitweb is path to it's `$GIT_DIR` (it's object\n+The name of repository in gitweb is the path to its `$GIT_DIR` (its object\n database) relative to `$projectroot`. Therefore the repository $repo can be\n found at \"$projectroot/$repo\".\n \n-- \n1.7.9.GIT\n\n"},{"id":"187574","messageId":"1332514314-sup-412@pinkfloyd.chass.utoronto.ca","threadId":"30034","inReplyTo":"53140318-34FA-4EF1-80F9-CFAD8828B3A1@bbn.com","subject":"Re: [PATCH] gitweb(1) Fixed English issues","fromName":"Ben Walton","fromEmail":"bwalton@artsci.utoronto.ca","sentAt":"2012-03-23T14:52:54Z","receivedAt":"2012-03-23T14:52:54Z","isPatch":true,"sender":{"key":"bdwalton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/396061?v=4"},"body":"Excerpts from David Waitzman's message of Fri Mar 23 10:49:55 -0400 2012:\n\nHi David,\n\n> +The name of repository in gitweb is the path to its `$GIT_DIR` (its object\n> database) relative to `$projectroot`. Therefore the repository $repo can be\n> found at \"$projectroot/$repo\".\n\nTwo _the_'s were missing in the original. This should read:\n\nThe name of _the_ repository in gitweb is _the_ path to its...\n\nThanks\n-Ben\n--\nBen Walton\nSystems Programmer - CHASS\nUniversity of Toronto\nC:416.407.5610 | W:416.978.4302\n"},{"id":"187575","messageId":"08B31D69-CE1F-4D27-8AE6-C1C0D76BEED5@spamcop.net","threadId":"30034","inReplyTo":"53140318-34FA-4EF1-80F9-CFAD8828B3A1@bbn.com","subject":"[PATCH] gitweb(1) Fixed English issues","fromName":"D Waitzman","fromEmail":"djw@spamcop.net","sentAt":"2012-03-23T15:02:43Z","receivedAt":"2012-03-23T15:02:43Z","isPatch":true,"sender":{"key":"djw@spamcop.net","avatar":null},"body":"This is a trivial patch to correct the english in the man page. Ben Walton suggested an additional english fix which I have added and squashed with my change. And then I added it again when he pointed out I missed something in his original email.\n\n--\n\nFixed improper use of \"it's\" when it should be \"its\".\nAdded missing \"the\"; noted by Ben Walton bwalton@artsci.utoronto.ca\n\n Signed-off-by: David Waitzman \n---\n Documentation/gitweb.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt\nindex 605a085..168e8bf 100644\n--- a/Documentation/gitweb.txt\n+++ b/Documentation/gitweb.txt\n@@ -14,7 +14,7 @@ gitweb.\n \n DESCRIPTION\n -----------\n-Gitweb provides a web interface to git repositories. It's features include:\n+Gitweb provides a web interface to git repositories. Its features include:\n \n * Viewing multiple Git repositories with common root.\n * Browsing every revision of the repository.\n@@ -60,7 +60,7 @@ to gitweb. The list of projects is generated by default by scanning the\n more exact; gitweb is not interested in a working area, and is best suited\n to showing \"bare\" repositories).\n \n-The name of repository in gitweb is path to it's `$GIT_DIR` (it's object\n+The name of the repository in gitweb is the path to its `$GIT_DIR` (its object\n database) relative to `$projectroot`. Therefore the repository $repo can be\n found at \"$projectroot/$repo\".\n \n-- \n1.7.9.GIT\n"},{"id":"187578","messageId":"878vircoby.fsf@thomas.inf.ethz.ch","threadId":"30034","inReplyTo":"08B31D69-CE1F-4D27-8AE6-C1C0D76BEED5@spamcop.net","subject":"Re: [PATCH] gitweb(1) Fixed English issues","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2012-03-23T15:46:25Z","receivedAt":"2012-03-23T15:46:25Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"D Waitzman writes:\n\n> This is a trivial patch to correct the english in the man page. Ben Walton suggested an additional english fix which I have added and squashed with my change. And then I added it again when he pointed out I missed something in his original email.\n>\n> --\n>\n> Fixed improper use of \"it's\" when it should be \"its\".\n> Added missing \"the\"; noted by Ben Walton bwalton@artsci.utoronto.ca\n>\n> Signed-off-by: David Waitzman \n> ---\n> Documentation/gitweb.txt | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt\n> index 605a085..168e8bf 100644\n[snip patch]\n\nNote that the correct way to put commentary in the patch mail that does\nnot go into the commit message is putting it after the --- marker.\nAlso, we write commit messages in the imperative. The above should\nprobably look roughly like\n\n Subject: Documentation/gitweb: trivial English fixes\n\n Change \"it's\" to \"its\" where a possessive is intended.\n\n Also add two missing \"the\" that were noticed by Ben Walton\n .\n\n Signed-off-by: David Waitzman \n ---\n This is a trivial patch to correct the english in the man page. Ben\n Walton suggested an additional english fix which I have added and\n squashed with my change. And then I added it again when he pointed\n out I missed something in his original email.\n\n Documentation/gitweb.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\n diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt\n index 605a085..168e8bf 100644\n\nNote that I added \"Subject:\" here to make it an inline patch (though you\nobviously need to remove my extra formatting indent). If there's no\nSubject pseudoheader, the patch gets the subject of your email, and\nsimilarly for From and author.\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"},{"id":"187594","messageId":"7vpqc3tc1n.fsf@alter.siamese.dyndns.org","threadId":"30034","inReplyTo":"878vircoby.fsf@thomas.inf.ethz.ch","subject":"Re: [PATCH] gitweb(1) Fixed English issues","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-03-23T18:19:48Z","receivedAt":"2012-03-23T18:19:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thomas Rast writes:\n\n> Note that the correct way to put commentary in the patch mail that does\n> not go into the commit message is putting it after the --- marker.\n> Also, we write commit messages in the imperative. The above should\n> probably look roughly like\n>\n> Subject: Documentation/gitweb: trivial English fixes\n>\n> Change \"it's\" to \"its\" where a possessive is intended.\n>\n> Also add two missing \"the\" that were noticed by Ben Walton\n> .\n>\n> Signed-off-by: David Waitzman \n> ---\n> This is a trivial patch to correct the english in the man page. Ben\n> Walton suggested an additional english fix which I have added and\n> squashed with my change. And then I added it again when he pointed\n> out I missed something in his original email.\n>\n> Documentation/gitweb.txt | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt\n> index 605a085..168e8bf 100644\n>\n> Note that I added \"Subject:\" here to make it an inline patch (though you\n> obviously need to remove my extra formatting indent). If there's no\n> Subject pseudoheader, the patch gets the subject of your email, and\n> similarly for From and author.\n\nThanks. I'll use this with the patch text you are responding to.\n"}]}