{"thread":{"id":"30032","subject":"[PATCH] documentation: fix alphabetic ordered list for git-rebase man page","startedAt":"2012-03-23T11:31:39Z","lastAt":"2012-03-27T10:40:52Z","messageCount":5,"participants":["Nelson Benitez Leon","Junio C Hamano","Andreas Ericsson"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"187564","messageId":"4F6C5F1B.6010603@seap.minhap.es","threadId":"30032","inReplyTo":null,"subject":"[PATCH] documentation: fix alphabetic ordered list for git-rebase man page","fromName":"Nelson Benitez Leon","fromEmail":"nelsonjesus.benitez@seap.minhap.es","sentAt":"2012-03-23T11:31:39Z","receivedAt":"2012-03-23T11:31:39Z","isPatch":true,"sender":{"key":"nelsonjesus.benitez@seap.minhap.es","avatar":null},"body":"An alphabetic ordered list (a.) is converted to numerical in\nthe man page (1.) so context comments naming 'a' were confusing,\nfix that by not using ordered list notation for 'a' anb 'b' items.\n---\nHi, \"Interactive mode\" section of git-rebase man page has an error,\nwhere the source says:\n a. regular use\n\n 1. finish something worthy of a commit\n\n 2. commit\n \nthe converted man page says: \n\n 1. regular use\n\n 1. finish something worthy of a commit\n\n 2. commit\n\nso the comments in following paragraph talking about \"b.2.\" and \"plenty of\na's and b's\" don't have any meaning. I've fixed it by not using ordered\nlist notation for the alphabetical list.\n\nHere you can see images of the man page before and after the patch:\n\nBefore patch: http://static.inky.ws/image/1567/image.jpg\n\nAfter patch: http://static.inky.ws/image/1568/image.jpg\n\nRegards,\n\n Documentation/git-rebase.txt | 7 +++++--\n 1 files changed, 5 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt\nindex 504945c..520aaa9 100644\n--- a/Documentation/git-rebase.txt\n+++ b/Documentation/git-rebase.txt\n@@ -409,10 +409,13 @@ The interactive mode is meant for this type of workflow:\n \n where point 2. consists of several instances of\n \n-a. regular use\n+a) regular use\n+\n 1. finish something worthy of a commit\n 2. commit\n-b. independent fixup\n+\n+b) independent fixup\n+\n 1. realize that something does not work\n 2. fix that\n 3. commit it\n-- \n1.7.7.6\n"},{"id":"187604","messageId":"7vd383t8vp.fsf@alter.siamese.dyndns.org","threadId":"30032","inReplyTo":"4F6C5F1B.6010603@seap.minhap.es","subject":"Re: [PATCH] documentation: fix alphabetic ordered list for git-rebase man page","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-03-23T19:28:10Z","receivedAt":"2012-03-23T19:28:10Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks; sign-off?\n"},{"id":"187715","messageId":"4F7059B7.8080406@op5.se","threadId":"30032","inReplyTo":"7vd383t8vp.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] documentation: fix alphabetic ordered list for git-rebase man page","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2012-03-26T11:57:43Z","receivedAt":"2012-03-26T11:57:43Z","isPatch":true,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"On 03/23/2012 08:28 PM, Junio C Hamano wrote:\n> Thanks; sign-off?\n\nHaving just checked up on this myself for a project I maintain and\nwas sent a patch without signoff (we shamelessly stole git.git's\nmeaning of signoffs), I have it on a copyright lawyer's word that\nyou can safely forge the sign-off for anything that provides a\nbugfix without adding a new way of doing things, since only changes\nthat carry a certain amount of originality can be copyright protected.\n\nFixing an alphabetic ordering is too trivial to grant the author of\nthe fix any right to the resulting work, as are typo-, grammar and\none-line syntactical fixes (adding missing braces, etc), and therefore\nthey do not need to sign off on the fact that they have a right to\ngive others the right to use that work, since they in fact do not have\nthe right to restrict others from using it in the first place.\n\nJust thought I'd throw that out there in case you, like I did, run into\nuseful patches you dare not use because the original author gets hard\nto contact all of a sudden.\n\n-- \nAndreas Ericsson andreas.ericsson@op5.se\nOP5 AB www.op5.se\nTel: +46 8-230225 Fax: +46 8-230231\n\nConsidering the successes of the wars on alcohol, poverty, drugs and\nterror, I think we should give some serious thought to declaring war\non peace.\n"},{"id":"187745","messageId":"7vwr67p8sw.fsf@alter.siamese.dyndns.org","threadId":"30032","inReplyTo":"4F7059B7.8080406@op5.se","subject":"Re: [PATCH] documentation: fix alphabetic ordered list for git-rebase man page","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-03-26T17:32:31Z","receivedAt":"2012-03-26T17:32:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Andreas Ericsson writes:\n\n> On 03/23/2012 08:28 PM, Junio C Hamano wrote:\n>> Thanks; sign-off?\n> ...\n> Just thought I'd throw that out there in case you, like I did, run into\n> useful patches you dare not use because the original author gets hard\n> to contact all of a sudden.\n\nThanks, but after seeing another series that is not as trivial as this one\nfrom the same author, I was hoping that Nelson will become a part of our\nregular contributor base ;-)\n\nAnd obviously it will be less work on me in the longer term if I train the\nregular contributors to do S-o-b themselves earlier in the process.\n"},{"id":"187842","messageId":"4F719934.1050500@seap.minhap.es","threadId":"30032","inReplyTo":"7vwr67p8sw.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] documentation: fix alphabetic ordered list for git-rebase man page","fromName":"Nelson Benitez Leon","fromEmail":"nelsonjesus.benitez@seap.minhap.es","sentAt":"2012-03-27T10:40:52Z","receivedAt":"2012-03-27T10:40:52Z","isPatch":true,"sender":{"key":"nelsonjesus.benitez@seap.minhap.es","avatar":null},"body":"An alphabetic ordered list (a.) is converted to numerical in\nthe man page (1.) so context comments naming 'a' were confusing,\nfix that by not using ordered list notation for 'a' anb 'b' items.\n\nSigned-off-by: Nelson Benitez Leon \n---\nSorry for the delay and forgetting the sign-off, should have made\nan alias for that, hope to keep contributing as I found things that\nneed to be improved. thanks!\n\n Documentation/git-rebase.txt | 7 +++++--\n 1 files changed, 5 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt\nindex 504945c..520aaa9 100644\n--- a/Documentation/git-rebase.txt\n+++ b/Documentation/git-rebase.txt\n@@ -409,10 +409,13 @@ The interactive mode is meant for this type of workflow:\n \n where point 2. consists of several instances of\n \n-a. regular use\n+a) regular use\n+\n 1. finish something worthy of a commit\n 2. commit\n-b. independent fixup\n+\n+b) independent fixup\n+\n 1. realize that something does not work\n 2. fix that\n 3. commit it\n-- \n1.7.7.6\n"}]}