{"thread":{"id":"29980","subject":"[PATCH] git-gui: Do not select Revert Changes by default","startedAt":"2012-03-17T15:12:55Z","lastAt":"2012-03-17T20:07:59Z","messageCount":3,"participants":["Matthew L Daniel","Johannes Sixt","Matthew Daniel"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"187158","messageId":"loom.20120317T161127-418@post.gmane.org","threadId":"29980","inReplyTo":null,"subject":"[PATCH] git-gui: Do not select Revert Changes by default","fromName":"Matthew L Daniel","fromEmail":"mdaniel@gmail.com","sentAt":"2012-03-17T15:12:55Z","receivedAt":"2012-03-17T15:12:55Z","isPatch":true,"sender":{"key":"mdaniel@gmail.com","avatar":"https://gravatar.com/avatar/0a9033d5df2e8bf6bf26b1a5c57cbd5fcc467311a673a7e8945f90acc3b620df?d=mp&s=160"},"body":"Currently, if one activates the revert changes dialog,\nit has the destructive button selected as the default.\n\nThis change moves the default action to \"do nothing\".\n---\n git-gui/lib/index.tcl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-gui/lib/index.tcl b/git-gui/lib/index.tcl\nindex 8efbbdd..252aa33 100644\n--- a/git-gui/lib/index.tcl\n+++ b/git-gui/lib/index.tcl\n@@ -437,7 +437,7 @@ proc revert_helper {txt paths} {\n \n [mc \"Any unstaged changes will be permanently lost by the revert.\"]\" \\\n \t\tquestion \\\n-\t\t1 \\\n+\t\t0 \\\n \t\t[mc \"Do Nothing\"] \\\n \t\t[mc \"Revert Changes\"] \\\n \t\t]\n-- \n1.7.9.msysgit.0\n"},{"id":"187175","messageId":"4F64EDCD.1000405@kdbg.org","threadId":"29980","inReplyTo":"loom.20120317T161127-418@post.gmane.org","subject":"Re: [PATCH] git-gui: Do not select Revert Changes by default","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2012-03-17T20:02:21Z","receivedAt":"2012-03-17T20:02:21Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 17.03.2012 16:12, schrieb Matthew L Daniel:\n> Currently, if one activates the revert changes dialog,\n> it has the destructive button selected as the default.\n> \n> This change moves the default action to \"do nothing\".\n> ---\n>  git-gui/lib/index.tcl |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/git-gui/lib/index.tcl b/git-gui/lib/index.tcl\n> index 8efbbdd..252aa33 100644\n> --- a/git-gui/lib/index.tcl\n> +++ b/git-gui/lib/index.tcl\n> @@ -437,7 +437,7 @@ proc revert_helper {txt paths} {\n>  \n>  [mc \"Any unstaged changes will be permanently lost by the revert.\"]\" \\\n>  \t\tquestion \\\n> -\t\t1 \\\n> +\t\t0 \\\n>  \t\t[mc \"Do Nothing\"] \\\n>  \t\t[mc \"Revert Changes\"] \\\n>  \t\t]\n\nGah! Please no!\n\nThe destructive action is that you chose Branch->Revert. The dialog is\nthe \"Are you sure?\" question. Your change is the equivalent of an \"Are\nyou sure that you are sure?\" question. It does not make a lot of\ndifference for point-and-click people, but you force another keypress on\npeople who operate git-gui with the keyboard.\n\n-- Hannes\n"},{"id":"187176","messageId":"CAHtgEPuLjijzcMiAC3QerATyyCAh912tam-KrYgwihe-RQd4JQ@mail.gmail.com","threadId":"29980","inReplyTo":"4F64EDCD.1000405@kdbg.org","subject":"Re: [PATCH] git-gui: Do not select Revert Changes by default","fromName":"Matthew Daniel","fromEmail":"mdaniel@gmail.com","sentAt":"2012-03-17T20:07:59Z","receivedAt":"2012-03-17T20:07:59Z","isPatch":true,"sender":{"key":"mdaniel@gmail.com","avatar":"https://gravatar.com/avatar/0a9033d5df2e8bf6bf26b1a5c57cbd5fcc467311a673a7e8945f90acc3b620df?d=mp&s=160"},"body":"Okay, I thought perhaps it was a usability oversight. If it is that\nway on purpose, then feel free to not apply the patch.\n\n  -- /v\\atthew\n\nOn Sat, Mar 17, 2012 at 9:02 PM, Johannes Sixt <j6t@kdbg.org> wrote:\n> Am 17.03.2012 16:12, schrieb Matthew L Daniel:\n>> Currently, if one activates the revert changes dialog,\n>> it has the destructive button selected as the default.\n>>\n>> This change moves the default action to \"do nothing\".\n>> ---\n>>  git-gui/lib/index.tcl |    2 +-\n>>  1 files changed, 1 insertions(+), 1 deletions(-)\n>>\n>> diff --git a/git-gui/lib/index.tcl b/git-gui/lib/index.tcl\n>> index 8efbbdd..252aa33 100644\n>> --- a/git-gui/lib/index.tcl\n>> +++ b/git-gui/lib/index.tcl\n>> @@ -437,7 +437,7 @@ proc revert_helper {txt paths} {\n>>\n>>  [mc \"Any unstaged changes will be permanently lost by the revert.\"]\" \\\n>>               question \\\n>> -             1 \\\n>> +             0 \\\n>>               [mc \"Do Nothing\"] \\\n>>               [mc \"Revert Changes\"] \\\n>>               ]\n>\n> Gah! Please no!\n>\n> The destructive action is that you chose Branch->Revert. The dialog is\n> the \"Are you sure?\" question. Your change is the equivalent of an \"Are\n> you sure that you are sure?\" question. It does not make a lot of\n> difference for point-and-click people, but you force another keypress on\n> people who operate git-gui with the keyboard.\n>\n> -- Hannes\n"}]}