{"thread":{"id":"29886","subject":"[PATCH resend] gitk: Skip over AUTHOR/COMMIT_DATE when searching all fields","startedAt":"2012-03-08T12:35:50Z","lastAt":"2012-03-18T23:24:36Z","messageCount":2,"participants":["Jonathan Nieder","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"186433","messageId":"20120308123539.GA5862@burratino","threadId":"29886","inReplyTo":null,"subject":"[PATCH resend] gitk: Skip over AUTHOR/COMMIT_DATE when searching all fields","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2012-03-08T12:35:50Z","receivedAt":"2012-03-08T12:35:50Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"From: Frédéric Brière <fbriere@fbriere.net>\nDate: Sun, 14 Mar 2010 18:59:09 -0400\n\nThis prevents a search for a number like \"105\" on \"All Fields\" from\nmatching against the raw author and commit timestamps.  These\ntimestamps were already not searchable by themselves, and the\ndisplayed format does not match the query string anyway.\n\nSigned-off-by: Frédéric Brière <fbriere@fbriere.net>\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n---\nLast seen at [1].  Since then, the commit message was tweaked for\nclarity but not other changes.\n\n[1] http://thread.gmane.org/gmane.comp.version-control.git/142160\n\n gitk-git/gitk |    6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex 6981cb20..17ba10a8 100755\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -4630,8 +4630,9 @@ proc askfindhighlight {row id} {\n     }\n     set info $commitinfo($id)\n     set isbold 0\n-    set fldtypes [list [mc Headline] [mc Author] [mc Date] [mc Committer] [mc CDate] [mc Comments]]\n+    set fldtypes [list [mc Headline] [mc Author] \"\" [mc Committer] \"\" [mc Comments]]\n     foreach f $info ty $fldtypes {\n+\tif {$ty eq \"\"} continue\n \tif {($findloc eq [mc \"All fields\"] || $findloc eq $ty) &&\n \t    [doesmatch $f]} {\n \t    if {$ty eq [mc \"Author\"]} {\n@@ -6492,7 +6493,7 @@ proc findmore {} {\n     if {![info exists find_dirn]} {\n \treturn 0\n     }\n-    set fldtypes [list [mc \"Headline\"] [mc \"Author\"] [mc \"Date\"] [mc \"Committer\"] [mc \"CDate\"] [mc \"Comments\"]]\n+    set fldtypes [list [mc \"Headline\"] [mc \"Author\"] \"\" [mc \"Committer\"] \"\" [mc \"Comments\"]]\n     set l $findcurline\n     set moretodo 0\n     if {$find_dirn > 0} {\n@@ -6553,6 +6554,7 @@ proc findmore {} {\n \t    }\n \t    set info $commitinfo($id)\n \t    foreach f $info ty $fldtypes {\n+\t\tif {$ty eq \"\"} continue\n \t\tif {($findloc eq [mc \"All fields\"] || $findloc eq $ty) &&\n \t\t    [doesmatch $f]} {\n \t\t    set found 1\n-- \n1.7.9.2\n"},{"id":"187224","messageId":"20120318232436.GF26977@bloggs.ozlabs.ibm.com","threadId":"29886","inReplyTo":"20120308123539.GA5862@burratino","subject":"Re: [PATCH resend] gitk: Skip over AUTHOR/COMMIT_DATE when searching all fields","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2012-03-18T23:24:36Z","receivedAt":"2012-03-18T23:24:36Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"On Thu, Mar 08, 2012 at 06:35:50AM -0600, Jonathan Nieder wrote:\n> From: Frédéric Brière <fbriere@fbriere.net>\n> Date: Sun, 14 Mar 2010 18:59:09 -0400\n> \n> This prevents a search for a number like \"105\" on \"All Fields\" from\n> matching against the raw author and commit timestamps.  These\n> timestamps were already not searchable by themselves, and the\n> displayed format does not match the query string anyway.\n> \n> Signed-off-by: Frédéric Brière <fbriere@fbriere.net>\n> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>\n\nThanks, applied.\n\nPaul.\n"}]}