{"thread":{"id":"29863","subject":"[PATCH V2] t0204: Removed TC emitting ISO-8859-1 from our UTF-8 *.mo files","startedAt":"2012-03-06T20:39:10Z","lastAt":"2012-03-06T20:39:10Z","messageCount":1,"participants":["Torsten Bögershausen"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"186251","messageId":"201203062139.10812.tboegi@web.de","threadId":"29863","inReplyTo":null,"subject":"[PATCH V2] t0204: Removed TC emitting ISO-8859-1 from our UTF-8 *.mo files","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2012-03-06T20:39:10Z","receivedAt":"2012-03-06T20:39:10Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"Removed this test case:\ngettext: Emitting ISO-8859-1 from our UTF-8 *.mo files / Runes\n\nThe removed test case tried to show UTF-8 encoded text in a ISO-8859-1\nlocale with code points that don't fit into ISO-8859-1.\nSome systems convert these code points into question marks,\n(that is what the test expects) while other don't support\nan ISO-8859-1 locale anymore and use UTF-8 anyway.\n\nRemove the text case as there is no reason to insist that the fall back\nbehaviour is to convert code points out of range into question marks.\n\nSigned-off-by: Torsten Bögershausen <tboegi@web.de>\n---\n>This is insane. \n[snip]\n>I do not see any reason to insist that their fallback behaviour must\n>be to fill them with question marks.  In other words, I simply do\n>not see the point of this test and the original \"pass runs of\n>question\" to begin with, and this patch makes things even worse.\n\n>Why not get rid of this single test that only tries to check the\n>output for an impossible request?\n>Ævar, am I missing something?\nI don't think so.\n\nBetter a good remove than a bad improve\n\nJunio, thanks for the replay, \nI tried to convert your comments into a commit message.\n\n\n\n t/t0204-gettext-reencode-sanity.sh |   14 --------------\n 1 files changed, 0 insertions(+), 14 deletions(-)\n\ndiff --git a/t/t0204-gettext-reencode-sanity.sh b/t/t0204-gettext-reencode-sanity.sh\nindex 189af90..b0628a1 100755\n--- a/t/t0204-gettext-reencode-sanity.sh\n+++ b/t/t0204-gettext-reencode-sanity.sh\n@@ -26,20 +26,6 @@ test_expect_success GETTEXT_ISO_LOCALE 'gettext: Emitting ISO-8859-1 from our UT\n     test_cmp expect actual\n '\n \n-test_expect_success GETTEXT_ISO_LOCALE 'gettext: Emitting ISO-8859-1 from our UTF-8 *.mo files / Runes' '\n-    LANGUAGE=is LC_ALL=\"$is_IS_iso_locale\" gettext \"TEST: Old English Runes\" >runes &&\n-\n-\tif grep \"^TEST: Old English Runes$\" runes\n-\tthen\n-\t\tsay \"Your system can not handle this complexity and returns the string as-is\"\n-\telse\n-\t\t# Both Solaris and GNU libintl will return this stream of\n-\t\t# question marks, so it is s probably portable enough\n-\t\tprintf \"TILRAUN: ?? ???? ??? ?? ???? ?? ??? ????? ??????????? ??? ?? ????\" >runes-expect &&\n-\t\ttest_cmp runes-expect runes\n-\tfi\n-'\n-\n test_expect_success GETTEXT_LOCALE 'gettext: Fetching a UTF-8 msgid -> UTF-8' '\n     printf \"TILRAUN: ‚einfaldar‘ og „tvöfaldar“ gæsalappir\" >expect &&\n     LANGUAGE=is LC_ALL=\"$is_IS_locale\" gettext \"TEST: ‘single’ and “double” quotes\" >actual &&\n-- \n1.7.9.rc2\n"}]}