{"thread":{"id":"29846","subject":"[ANNOUNCE] Git 1.7.9.3","startedAt":"2012-03-05T23:24:56Z","lastAt":"2012-03-06T20:31:20Z","messageCount":6,"participants":["Junio C Hamano","BJ Hargrave","Thomas Rast"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"186154","messageId":"7vliney6k7.fsf@alter.siamese.dyndns.org","threadId":"29846","inReplyTo":null,"subject":"[ANNOUNCE] Git 1.7.9.3","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-03-05T23:24:56Z","receivedAt":"2012-03-05T23:24:56Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"The latest maintenance release Git 1.7.9.3 is now available at the\nusual places. Time to upgrade.\n\nThe release tarballs are found at:\n\n http://code.google.com/p/git-core/downloads/list\n\nand their SHA-1 checksums are:\n\n6216153da1139c25cb96cfb4441eff327013ec4f git-1.7.9.3.tar.gz\n2d488c3975da1c2ea90965b82233a986c498a8c2 git-htmldocs-1.7.9.3.tar.gz\n223daa871a64facc60bdf643c50c78eac21c88f4 git-manpages-1.7.9.3.tar.gz\n\nAlso the following public repositories all have a copy of the v1.7.9.3\ntag and the maint branch that the tag points at:\n\n url = git://repo.or.cz/alt-git.git\n url = https://code.google.com/p/git-core/\n url = git://git.sourceforge.jp/gitroot/git-core/git.git\n url = git://git-core.git.sourceforge.net/gitroot/git-core/git-core\n url = https://github.com/gitster/git\n\n\nGit v1.7.9.3 Release Notes\n==========================\n\nFixes since v1.7.9.2\n--------------------\n\n * \"git p4\" (in contrib/) submit the changes to a wrong place when the\n \"--use-client-spec\" option is set.\n\n * The config.mak.autogen generated by optional autoconf support tried\n to link the binary with -lintl even when libintl.h is missing from\n the system.\n\n * When the filter driver exits before reading the content before the\n main git process writes the contents to be filtered to the pipe to\n it, the latter could be killed with SIGPIPE instead of ignoring\n such an event as an error.\n\n * \"git add --refresh \" used to warn about unmerged paths\n outside the given pathspec.\n\n * The bulk check-in codepath in \"git add\" streamed contents that\n needs smudge/clean filters without running them, instead of punting\n and delegating to the codepath to run filters after slurping\n everything to core.\n\n * \"git branch --with $that\" assumed incorrectly that the user will never\n ask the question with nonsense value in $that.\n\n * \"git bundle create\" produced a corrupt bundle file upon seeing\n commits with excessively long subject line.\n\n * When a remote helper exits before reading the blank line from the\n main git process to signal the end of commands, the latter could be\n killed with SIGPIPE. Instead we should ignore such event as a\n non-error.\n\n * The commit log template given with \"git merge --edit\" did not have\n a short instructive text like what \"git commit\" gives.\n\n * \"git rev-list --verify-objects -q\" omitted the extra verification\n it needs to do over \"git rev-list --objects -q\" by mistake.\n\n * \"gitweb\" used to drop warnings in the log file when \"heads\" view is\n accessed in a repository whose HEAD does not point at a valid\n branch.\n\n * An invalid regular expression pattern given by an end user made\n \"gitweb\" to return garbled response.\n\nAlso contains minor fixes and documentation updates.\n\n\n----------------------------------------------------------------\n\nChanges since v1.7.9.2 are as follows:\n\nAndrew Wong (1):\n rebase -m: only call \"notes copy\" when rewritten exists and is non-empty\n\nCarlos Martín Nieto (2):\n branch: don't assume the merge filter ref exists\n Documentation: use {asterisk} in rev-list-options.txt when needed\n\nClemens Buchacher (1):\n http.proxy: also mention https_proxy and all_proxy\n\nDmitry V. Levin (1):\n Makefile: add thread-utils.h to LIB_H\n\nJakub Narebski (2):\n gitweb: Fix \"heads\" view when there is no current branch\n gitweb: Handle invalid regexp in regexp search\n\nJeff King (4):\n disconnect from remote helpers more gently\n teach convert_to_git a \"dry run\" mode\n teach dry-run convert_to_git not to require a src buffer\n do not stream large files to pack when filters are in use\n\nJehan Bing (1):\n Ignore SIGPIPE when running a filter driver\n\nJim Meyering (1):\n am: don't infloop for an empty input file\n\nJohn Szakmeister (1):\n configure: don't use -lintl when there is no gettext support\n\nJonathan Nieder (1):\n mergetools/meld: Use --help output to detect --output support\n\nJunio C Hamano (9):\n refresh_index: do not show unmerged path that is outside pathspec\n Documentation/merge-options.txt: group \"ff\" related options together\n Document merge.branchdesc configuration variable\n Git 1.7.8.5\n Document accumulated fixes since 1.7.9.2\n Update draft release notes to 1.7.9.3\n Documentation: do not assume that n > 1 in ~$n\n Update draft release notes to 1.7.9.3 for the last time\n Git 1.7.9.3\n\nLibor Pechacek (1):\n Documentation fixes in git-config\n\nMatthieu Moy (1):\n README: point to Documentation/SubmittingPatches\n\nMichael Haggerty (2):\n post-receive-email: remove unused variable\n post-receive-email: match up $LOGBEGIN..$LOGEND pairs correctly\n\nMichael J Gruber (1):\n t0300: work around bug in dash 0.5.6\n\nMichał Kiedrowicz (1):\n grep -P: Fix matching ^ and $\n\nNguyễn Thái Ngọc Duy (2):\n rev-list: remove BISECT_SHOW_TRIED flag\n rev-list: fix --verify-objects --quiet becoming --objects\n\nPete Wyckoff (4):\n git-p4: set useClientSpec variable on initial clone\n git-p4: fix submit regression with clientSpec and subdir clone\n git-p4: remove bash-ism in t9809\n git-p4: remove bash-ism in t9800\n\nPhilip Jägenstedt (1):\n remote: fix set-branches usage and documentation\n\nStefano Lattarini (1):\n tests: fix spurious error when run directly with Solaris /usr/xpg4/bin/sh\n\nThomas Rast (6):\n merge: add instructions to the commit message when editing\n bundle: put strbuf_readline_fd in strbuf.c with adjustments\n bundle: use a strbuf to scan the log for boundary commits\n strbuf: improve strbuf_get*line documentation\n t5704: match tests to modern style\n fast-import: zero all of 'struct tag' to silence valgrind\n\nTim Henigan (2):\n CodingGuidelines: Add a note about spaces after redirection\n CodingGuidelines: do not use 'which' in shell scripts\n\nTom Grennan (1):\n t5512 (ls-remote): modernize style\n"},{"id":"186216","messageId":"A518E7E7-25D5-429C-A1C1-35F94EC8F043@bjhargrave.com","threadId":"29846","inReplyTo":"7vliney6k7.fsf@alter.siamese.dyndns.org","subject":"Re: [ANNOUNCE] Git 1.7.9.3","fromName":"BJ Hargrave","fromEmail":"bj@bjhargrave.com","sentAt":"2012-03-06T14:35:48Z","receivedAt":"2012-03-06T14:35:48Z","isPatch":false,"sender":{"key":"bj@bjhargrave.com","avatar":"https://gravatar.com/avatar/48e60c01177c0e8d3e60c996d54fbe36cf70058efcdd020375b4055e34fc05d7?d=mp&s=160"},"body":"\nOn Mar 5, 2012, at 18:24 , Junio C Hamano wrote:\n\n> Thomas Rast (6):\n> bundle: use a strbuf to scan the log for boundary commits\n\nThis fix (bc2fed496baa54ae99dede7da23dec938adbf0eb) modified test t5704 which now fails on my Mac (10.7.3)\n\n*** t5704-bundle.sh ***\nok 1 - setup\nok 2 - tags can be excluded by rev-list options\nok 3 - die if bundle file cannot be created\nnot ok 4 - bundle --stdin # TODO known breakage\nnot ok 5 - bundle --stdin # TODO known breakage\nok 6 - empty bundle file is rejected\nnot ok - 7 ridiculously long subject in boundary\n#\t\n#\t\t: >file4 &&\n#\t\ttest_tick &&\n#\t\tgit add file4 &&\n#\t\tprintf \"%01200d\n#\t\" 0 | git commit -F - &&\n#\t\ttest_commit fifth &&\n#\t\tgit bundle create long-subject-bundle.bdl HEAD^..HEAD &&\n#\t\tgit bundle list-heads long-subject-bundle.bdl >heads &&\n#\t\ttest -s heads &&\n#\t\tgit fetch long-subject-bundle.bdl &&\n#\t\tsed -n \"/^-/{p;q}\" long-subject-bundle.bdl >boundary &&\n#\t\tgrep \"^-$_x40 \" boundary\n#\t\n# still have 2 known breakage(s)\n# failed 1 among remaining 5 test(s)\n1..7\nmake[3]: *** [t5704-bundle.sh] Error 1\n\n\n-- \n\nBJ Hargrave\n"},{"id":"186219","messageId":"87y5rd4wci.fsf@thomas.inf.ethz.ch","threadId":"29846","inReplyTo":"A518E7E7-25D5-429C-A1C1-35F94EC8F043@bjhargrave.com","subject":"Re: [ANNOUNCE] Git 1.7.9.3","fromName":"Thomas Rast","fromEmail":"trast@inf.ethz.ch","sentAt":"2012-03-06T14:50:37Z","receivedAt":"2012-03-06T14:50:37Z","isPatch":false,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"BJ Hargrave writes:\n\n> ok 6 - empty bundle file is rejected\n> not ok - 7 ridiculously long subject in boundary\n> #\t\n> #\t\t: >file4 &&\n> #\t\ttest_tick &&\n> #\t\tgit add file4 &&\n> #\t\tprintf \"%01200d\n> #\t\" 0 | git commit -F - &&\n> #\t\ttest_commit fifth &&\n> #\t\tgit bundle create long-subject-bundle.bdl HEAD^..HEAD &&\n> #\t\tgit bundle list-heads long-subject-bundle.bdl >heads &&\n> #\t\ttest -s heads &&\n> #\t\tgit fetch long-subject-bundle.bdl &&\n> #\t\tsed -n \"/^-/{p;q}\" long-subject-bundle.bdl >boundary &&\n> #\t\tgrep \"^-$_x40 \" boundary\n\nI can reproduce this. The failure (to be seen from -v, which would have\nbeen really nice to have in the original mail):\n\n sed: 1: \"/^-/{p;q}\": extra characters at the end of q command\n\nThis can be fixed with the change below, which then gets us into the\nnext one\n\n grep: Regular expression too big\n\nSheesh, Apple, are you kidding me?! So we also need to change the grep\nexpression.\n\n----- 8< -----\nSubject: [PATCH] t5704: fix nonportable sed/grep usages\n\nOS X's sed and grep would complain with (respectively)\n\n sed: 1: \"/^-/{p;q}\": extra characters at the end of q command\n grep: Regular expression too big\n\nFor sed, use an explicit ; to terminate the q command.\n\nFor grep, spell the \"40 hex digits\" explicitly in the regex, instead\nof being lazy with the shell pattern $_x40.\n---\n t/t5704-bundle.sh | 4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t5704-bundle.sh b/t/t5704-bundle.sh\nindex a51c8b0..9e43731 100755\n--- a/t/t5704-bundle.sh\n+++ b/t/t5704-bundle.sh\n@@ -54,8 +54,8 @@ test_expect_success 'ridiculously long subject in boundary' '\n \tgit bundle list-heads long-subject-bundle.bdl >heads &&\n \ttest -s heads &&\n \tgit fetch long-subject-bundle.bdl &&\n-\tsed -n \"/^-/{p;q}\" long-subject-bundle.bdl >boundary &&\n-\tgrep \"^-$_x40 \" boundary\n+\tsed -n \"/^-/{p;q;}\" long-subject-bundle.bdl >boundary &&\n+\tgrep \"^-[0-9a-f]\\\\{40\\\\} \" boundary\n '\n \n test_done\n-- \n1.7.6.557.gcee4\n\n\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"},{"id":"186223","messageId":"7v7gyxvhqs.fsf@alter.siamese.dyndns.org","threadId":"29846","inReplyTo":"87y5rd4wci.fsf@thomas.inf.ethz.ch","subject":"Re: [ANNOUNCE] Git 1.7.9.3","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-03-06T16:03:55Z","receivedAt":"2012-03-06T16:03:55Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thomas Rast writes:\n\n> +\tsed -n \"/^-/{p;q;}\" long-subject-bundle.bdl >boundary &&\n\nAlright. we see trailing ;} in t4300.\n\n> +\tgrep \"^-[0-9a-f]\\\\{40\\\\} \" boundary\n\nOk, that is what we already use in t5510 so it should be safe.\n\nThanks.\n"},{"id":"186246","messageId":"7v8vjdsdak.fsf@alter.siamese.dyndns.org","threadId":"29846","inReplyTo":"87y5rd4wci.fsf@thomas.inf.ethz.ch","subject":"Re: [ANNOUNCE] Git 1.7.9.3","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-03-06T20:08:19Z","receivedAt":"2012-03-06T20:08:19Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thomas Rast writes:\n\n> This can be fixed with the change below, which then gets us into the\n> next one\n>\n> grep: Regular expression too big\n>\n> Sheesh, Apple, are you kidding me?! So we also need to change the grep\n> expression.\n>\n> ----- 8< -----\n> Subject: [PATCH] t5704: fix nonportable sed/grep usages\n>\n> OS X's sed and grep would complain with (respectively)\n>\n> sed: 1: \"/^-/{p;q}\": extra characters at the end of q command\n> grep: Regular expression too big\n>\n> For sed, use an explicit ; to terminate the q command.\n>\n> For grep, spell the \"40 hex digits\" explicitly in the regex, instead\n> of being lazy with the shell pattern $_x40.\n> ---\n\nActually the shell pattern $_x40 was invented so that it can be used\nin both shell, grep and sed; there is nothing *lazy* about it.\n\nI share the \"are you kidding me?!\" with you. I cannot fathom which\npart of that regular expression is too big for them to swallow.\n\nIn any case, thanks for a quick fix; can I consider it as signed-off?\n\n> t/t5704-bundle.sh | 4 ++--\n> 1 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/t/t5704-bundle.sh b/t/t5704-bundle.sh\n> index a51c8b0..9e43731 100755\n> --- a/t/t5704-bundle.sh\n> +++ b/t/t5704-bundle.sh\n> @@ -54,8 +54,8 @@ test_expect_success 'ridiculously long subject in boundary' '\n> \tgit bundle list-heads long-subject-bundle.bdl >heads &&\n> \ttest -s heads &&\n> \tgit fetch long-subject-bundle.bdl &&\n> -\tsed -n \"/^-/{p;q}\" long-subject-bundle.bdl >boundary &&\n> -\tgrep \"^-$_x40 \" boundary\n> +\tsed -n \"/^-/{p;q;}\" long-subject-bundle.bdl >boundary &&\n> +\tgrep \"^-[0-9a-f]\\\\{40\\\\} \" boundary\n> '\n> \n> test_done\n> -- \n> 1.7.6.557.gcee4\n"},{"id":"186248","messageId":"877gyx4gkn.fsf@thomas.inf.ethz.ch","threadId":"29846","inReplyTo":"7v8vjdsdak.fsf@alter.siamese.dyndns.org","subject":"Re: [ANNOUNCE] Git 1.7.9.3","fromName":"Thomas Rast","fromEmail":"trast@inf.ethz.ch","sentAt":"2012-03-06T20:31:20Z","receivedAt":"2012-03-06T20:31:20Z","isPatch":false,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Junio C Hamano writes:\n\n> Thomas Rast writes:\n>\n>> For grep, spell the \"40 hex digits\" explicitly in the regex, instead\n>> of being lazy with the shell pattern $_x40.\n>\n> Actually the shell pattern $_x40 was invented so that it can be used\n> in both shell, grep and sed; there is nothing *lazy* about it.\n>\n> I share the \"are you kidding me?!\" with you. I cannot fathom which\n> part of that regular expression is too big for them to swallow.\n>\n> In any case, thanks for a quick fix; can I consider it as signed-off?\n\nOh, yes! Sorry about that. I pulled it from the OS X machine which did\nnot have S-O-B appropriately configured.\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"}]}