{"thread":{"id":"29817","subject":"[PATCH (bugfix)] gitweb: Fix passing parameters to git_project_search_form","startedAt":"2012-03-02T22:50:01Z","lastAt":"2012-03-02T23:55:22Z","messageCount":2,"participants":["Jakub Narebski","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"185951","messageId":"1330728601-27124-1-git-send-email-jnareb@gmail.com","threadId":"29817","inReplyTo":null,"subject":"[PATCH (bugfix)] gitweb: Fix passing parameters to git_project_search_form","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2012-03-02T22:50:01Z","receivedAt":"2012-03-02T22:50:01Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"The git_project_search_form() subroutine, introduced in a1e1b2d\n(gitweb: improve usability of projects search form, 2012-01-31) didn't\nget its arguments from caller correctly.  Gitweb worked correctly\nthanks to sticky-ness of form fields in CGI.pm... but it make UTF-8\nfix for project search not working.\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\nBrown paper bug (a1e1b2d is in master).  I am extremly sorry about that.\n\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 7398be1..e2e6a73 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -5263,7 +5263,7 @@ sub git_patchset_body {\n # . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . .\n \n sub git_project_search_form {\n-\tmy ($searchtext, $search_use_regexp);\n+\tmy ($searchtext, $search_use_regexp) = @_;\n \n \tmy $limit = '';\n \tif ($project_filter) {\n-- \n1.7.9\n"},{"id":"185952","messageId":"7v1upablsl.fsf@alter.siamese.dyndns.org","threadId":"29817","inReplyTo":"1330728601-27124-1-git-send-email-jnareb@gmail.com","subject":"Re: [PATCH (bugfix)] gitweb: Fix passing parameters to git_project_search_form","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-03-02T23:55:22Z","receivedAt":"2012-03-02T23:55:22Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski <jnareb@gmail.com> writes:\n\n> The git_project_search_form() subroutine, introduced in a1e1b2d\n> (gitweb: improve usability of projects search form, 2012-01-31) didn't\n> get its arguments from caller correctly.  Gitweb worked correctly\n> thanks to sticky-ness of form fields in CGI.pm... but it make UTF-8\n> fix for project search not working.\n>\n> Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n> ---\n> Brown paper bug (a1e1b2d is in master).  I am extremly sorry about that.\n\nHeh, mistakes happen.  Thanks for taking care of this.\n\n>\n>  gitweb/gitweb.perl |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index 7398be1..e2e6a73 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -5263,7 +5263,7 @@ sub git_patchset_body {\n>  # . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . .\n>  \n>  sub git_project_search_form {\n> -\tmy ($searchtext, $search_use_regexp);\n> +\tmy ($searchtext, $search_use_regexp) = @_;\n>  \n>  \tmy $limit = '';\n>  \tif ($project_filter) {\n"}]}