{"thread":{"id":"2978","subject":"Use testlib to skip t3300-funny-names","startedAt":"2006-01-05T11:53:15Z","lastAt":"2006-01-07T09:25:38Z","messageCount":3,"participants":["Alex Riesen","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"14180","messageId":"81b0412b0601050353o6b96ed4fp2a6d24dd514cc9c2@mail.gmail.com","threadId":"2978","inReplyTo":null,"subject":"Use testlib to skip t3300-funny-names","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2006-01-05T11:53:15Z","receivedAt":"2006-01-05T11:53:15Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"The test cannot be run on cygwin anyway.\nCorrected the error message to reflect the problem source.\n\nSigned-off-by: Alex Riesen <raa.lkml@gmail.com>\n\n\nSubject: [PATCH] Use testlib to skip the test (it cannot be run on cygwin)\n\nCorrect the error message to reflect the problem source\n\nSigned-off-by: Alex Riesen <raa.lkml@gmail.com>\n\n\n---\n\n t/t3300-funny-names.sh |   10 +++++++---\n 1 files changed, 7 insertions(+), 3 deletions(-)\n\n721ca495bbbff1d387aa48ae401b7a14fb486ac0\ndiff --git a/t/t3300-funny-names.sh b/t/t3300-funny-names.sh\nindex 6a85d67..5d70594 100755\n--- a/t/t3300-funny-names.sh\n+++ b/t/t3300-funny-names.sh\n@@ -9,11 +9,15 @@ This test tries pathnames with funny cha\n tree, index, and tree objects.\n '\n \n-# since FAT/NTFS does not allow tabs in filenames, skip this test\n-test \"$(uname -o 2>/dev/null)\" = Cygwin && exit 0\n-\n . ./test-lib.sh\n \n+# Since FAT/NTFS does not allow tabs in filenames, skip this test.\n+# Windows also have unexplainable problems with names containing only spaces.\n+if [ \"$(uname -o 2>/dev/null)\" = Cygwin ]; then\n+    say 'FAT and NTFS on Windows do not allow tabs in filenames, test skipped'\n+    test_done\n+fi\n+\n p0='no-funny'\n p1='tabs\t,\" (dq) and spaces'\n p2='just space'\n-- \n1.0.GIT\n"},{"id":"14208","messageId":"7vvewxq8xg.fsf@assigned-by-dhcp.cox.net","threadId":"2978","inReplyTo":"81b0412b0601050353o6b96ed4fp2a6d24dd514cc9c2@mail.gmail.com","subject":"Re: Use testlib to skip t3300-funny-names","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-01-06T22:38:03Z","receivedAt":"2006-01-06T22:38:03Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alex Riesen <raa.lkml@gmail.com> writes:\n\n> The test cannot be run on cygwin anyway.\n> Corrected the error message to reflect the problem source.\n\nI'd rather see the test actually try to create a funny-named\ntestfile and see if it managed to create it, so that it can be\nskipped on non DOS systems that mounted DOS filesystem.\n\nSo instead I would do something like this:\n\n---\ndiff --git a/t/t3300-funny-names.sh b/t/t3300-funny-names.sh\nindex 6a85d67..b1a86db 100755\n--- a/t/t3300-funny-names.sh\n+++ b/t/t3300-funny-names.sh\n@@ -9,9 +9,6 @@ This test tries pathnames with funny cha\n tree, index, and tree objects.\n '\n \n-# since FAT/NTFS does not allow tabs in filenames, skip this test\n-test \"$(uname -o 2>/dev/null)\" = Cygwin && exit 0\n-\n . ./test-lib.sh\n \n p0='no-funny'\n@@ -27,6 +24,12 @@ EOF\n cat >\"$p1\" \"$p0\"\n echo 'Foo Bar Baz' >\"$p2\"\n \n+test -f \"$p1\" && cmp \"$p0\" \"$p1\" || {\n+\t# since FAT/NTFS does not allow tabs in filenames, skip this test\n+\tsay 'Your filesystem does not allow tabs in filenames, test skipped.'\n+\ttest_done\n+}\n+\n echo 'just space\n no-funny' >expected\n test_expect_success 'git-ls-files no-funny' \\\n"},{"id":"14235","messageId":"20060107092538.GA5536@steel.home","threadId":"2978","inReplyTo":"7vvewxq8xg.fsf@assigned-by-dhcp.cox.net","subject":"Re: Use testlib to skip t3300-funny-names","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2006-01-07T09:25:38Z","receivedAt":"2006-01-07T09:25:38Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Junio C Hamano, Fri, Jan 06, 2006 23:38:03 +0100:\n> > The test cannot be run on cygwin anyway.\n> > Corrected the error message to reflect the problem source.\n> \n> I'd rather see the test actually try to create a funny-named\n> testfile and see if it managed to create it, so that it can be\n> skipped on non DOS systems that mounted DOS filesystem.\n> \n> So instead I would do something like this:\n> \n> +test -f \"$p1\" && cmp \"$p0\" \"$p1\" || {\n> +\t# since FAT/NTFS does not allow tabs in filenames, skip this test\n> +\tsay 'Your filesystem does not allow tabs in filenames, test skipped.'\n> +\ttest_done\n> +}\n\nYes, that's better\n"}]}