{"thread":{"id":"29761","subject":"[PATCH 1/2] post-receive-email: remove unused variable","startedAt":"2012-02-27T18:34:08Z","lastAt":"2012-02-27T19:01:05Z","messageCount":4,"participants":["mhagger@alum.mit.edu","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"185537","messageId":"1330367650-23091-1-git-send-email-mhagger@alum.mit.edu","threadId":"29761","inReplyTo":null,"subject":"[PATCH 0/2] Trivial cleanups in the post-receive-email script","fromName":"","fromEmail":"mhagger@alum.mit.edu","sentAt":"2012-02-27T18:34:08Z","receivedAt":"2012-02-27T18:34:08Z","isPatch":true,"sender":{"key":"mhagger@alum.mit.edu","avatar":"https://avatars.githubusercontent.com/u/119718?v=4"},"body":"From: Michael Haggerty <mhagger@alum.mit.edu>\n\nShould be self-explanatory.\n\nMichael Haggerty (2):\n  post-receive-email: remove unused variable\n  post-receive-email: match up $LOGBEGIN..$LOGEND pairs correctly\n\n contrib/hooks/post-receive-email |    7 +++----\n 1 files changed, 3 insertions(+), 4 deletions(-)\n\n-- \n1.7.9\n"},{"id":"185536","messageId":"1330367650-23091-2-git-send-email-mhagger@alum.mit.edu","threadId":"29761","inReplyTo":"1330367650-23091-1-git-send-email-mhagger@alum.mit.edu","subject":"[PATCH 1/2] post-receive-email: remove unused variable","fromName":"","fromEmail":"mhagger@alum.mit.edu","sentAt":"2012-02-27T18:34:09Z","receivedAt":"2012-02-27T18:34:09Z","isPatch":true,"sender":{"key":"mhagger@alum.mit.edu","avatar":"https://avatars.githubusercontent.com/u/119718?v=4"},"body":"From: Michael Haggerty <mhagger@alum.mit.edu>\n\nprep_for_email neither is passed a fourth argument nor uses it.\n\nSigned-off-by: Michael Haggerty <mhagger@alum.mit.edu>\n---\n contrib/hooks/post-receive-email |    1 -\n 1 files changed, 0 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email\nindex ba077c1..ac2e0ed 100755\n--- a/contrib/hooks/post-receive-email\n+++ b/contrib/hooks/post-receive-email\n@@ -85,7 +85,6 @@ prep_for_email()\n \toldrev=$(git rev-parse $1)\n \tnewrev=$(git rev-parse $2)\n \trefname=\"$3\"\n-\tmaxlines=$4\n \n \t# --- Interpret\n \t# 0000->1234 (create)\n-- \n1.7.9\n"},{"id":"185538","messageId":"1330367650-23091-3-git-send-email-mhagger@alum.mit.edu","threadId":"29761","inReplyTo":"1330367650-23091-1-git-send-email-mhagger@alum.mit.edu","subject":"[PATCH 2/2] post-receive-email: match up $LOGBEGIN..$LOGEND pairs correctly","fromName":"","fromEmail":"mhagger@alum.mit.edu","sentAt":"2012-02-27T18:34:10Z","receivedAt":"2012-02-27T18:34:10Z","isPatch":true,"sender":{"key":"mhagger@alum.mit.edu","avatar":"https://avatars.githubusercontent.com/u/119718?v=4"},"body":"From: Michael Haggerty <mhagger@alum.mit.edu>\n\n\nSigned-off-by: Michael Haggerty <mhagger@alum.mit.edu>\n---\n contrib/hooks/post-receive-email |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email\nindex ac2e0ed..01af9df 100755\n--- a/contrib/hooks/post-receive-email\n+++ b/contrib/hooks/post-receive-email\n@@ -460,7 +460,7 @@ generate_delete_branch_email()\n {\n \techo \"       was  $oldrev\"\n \techo \"\"\n-\techo $LOGEND\n+\techo $LOGBEGIN\n \tgit show -s --pretty=oneline $oldrev\n \techo $LOGEND\n }\n@@ -560,7 +560,7 @@ generate_delete_atag_email()\n {\n \techo \"       was  $oldrev\"\n \techo \"\"\n-\techo $LOGEND\n+\techo $LOGBEGIN\n \tgit show -s --pretty=oneline $oldrev\n \techo $LOGEND\n }\n@@ -625,7 +625,7 @@ generate_delete_general_email()\n {\n \techo \"       was  $oldrev\"\n \techo \"\"\n-\techo $LOGEND\n+\techo $LOGBEGIN\n \tgit show -s --pretty=oneline $oldrev\n \techo $LOGEND\n }\n-- \n1.7.9\n"},{"id":"185545","messageId":"7vlino85ji.fsf@alter.siamese.dyndns.org","threadId":"29761","inReplyTo":"1330367650-23091-1-git-send-email-mhagger@alum.mit.edu","subject":"Re: [PATCH 0/2] Trivial cleanups in the post-receive-email script","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-02-27T19:01:05Z","receivedAt":"2012-02-27T19:01:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Shows that nobody uses these sample script.\n\nWill apply.  I wish all the patches were this easy ;-).\n\nThanks.\n"}]}