{"thread":{"id":"29731","subject":"[PATCH] pack-objects: Fix compilation with NO_PTHREDS","startedAt":"2012-02-25T08:16:09Z","lastAt":"2012-02-25T09:24:42Z","messageCount":3,"participants":["Michał Kiedrowicz","Junio C Hamano","Nguyen Thai Ngoc Duy"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"185404","messageId":"1330157769-7884-1-git-send-email-michal.kiedrowicz@gmail.com","threadId":"29731","inReplyTo":null,"subject":"[PATCH] pack-objects: Fix compilation with NO_PTHREDS","fromName":"Michał Kiedrowicz","fromEmail":"michal.kiedrowicz@gmail.com","sentAt":"2012-02-25T08:16:09Z","receivedAt":"2012-02-25T08:16:09Z","isPatch":true,"sender":{"key":"michal.kiedrowicz@gmail.com","avatar":"https://avatars.githubusercontent.com/u/14072847?v=4"},"body":"It looks like commit 99fb6e04 (pack-objects: convert to use\nparse_options(), 2012-02-01) moved the #ifdef NO_PTHREDS around but\nhasn't noticed that the 'arg' variable no longer is available.\n\nSigned-off-by: Michał Kiedrowicz <michal.kiedrowicz@gmail.com>\n---\n builtin/pack-objects.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin/pack-objects.c b/builtin/pack-objects.c\nindex db09cf7..71af246 100644\n--- a/builtin/pack-objects.c\n+++ b/builtin/pack-objects.c\n@@ -2449,7 +2449,7 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix)\n \t\tdie(\"bad pack compression level %d\", pack_compression_level);\n #ifdef NO_PTHREADS\n \tif (delta_search_threads != 1)\n-\t\twarning(\"no threads support, ignoring %s\", arg);\n+\t\twarning(\"no threads support, ignoring --threads\");\n #endif\n \tif (!pack_to_stdout && !pack_size_limit)\n \t\tpack_size_limit = pack_size_limit_cfg;\n-- \n1.7.8.4\n"},{"id":"185407","messageId":"7vty2fffpp.fsf@alter.siamese.dyndns.org","threadId":"29731","inReplyTo":"1330157769-7884-1-git-send-email-michal.kiedrowicz@gmail.com","subject":"Re: [PATCH] pack-objects: Fix compilation with NO_PTHREDS","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-02-25T09:02:42Z","receivedAt":"2012-02-25T09:02:42Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Michał Kiedrowicz <michal.kiedrowicz@gmail.com> writes:\n\n> It looks like commit 99fb6e04 (pack-objects: convert to use\n> parse_options(), 2012-02-01) moved the #ifdef NO_PTHREDS around but\n> hasn't noticed that the 'arg' variable no longer is available.\n>\n> Signed-off-by: Michał Kiedrowicz <michal.kiedrowicz@gmail.com>\n\nThanks.  Nguyễn, a quick double-check and an Ack?\n\n> ---\n>  builtin/pack-objects.c |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c\n> index db09cf7..71af246 100644\n> --- a/builtin/pack-objects.c\n> +++ b/builtin/pack-objects.c\n> @@ -2449,7 +2449,7 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix)\n>  \t\tdie(\"bad pack compression level %d\", pack_compression_level);\n>  #ifdef NO_PTHREADS\n>  \tif (delta_search_threads != 1)\n> -\t\twarning(\"no threads support, ignoring %s\", arg);\n> +\t\twarning(\"no threads support, ignoring --threads\");\n>  #endif\n>  \tif (!pack_to_stdout && !pack_size_limit)\n>  \t\tpack_size_limit = pack_size_limit_cfg;\n"},{"id":"185409","messageId":"CACsJy8CrVEQ+vCXyXhGry5tRwYoyc7NHeOJg7UXCTPF+50sexA@mail.gmail.com","threadId":"29731","inReplyTo":"7vty2fffpp.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] pack-objects: Fix compilation with NO_PTHREDS","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2012-02-25T09:24:42Z","receivedAt":"2012-02-25T09:24:42Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"2012/2/25 Junio C Hamano <gitster@pobox.com>:\n> Michał Kiedrowicz <michal.kiedrowicz@gmail.com> writes:\n>\n>> It looks like commit 99fb6e04 (pack-objects: convert to use\n>> parse_options(), 2012-02-01) moved the #ifdef NO_PTHREDS around but\n>> hasn't noticed that the 'arg' variable no longer is available.\n>>\n>> Signed-off-by: Michał Kiedrowicz <michal.kiedrowicz@gmail.com>\n>\n> Thanks.  Nguyễn, a quick double-check and an Ack?\n\nTested and acked.\n-- \nDuy\n"}]}