{"thread":{"id":"2970","subject":"trivial: O_EXCL makes O_TRUNC redundant","startedAt":"2006-01-05T08:58:06Z","lastAt":"2006-01-05T08:58:06Z","messageCount":1,"participants":["Alex Riesen"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"14172","messageId":"81b0412b0601050058y27eb492fu9a24f99e32e9f439@mail.gmail.com","threadId":"2970","inReplyTo":null,"subject":"trivial: O_EXCL makes O_TRUNC redundant","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2006-01-05T08:58:06Z","receivedAt":"2006-01-05T08:58:06Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Signed-off-by: Alex Riesen <raa.lkml@gmail.com>\n\n\nSubject: [PATCH] O_EXCL makes O_TRUNC redundant\n\nSigned-off-by: Alex Riesen <raa.lkml@gmail.com>\n\n\n---\n\n apply.c |    2 +-\n entry.c |    2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\n4d5e4d8d468c0eedf489104e9f02f86c635c8ac2\ndiff --git a/apply.c b/apply.c\nindex d5e7bfd..9eba034 100644\n--- a/apply.c\n+++ b/apply.c\n@@ -1588,7 +1588,7 @@ static int try_create_file(const char *p\n \n \tif (S_ISLNK(mode))\n \t\treturn symlink(buf, path);\n-\tfd = open(path, O_CREAT | O_EXCL | O_WRONLY | O_TRUNC, (mode & 0100) ? 0777 : 0666);\n+\tfd = open(path, O_CREAT | O_EXCL | O_WRONLY, (mode & 0100) ? 0777 : 0666);\n \tif (fd < 0)\n \t\treturn -1;\n \twhile (size) {\ndiff --git a/entry.c b/entry.c\nindex 15b34eb..410b758 100644\n--- a/entry.c\n+++ b/entry.c\n@@ -60,7 +60,7 @@ static void remove_subtree(const char *p\n static int create_file(const char *path, unsigned int mode)\n {\n \tmode = (mode & 0100) ? 0777 : 0666;\n-\treturn open(path, O_WRONLY | O_TRUNC | O_CREAT | O_EXCL, mode);\n+\treturn open(path, O_WRONLY | O_CREAT | O_EXCL, mode);\n }\n \n static int write_entry(struct cache_entry *ce, const char *path, struct checkout *state)\n-- \n1.0.GIT\n"}]}