{"thread":{"id":"29688","subject":"git-p4 uses -h for host instead of -H","startedAt":"2012-02-22T00:49:12Z","lastAt":"2012-02-22T01:23:26Z","messageCount":2,"participants":["Russell Myers","Pete Wyckoff"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"185125","messageId":"4F443B88.6020902@russellmyers.com","threadId":"29688","inReplyTo":"CAA5tD2sYSqtGTwW1PmFMB_mP_xG24VS6hPXTLD33bJsMaj4MWg@mail.gmail.com","subject":"git-p4 uses -h for host instead of -H","fromName":"Russell Myers","fromEmail":"mezner@russellmyers.com","sentAt":"2012-02-22T00:49:12Z","receivedAt":"2012-02-22T00:49:12Z","isPatch":false,"sender":{"key":"mezner@russellmyers.com","avatar":null},"body":"In attempting to use the git-p4 plugin I ran into an issue when the host \nargument was specified using the -h argument instead of the -H argument \nfor the host. As a result, I found that instead of git-p4 specifying a \nhost, it gets help information. Correcting this issue allowed me to \nclone without issue. I've attached a patch of what I did to fix the \nissue if this is indeed believed to be an issue.\n\nThanks,\n\nRussell\n\n\n\n>From 2f6c91282c98ca0a45269524ec74655f76921ec9 Mon Sep 17 00:00:00 2001\nFrom: Russell Myers <mezner@russellmyers.com>\nDate: Tue, 21 Feb 2012 19:18:54 -0500\nSubject: [PATCH] Changing host argument to -H from -h. Based on\n http://www.perforce.com/perforce/doc.current/manuals/p4guide/03_using.html\n '-H' is the apporpriate flag while '-h' is a flag passed\n for help content.\n\n---\n contrib/fast-import/git-p4 |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4\nindex a78d9c5..d2fd265 100755\n--- a/contrib/fast-import/git-p4\n+++ b/contrib/fast-import/git-p4\n@@ -38,7 +38,7 @@ def p4_build_cmd(cmd):\n \n     host = gitConfig(\"git-p4.host\")\n     if len(host) > 0:\n-        real_cmd += [\"-h\", host]\n+        real_cmd += [\"-H\", host]\n \n     client = gitConfig(\"git-p4.client\")\n     if len(client) > 0:\n-- \n1.7.5.4\n\n"},{"id":"185127","messageId":"20120222012326.GA870@padd.com","threadId":"29688","inReplyTo":"CAA5tD2sYSqtGTwW1PmFMB_mP_xG24VS6hPXTLD33bJsMaj4MWg@mail.gmail.com","subject":"Re: git-p4 uses -h for host instead of -H","fromName":"Pete Wyckoff","fromEmail":"pw@padd.com","sentAt":"2012-02-22T01:23:26Z","receivedAt":"2012-02-22T01:23:26Z","isPatch":false,"sender":{"key":"pw@padd.com","avatar":null},"body":"mezner@russellmyers.com wrote on Tue, 21 Feb 2012 19:35 -0500:\n> In attempting to use the git-p4 plugin I ran into an issue when the host\n> argument was specified using the -h argument instead of the -H argument for\n> the host. As a result, I found that instead of git-p4 specifying a host, it\n> gets help information. Correcting this issue allowed me to clone without\n> issue. I've attached a patch of what I did to fix the issue if this is\n> indeed believed to be an issue.\n\nAck to this.  Looks like the bug has been in there since the\nfeature of git-p4.host was introduced in abcaf07 (If the user has\nconfigured various parameters, use them., 2008-08-10).\n\nThanks for the fix.\n\n\t\t-- Pete\n\n> From 2f6c91282c98ca0a45269524ec74655f76921ec9 Mon Sep 17 00:00:00 2001\n> From: Russell Myers <mezner@russellmyers.com>\n> Date: Tue, 21 Feb 2012 19:18:54 -0500\n> Subject: [PATCH] Changing host argument to -H from -h. Based on\n>  http://www.perforce.com/perforce/doc.current/manuals/p4guide/03_using.html\n>  '-H' is the apporpriate flag while '-h' is a flag passed\n>  for help content.\n> \n> ---\n>  contrib/fast-import/git-p4 |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4\n> index a78d9c5..d2fd265 100755\n> --- a/contrib/fast-import/git-p4\n> +++ b/contrib/fast-import/git-p4\n> @@ -38,7 +38,7 @@ def p4_build_cmd(cmd):\n>  \n>      host = gitConfig(\"git-p4.host\")\n>      if len(host) > 0:\n> -        real_cmd += [\"-h\", host]\n> +        real_cmd += [\"-H\", host]\n>  \n>      client = gitConfig(\"git-p4.client\")\n>      if len(client) > 0:\n> -- \n> 1.7.5.4\n> \n"}]}