{"thread":{"id":"2963","subject":"git format-patch shell quoting bug","startedAt":"2006-01-04T04:55:19Z","lastAt":"2006-01-07T19:16:40Z","messageCount":3,"participants":["Kyle McMartin","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"14160","messageId":"20060104045519.GB29515@quicksilver.road.mcmartin.ca","threadId":"2963","inReplyTo":null,"subject":"git format-patch shell quoting bug","fromName":"Kyle McMartin","fromEmail":"kyle@mcmartin.ca","sentAt":"2006-01-04T04:55:19Z","receivedAt":"2006-01-04T04:55:19Z","isPatch":false,"sender":{"key":"kyle@mcmartin.ca","avatar":"https://gravatar.com/avatar/25944564a544d96f427f89979e04107a70e5e70bddde2d0b095c9ea63a434fc9?d=mp&s=160"},"body":"Hi,\n\nThere's apparently a quoting bug in git-format-patch. When I import\na patch with apply-mbox, for example\n\nFrom: Carlos O'Donell <carlos@parisc-linux.org>\n\nThe author field is correctly set, including the \"'\" in Carlos' name.\n\nSo when I go to rebase my tree, or send out patches, I \n\"git-format-patch origin\" and get...\n\n/usr/bin/git-format-patch: eval: line 200: unexpected EOF while looking for \nmatching `''\n/usr/bin/git-format-patch: eval: line 201: syntax error: unexpected end of file\n\nWhich produces a bogus output patch with a blank From and Date,\n\nSubject: [PATCH] ...\nFrom:\nDate:\n\n[...]\n\nI believe this recently crept in, as I don't recall seeing it before.\n\nCheers,\n\tKyle\n"},{"id":"14224","messageId":"7vhd8gpxt3.fsf@assigned-by-dhcp.cox.net","threadId":"2963","inReplyTo":"20060104045519.GB29515@quicksilver.road.mcmartin.ca","subject":"Re: git format-patch shell quoting bug","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-01-07T02:38:16Z","receivedAt":"2006-01-07T02:38:16Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Kyle McMartin <kyle@mcmartin.ca> writes:\n\n> There's apparently a quoting bug in git-format-patch. When I import\n> a patch with apply-mbox, for example\n>\n> From: Carlos O'Donell <carlos@parisc-linux.org>\n>\n> The author field is correctly set, including the \"'\" in Carlos' name.\n> ...\n> I believe this recently crept in, as I don't recall seeing it before.\n\nThanks for spotting this.\n\nThere was a similar problem with \"git-commit -c\".  I think I got\nboth of them right with commit aa66c7:\n\n    commit aa66c7ec77d474b737da607d6cb2d07f56628def\n    Author: Junio C Hamano <junkio@cox.net>\n    Date:   Thu Jan 5 19:50:37 2006 -0800\n\n        format-patch/commit: Quote single quote in the author name properly.\n\n        Noticed by Kyle McMartin.\n\n        Signed-off-by: Junio C Hamano <junkio@cox.net>\n\nThe bug was present ever since format-patch started picking up\nthe original authorship information from the commits, done on\nJuly 22nd last year, between v0.99.1 and v0.99.2.\n"},{"id":"14257","messageId":"20060107191640.GD15084@quicksilver.road.mcmartin.ca","threadId":"2963","inReplyTo":"7vhd8gpxt3.fsf@assigned-by-dhcp.cox.net","subject":"Re: git format-patch shell quoting bug","fromName":"Kyle McMartin","fromEmail":"kyle@mcmartin.ca","sentAt":"2006-01-07T19:16:40Z","receivedAt":"2006-01-07T19:16:40Z","isPatch":false,"sender":{"key":"kyle@mcmartin.ca","avatar":"https://gravatar.com/avatar/25944564a544d96f427f89979e04107a70e5e70bddde2d0b095c9ea63a434fc9?d=mp&s=160"},"body":"On Fri, Jan 06, 2006 at 06:38:16PM -0800, Junio C Hamano wrote:\n>     commit aa66c7ec77d474b737da607d6cb2d07f56628def\n>     Author: Junio C Hamano <junkio@cox.net>\n>     Date:   Thu Jan 5 19:50:37 2006 -0800\n> \n>         format-patch/commit: Quote single quote in the author name properly.\n> \n>         Noticed by Kyle McMartin.\n> \n>         Signed-off-by: Junio C Hamano <junkio@cox.net>\n> \n> The bug was present ever since format-patch started picking up\n> the original authorship information from the commits, done on\n> July 22nd last year, between v0.99.1 and v0.99.2.\n>\n\nAwesome. Thanks very much for fixing this!\n\nCheers,\n\tKyle \n"}]}