{"thread":{"id":"29573","subject":"[PATCH v2] Explicitly set X to avoid potential build breakage","startedAt":"2012-02-08T10:59:04Z","lastAt":"2012-02-09T22:32:06Z","messageCount":2,"participants":["Michael","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"184184","messageId":"1974397.vopy2n9Vpb@telegraph","threadId":"29573","inReplyTo":null,"subject":"[PATCH v2] Explicitly set X to avoid potential build breakage","fromName":"Michael","fromEmail":"kensington@astralcloak.net","sentAt":"2012-02-08T10:59:04Z","receivedAt":"2012-02-08T10:59:04Z","isPatch":true,"sender":{"key":"kensington@astralcloak.net","avatar":null},"body":"$X is appended to binary names for Windows builds (ie. git.exe).\nPollution from the environment can inadvertently trigger this behaviour,\nresulting in 'git' turning into 'gitwhatever' without warning.\n\nSigned-off-by: Michael Palimaka <kensington@astralcloak.net>\n---\n Makefile |    3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 87fb30a..b21d40c 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -460,6 +460,9 @@ PROGRAM_OBJS += http-backend.o\n PROGRAM_OBJS += sh-i18n--envsubst.o\n PROGRAM_OBJS += credential-store.o\n \n+# Binary suffix used for Windows builds\n+X =\n+\n PROGRAMS += $(patsubst %.o,git-%$X,$(PROGRAM_OBJS))\n \n TEST_PROGRAMS_NEED_X += test-chmtime\n-- \n1.7.8.4\n"},{"id":"184278","messageId":"7vd39nvdsp.fsf@alter.siamese.dyndns.org","threadId":"29573","inReplyTo":"1974397.vopy2n9Vpb@telegraph","subject":"Re: [PATCH v2] Explicitly set X to avoid potential build breakage","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-02-09T22:32:06Z","receivedAt":"2012-02-09T22:32:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}