{"thread":{"id":"29519","subject":"I18N.pm is incompatible with perl < 5.8.3","startedAt":"2012-02-02T13:11:20Z","lastAt":"2012-03-16T16:14:27Z","messageCount":11,"participants":["Tom G. Christensen","Ævar Arnfjörð Bjarmason","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"183598","messageId":"4F2A8B78.6090902@statsbiblioteket.dk","threadId":"29519","inReplyTo":null,"subject":"I18N.pm is incompatible with perl < 5.8.3","fromName":"Tom G. Christensen","fromEmail":"tgc@statsbiblioteket.dk","sentAt":"2012-02-02T13:11:20Z","receivedAt":"2012-02-02T13:11:20Z","isPatch":false,"sender":{"key":"tgc@statsbiblioteket.dk","avatar":"https://avatars.githubusercontent.com/u/912180?v=4"},"body":"Hello,\n\nWhile running the git 1.7.9 testsuite on RHEL 3 with perl 5.8.0 and \ngettext 0.11.4 I got this error in t0202-gettext-perl.sh:\n# test_external test Perl Git::I18N API failed: /usr/bin/perl \n/builddir/build/BUILD/git-1.7.9/t/t0202/test.pl\n# test_external_without_stderr test no stderr: Perl Git::I18N API \nfailed: /usr/bin/perl /builddir/build/BUILD/git-1.7.9/t/t0202/test.pl:\n\nA verbose run gave me this:\n# test_external test Perl Git::I18N API failed: /usr/bin/perl \n/builddir/build/BUILD/git-1.7.9/t/t0202/test.pl\n# expecting no stderr from previous command\n# test_external_without_stderr test no stderr: Perl Git::I18N API \nfailed: /usr/bin/perl /builddir/build/BUILD/git-1.7.9/t/t0202/test.pl:\n# Stderr is:\n\"import\" is not exported by the Exporter module\nCan't continue after import errors at \n/builddir/build/BUILD/git-1.7.9/t/../perl/blib/lib/Git/I18N.pm line 5\nBEGIN failed--compilation aborted at \n/builddir/build/BUILD/git-1.7.9/t/../perl/blib/lib/Git/I18N.pm line 5.\nCompilation failed in require at \n/builddir/build/BUILD/git-1.7.9/t/t0202/test.pl line 8.\nBEGIN failed--compilation aborted at \n/builddir/build/BUILD/git-1.7.9/t/t0202/test.pl line 8.\n# Looks like your test died before it could output anything.\n\nI found the cause and the solution here:\nhttp://www.nntp.perl.org/group/perl.module.build/2008/02/msg1214.html\n\nI've changed\n  use Exporter 'import'\nto\n  BEGIN {\n   require Exporter;\n   *{import} = \\&Exporter::import;\n   }\nin I18N.pm.\n\nThe test now passes (GETTEXT_LOCALE=1):\n# lib-gettext: No is_IS UTF-8 locale available\n# lib-gettext: No is_IS ISO-8859-1 locale available\n# run 1: Perl Git::I18N API (/usr/bin/perl \n/builddir/build/BUILD/git-1.7.9/t/t0202/test.pl)\n1..8\nok 1 - Testing Git::I18N with NO Perl gettext library\nok 2 - Git::I18N is located at \n/builddir/build/BUILD/git-1.7.9/t/../perl/blib/lib/Git/I18N.pm\nok 3 - sanity: Git::I18N has 1 export(s)\nok 4 - sanity: Git::I18N exports everything by default\nok 5 - sanity: __ has a $ prototype\nok 6 - Passing a string through __() in the C locale works\nok 7 - Without a gettext library + <C> locale <TEST: A Perl test string> \nturns into <TEST: A Perl test string>\nok 8 - Without a gettext library + <is> locale <TEST: A Perl test \nstring> turns into <TEST: A Perl test string>\n# test_external test Perl Git::I18N API was ok\n# expecting no stderr from previous command\n# test_external_without_stderr test no stderr: Perl Git::I18N API was ok\n\n-tgc\n"},{"id":"183616","messageId":"CACBZZX5YuN8vpmTiP_38Aa=c3KDqEHCKBX3DE2YKkeMCdR4GBg@mail.gmail.com","threadId":"29519","inReplyTo":"4F2A8B78.6090902@statsbiblioteket.dk","subject":"Re: I18N.pm is incompatible with perl < 5.8.3","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2012-02-02T16:48:15Z","receivedAt":"2012-02-02T16:48:15Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Thu, Feb 2, 2012 at 14:11, Tom G. Christensen\n<tgc@statsbiblioteket.dk> wrote:\n> Hello,\n>\n\nThanks Tom, I'll submit a patch for that. Does this work, i.e. does\n5.8.3 need *{import} = instead of *import = ?\n\n    diff --git a/perl/Git/I18N.pm b/perl/Git/I18N.pm\n    index 07597dc..5bcfed5 100644\n    --- a/perl/Git/I18N.pm\n    +++ b/perl/Git/I18N.pm\n    @@ -2,7 +2,16 @@ package Git::I18N;\n     use 5.008;\n     use strict;\n     use warnings;\n    -use Exporter 'import';\n    +BEGIN {\n    +       require Exporter;\n    +       if ($] < 5.008003) {\n    +               *import = \\&Exporter::import;\n    +       } else {\n    +               # Exporter 5.57 supporting this invocation was released with\n    +               # 5.8.3\n    +               Exporter->import('import');\n    +       }\n    +}\n\n     our @EXPORT = qw(__);\n     our @EXPORT_OK = @EXPORT;\n\nBut actually it might be better to check $Exporter::VERSION\n"},{"id":"183668","messageId":"4F2AFED3.6090605@statsbiblioteket.dk","threadId":"29519","inReplyTo":"CACBZZX5YuN8vpmTiP_38Aa=c3KDqEHCKBX3DE2YKkeMCdR4GBg@mail.gmail.com","subject":"Re: I18N.pm is incompatible with perl < 5.8.3","fromName":"Tom G. Christensen","fromEmail":"tgc@statsbiblioteket.dk","sentAt":"2012-02-02T21:23:31Z","receivedAt":"2012-02-02T21:23:31Z","isPatch":false,"sender":{"key":"tgc@statsbiblioteket.dk","avatar":"https://avatars.githubusercontent.com/u/912180?v=4"},"body":"Ævar Arnfjörð Bjarmason wrote:\n> On Thu, Feb 2, 2012 at 14:11, Tom G. Christensen\n> <tgc@statsbiblioteket.dk> wrote:\n>> Hello,\n>>\n> \n> Thanks Tom, I'll submit a patch for that. Does this work, i.e. does\n> 5.8.3 need *{import} = instead of *import = ?\n> \n<snip>\nI applied the patch and have run the test with perl 5.8.0 (el3) and \n5.8.5 (el4) and it passes the test on both versions.\n\nI noticed an additional problem which is that Git/I18N.pm is not \ninstalled when NO_PERL_MAKEMAKER is used.\nIt looks like perl/Makefile did not get updated when Git/I18N.pm was \nadded to perl/Makefile.PL.\n\nIn perl 5.8.0 ExtUtils::MakeMaker is too old (6.03) to be used with \nperl/Makefile.PL.\n\n-tgc\n"},{"id":"186308","messageId":"4F575B16.9050801@statsbiblioteket.dk","threadId":"29519","inReplyTo":"CACBZZX5YuN8vpmTiP_38Aa=c3KDqEHCKBX3DE2YKkeMCdR4GBg@mail.gmail.com","subject":"Re: I18N.pm is incompatible with perl < 5.8.3","fromName":"Tom G. Christensen","fromEmail":"tgc@statsbiblioteket.dk","sentAt":"2012-03-07T12:56:54Z","receivedAt":"2012-03-07T12:56:54Z","isPatch":false,"sender":{"key":"tgc@statsbiblioteket.dk","avatar":"https://avatars.githubusercontent.com/u/912180?v=4"},"body":"Ævar Arnfjörð Bjarmason wrote:\n> On Thu, Feb 2, 2012 at 14:11, Tom G. Christensen\n> <tgc@statsbiblioteket.dk> wrote:\n>> Hello,\n>>\n> \n> Thanks Tom, I'll submit a patch for that. \n\nNothing seems to have been submitted and both this issue and the issue \nwith missing NO_PERL_MAKEMAKER support still exists in 1.7.9.3.\n\nI think I've answered your question but please just ask if you need more \ninformation from me.\n\n-tgc\n"},{"id":"186336","messageId":"CACBZZX5wHEigiYjn6ahmnXN3wd9sEyDnRV2EZiP+JSUCc182TQ@mail.gmail.com","threadId":"29519","inReplyTo":"4F575B16.9050801@statsbiblioteket.dk","subject":"Re: I18N.pm is incompatible with perl < 5.8.3","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2012-03-07T20:53:54Z","receivedAt":"2012-03-07T20:53:54Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Wed, Mar 7, 2012 at 13:56, Tom G. Christensen\n<tgc@statsbiblioteket.dk> wrote:\n> Ævar Arnfjörð Bjarmason wrote:\n>>\n>> On Thu, Feb 2, 2012 at 14:11, Tom G. Christensen\n>> <tgc@statsbiblioteket.dk> wrote:\n>>>\n>>> Hello,\n>>>\n>>\n>> Thanks Tom, I'll submit a patch for that.\n>\n>\n> Nothing seems to have been submitted and both this issue and the issue with\n> missing NO_PERL_MAKEMAKER support still exists in 1.7.9.3.\n>\n> I think I've answered your question but please just ask if you need more\n> information from me.\n\nSorry about that. I'll submit a patch this week or this weekend. That\nNO_PERL_MAKEMAKER issue is also either fixed by now or I'll fix it.\n"},{"id":"186623","messageId":"1331382575-16936-1-git-send-email-avarab@gmail.com","threadId":"29519","inReplyTo":"CACBZZX5wHEigiYjn6ahmnXN3wd9sEyDnRV2EZiP+JSUCc182TQ@mail.gmail.com","subject":"[PATCH 0/2] Minor fixes for Perl + Git::I18N","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2012-03-10T12:29:33Z","receivedAt":"2012-03-10T12:29:33Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"This minor series fixes the Perl issues raised by Tom\nChristensen. Since it shouldn't break anything I hope this can make it\ninto 1.7.10, but that's up to Junio.\n\nÆvar Arnfjörð Bjarmason (2):\n  Git::I18N: compatibility with perl <5.8.3\n  perl/Makefile: install Git::I18N under NO_PERL_MAKEMAKER\n\n perl/Git/I18N.pm |   11 ++++++++++-\n perl/Makefile    |    7 ++++++-\n 2 files changed, 16 insertions(+), 2 deletions(-)\n\n-- \n1.7.9\n"},{"id":"186622","messageId":"1331382575-16936-2-git-send-email-avarab@gmail.com","threadId":"29519","inReplyTo":"1331382575-16936-1-git-send-email-avarab@gmail.com","subject":"[PATCH 1/2] Git::I18N: compatibility with perl <5.8.3","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2012-03-10T12:29:34Z","receivedAt":"2012-03-10T12:29:34Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Change the Exporter invocation in Git::I18N to be compatible with\n5.8.0 to 5.8.2 inclusive. Before Exporter 5.57 (released with 5.8.3)\nExporter didn't export the 'import' subroutine.\n\nReported-by: Tom G. Christensen <tgc@statsbiblioteket.dk>\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n perl/Git/I18N.pm |   11 ++++++++++-\n 1 files changed, 10 insertions(+), 1 deletions(-)\n\ndiff --git a/perl/Git/I18N.pm b/perl/Git/I18N.pm\nindex 07597dc..40dd897 100644\n--- a/perl/Git/I18N.pm\n+++ b/perl/Git/I18N.pm\n@@ -2,7 +2,16 @@ package Git::I18N;\n use 5.008;\n use strict;\n use warnings;\n-use Exporter 'import';\n+BEGIN {\n+\trequire Exporter;\n+\tif ($] < 5.008003) {\n+\t\t*import = \\&Exporter::import;\n+\t} else {\n+\t\t# Exporter 5.57 which supports this invocation was\n+\t\t# released with perl 5.8.3\n+\t\tExporter->import('import');\n+\t}\n+}\n \n our @EXPORT = qw(__);\n our @EXPORT_OK = @EXPORT;\n-- \n1.7.9\n"},{"id":"186624","messageId":"1331382575-16936-3-git-send-email-avarab@gmail.com","threadId":"29519","inReplyTo":"1331382575-16936-1-git-send-email-avarab@gmail.com","subject":"[PATCH 2/2] perl/Makefile: install Git::I18N under NO_PERL_MAKEMAKER","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2012-03-10T12:29:35Z","receivedAt":"2012-03-10T12:29:35Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"When I added the i18n infrastructure in v1.7.8-rc2-1-g5e9637c I forgot\nto install Git::I18N also when NO_PERL_MAKEMAKER=YesPlease was\nset. Change the generation of the fallback perl.mak file to do that.\n\nNow Git/I18N.pm is installed alongside Git.pm in such a way that\nanything that uses GITPERLLIB will find it.\n\nReported-by: Tom G. Christensen <tgc@statsbiblioteket.dk>\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n perl/Makefile |    7 ++++++-\n 1 files changed, 6 insertions(+), 1 deletions(-)\n\ndiff --git a/perl/Makefile b/perl/Makefile\nindex b2977cd..9af9025 100644\n--- a/perl/Makefile\n+++ b/perl/Makefile\n@@ -23,20 +23,25 @@ clean:\n ifdef NO_PERL_MAKEMAKER\n instdir_SQ = $(subst ','\\'',$(prefix)/lib)\n $(makfile): ../GIT-CFLAGS Makefile\n-\techo all: private-Error.pm Git.pm > $@\n+\techo all: private-Error.pm Git.pm Git/I18N.pm > $@\n \techo '\tmkdir -p blib/lib' >> $@\n+\techo '\tmkdir -p blib/lib/Git' >> $@\n \techo '\t$(RM) blib/lib/Git.pm; cp Git.pm blib/lib/' >> $@\n+\techo '\t$(RM) blib/lib/Git/I18N.pm; cp Git/I18N.pm blib/lib/Git/' >> $@\n \techo '\t$(RM) blib/lib/Error.pm' >> $@\n \t'$(PERL_PATH_SQ)' -MError -e 'exit($$Error::VERSION < 0.15009)' || \\\n \techo '\tcp private-Error.pm blib/lib/Error.pm' >> $@\n \techo install: >> $@\n \techo '\tmkdir -p \"$$(DESTDIR)$(instdir_SQ)\"' >> $@\n+\techo '\tmkdir -p \"$$(DESTDIR)$(instdir_SQ)/Git\"' >> $@\n \techo '\t$(RM) \"$$(DESTDIR)$(instdir_SQ)/Git.pm\"; cp Git.pm \"$$(DESTDIR)$(instdir_SQ)\"' >> $@\n+\techo '\t$(RM) \"$$(DESTDIR)$(instdir_SQ)/Git/I18N.pm\"; cp Git/I18N.pm \"$$(DESTDIR)$(instdir_SQ)/Git\"' >> $@\n \techo '\t$(RM) \"$$(DESTDIR)$(instdir_SQ)/Error.pm\"' >> $@\n \t'$(PERL_PATH_SQ)' -MError -e 'exit($$Error::VERSION < 0.15009)' || \\\n \techo '\tcp private-Error.pm \"$$(DESTDIR)$(instdir_SQ)/Error.pm\"' >> $@\n \techo instlibdir: >> $@\n \techo '\techo $(instdir_SQ)' >> $@\n+\techo '\techo $(instdir_SQ)/Git' >> $@\n else\n $(makfile): Makefile.PL ../GIT-CFLAGS\n \t$(PERL_PATH) $< PREFIX='$(prefix_SQ)' INSTALL_BASE='' --localedir='$(localedir_SQ)'\n-- \n1.7.9\n"},{"id":"186631","messageId":"7vfwdg16i8.fsf@alter.siamese.dyndns.org","threadId":"29519","inReplyTo":"1331382575-16936-3-git-send-email-avarab@gmail.com","subject":"Re: [PATCH 2/2] perl/Makefile: install Git::I18N under NO_PERL_MAKEMAKER","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-03-10T21:38:23Z","receivedAt":"2012-03-10T21:38:23Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:\n\n> When I added the i18n infrastructure in v1.7.8-rc2-1-g5e9637c I forgot\n> to install Git::I18N also when NO_PERL_MAKEMAKER=YesPlease was\n> set. Change the generation of the fallback perl.mak file to do that.\n>\n> Now Git/I18N.pm is installed alongside Git.pm in such a way that\n> anything that uses GITPERLLIB will find it.\n>\n> Reported-by: Tom G. Christensen <tgc@statsbiblioteket.dk>\n> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n> ---\n>  perl/Makefile |    7 ++++++-\n>  1 files changed, 6 insertions(+), 1 deletions(-)\n>\n> diff --git a/perl/Makefile b/perl/Makefile\n> index b2977cd..9af9025 100644\n> --- a/perl/Makefile\n> +++ b/perl/Makefile\n> @@ -23,20 +23,25 @@ clean:\n>  ifdef NO_PERL_MAKEMAKER\n>  instdir_SQ = $(subst ','\\'',$(prefix)/lib)\n>  $(makfile): ../GIT-CFLAGS Makefile\n> -\techo all: private-Error.pm Git.pm > $@\n> +\techo all: private-Error.pm Git.pm Git/I18N.pm > $@\n>  \techo '\tmkdir -p blib/lib' >> $@\n> +\techo '\tmkdir -p blib/lib/Git' >> $@\n\nmicronit; the previous line can be removed.\n\n>  \techo '\t$(RM) blib/lib/Git.pm; cp Git.pm blib/lib/' >> $@\n> +\techo '\t$(RM) blib/lib/Git/I18N.pm; cp Git/I18N.pm blib/lib/Git/' >> $@\n>  \techo '\t$(RM) blib/lib/Error.pm' >> $@\n>  \t'$(PERL_PATH_SQ)' -MError -e 'exit($$Error::VERSION < 0.15009)' || \\\n>  \techo '\tcp private-Error.pm blib/lib/Error.pm' >> $@\n>  \techo install: >> $@\n>  \techo '\tmkdir -p \"$$(DESTDIR)$(instdir_SQ)\"' >> $@\n> +\techo '\tmkdir -p \"$$(DESTDIR)$(instdir_SQ)/Git\"' >> $@\n>  \techo '\t$(RM) \"$$(DESTDIR)$(instdir_SQ)/Git.pm\"; cp Git.pm \"$$(DESTDIR)$(instdir_SQ)\"' >> $@\n> +\techo '\t$(RM) \"$$(DESTDIR)$(instdir_SQ)/Git/I18N.pm\"; cp Git/I18N.pm \"$$(DESTDIR)$(instdir_SQ)/Git\"' >> $@\n>  \techo '\t$(RM) \"$$(DESTDIR)$(instdir_SQ)/Error.pm\"' >> $@\n>  \t'$(PERL_PATH_SQ)' -MError -e 'exit($$Error::VERSION < 0.15009)' || \\\n>  \techo '\tcp private-Error.pm \"$$(DESTDIR)$(instdir_SQ)/Error.pm\"' >> $@\n>  \techo instlibdir: >> $@\n>  \techo '\techo $(instdir_SQ)' >> $@\n> +\techo '\techo $(instdir_SQ)/Git' >> $@\n\nThis break \"make NO_PERL_MAKEMAKER=Nah git-add--interactive\", or\nanything that is a perl script, it appears.\n\nThe resulting perl/perl.mak ends with\n\n\tinstlibdir:\n                echo foo\n                echo foo/Git\n\nbut the top-level Makefile wants to see output from\n\n\tmake instlibdir\n\nin this directory as a single line in this rule:\n\n$(patsubst %.perl,%,$(SCRIPT_PERL)): % : %.perl\n\t$(QUIET_GEN)$(RM) $@ $@+ && \\\n\tINSTLIBDIR=`MAKEFLAGS= $(MAKE) -C perl -s --no-print-directory instlibdir` && \\\n\techo \"<$$INSTLIBDIR>\" && \\\n\tsed -e '1{' \\\n\t    -e '\ts|#!.*perl|#!$(PERL_PATH_SQ)|' \\\n\t    -e '\th' \\\n\t    -e '\ts=.*=use lib (split(/$(pathsep)/, $$ENV{GITPERLLIB} || \"'\"$$INSTLIBDIR\"'\"));=' \\\n\t    -e '\tH' \\\n\t    -e '\tx' \\\n\t    -e '}' \\\n\t    -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \\\n\t    $@.perl >$@+ && \\\n"},{"id":"186664","messageId":"CACBZZX47hAF_ayaa_QBrGcOkZ9UpR0Uxm-4Hf=FB685OKKvYFw@mail.gmail.com","threadId":"29519","inReplyTo":"7vfwdg16i8.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 2/2] perl/Makefile: install Git::I18N under NO_PERL_MAKEMAKER","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2012-03-11T19:27:50Z","receivedAt":"2012-03-11T19:27:50Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Sat, Mar 10, 2012 at 22:38, Junio C Hamano <gitster@pobox.com> wrote:\n>>       echo '  $(RM) blib/lib/Git.pm; cp Git.pm blib/lib/' >> $@\n>> +     echo '  $(RM) blib/lib/Git/I18N.pm; cp Git/I18N.pm blib/lib/Git/' >> $@\n>>       echo '  $(RM) blib/lib/Error.pm' >> $@\n>>       '$(PERL_PATH_SQ)' -MError -e 'exit($$Error::VERSION < 0.15009)' || \\\n>>       echo '  cp private-Error.pm blib/lib/Error.pm' >> $@\n>>       echo install: >> $@\n>>       echo '  mkdir -p \"$$(DESTDIR)$(instdir_SQ)\"' >> $@\n>> +     echo '  mkdir -p \"$$(DESTDIR)$(instdir_SQ)/Git\"' >> $@\n>>       echo '  $(RM) \"$$(DESTDIR)$(instdir_SQ)/Git.pm\"; cp Git.pm \"$$(DESTDIR)$(instdir_SQ)\"' >> $@\n>> +     echo '  $(RM) \"$$(DESTDIR)$(instdir_SQ)/Git/I18N.pm\"; cp Git/I18N.pm \"$$(DESTDIR)$(instdir_SQ)/Git\"' >> $@\n>>       echo '  $(RM) \"$$(DESTDIR)$(instdir_SQ)/Error.pm\"' >> $@\n>>       '$(PERL_PATH_SQ)' -MError -e 'exit($$Error::VERSION < 0.15009)' || \\\n>>       echo '  cp private-Error.pm \"$$(DESTDIR)$(instdir_SQ)/Error.pm\"' >> $@\n>>       echo instlibdir: >> $@\n>>       echo '  echo $(instdir_SQ)' >> $@\n>> +     echo '  echo $(instdir_SQ)/Git' >> $@\n>\n> This break \"make NO_PERL_MAKEMAKER=Nah git-add--interactive\", or\n> anything that is a perl script, it appears.\n>\n> The resulting perl/perl.mak ends with\n>\n>        instlibdir:\n>                echo foo\n>                echo foo/Git\n>\n> but the top-level Makefile wants to see output from\n>\n>        make instlibdir\n\nFail, I just tested installing it to /tmp. Sorry about that.\n"},{"id":"187100","messageId":"7v62e4ikv0.fsf@alter.siamese.dyndns.org","threadId":"29519","inReplyTo":"CACBZZX47hAF_ayaa_QBrGcOkZ9UpR0Uxm-4Hf=FB685OKKvYFw@mail.gmail.com","subject":"Re: [PATCH 2/2] perl/Makefile: install Git::I18N under NO_PERL_MAKEMAKER","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-03-16T16:14:27Z","receivedAt":"2012-03-16T16:14:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"This topic has been stuck for almost a week.\n\n    * ab/perl-i18n (2012-03-10) 3 commits\n     - fixup! de1e4ae\n     - perl/Makefile: install Git::I18N under NO_PERL_MAKEMAKER\n     - Git::I18N: compatibility with perl <5.8.3\n\nI just ran (including the fixup patch queued at the tip) this:\n\n    $ PATH=/usr/bin:/bin ;# I do not have any \"git\" in these two places\n    $ export PATH\n    $ make NO_PERL_MAKEMAKER=NoThanks prefix=/tmp/no-perl-makemaker\n    $ make NO_PERL_MAKEMAKER=NoThanks prefix=/tmp/no-perl-makemaker install\n\n    $ head -n 2 /tmp/no-perl-makemaker/libexec/git-core/git-difftool\n    #!/usr/bin/perl\n    use lib (split(/:/, $ENV{GITPERLLIB} || \"/tmp/no-perl-makemaker/lib\"));\n    $ ls -l /tmp/no-perl-makemaker/lib\n    total 44\n    drwxrwxr-x 2 junio junio  4096 Mar 16 09:06 Git\n    -rw-rw-r-- 1 junio junio 36222 Mar 16 09:06 Git.pm\n    drwxrwxr-x 3 junio junio  4096 Mar 16 09:06 python2.6\n\nAnd the resulting perl-ish Porcelain seems to work OK.\n\n    $ PATH=$PATH:/tmp/no-perl-makemaker/bin\n    $ git add -i\n\nSo I'll be merging this (after squashing the fix-up) to master.\n"}]}