{"thread":{"id":"29503","subject":"[PATCH] i18n: diff/apply statistics","startedAt":"2012-02-01T17:22:57Z","lastAt":"2012-02-03T01:28:02Z","messageCount":5,"participants":["Jiang Xin","Nguyen Thai Ngoc Duy"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"183485","messageId":"1328116977-61458-1-git-send-email-worldhello.net@gmail.com","threadId":"29503","inReplyTo":null,"subject":"[PATCH] i18n: diff/apply statistics","fromName":"Jiang Xin","fromEmail":"worldhello.net@gmail.com","sentAt":"2012-02-01T17:22:57Z","receivedAt":"2012-02-01T17:22:57Z","isPatch":true,"sender":{"key":"worldhello.net@gmail.com","avatar":"https://avatars.githubusercontent.com/u/183860?v=4"},"body":"translate oneline statistics of diff/apply.\n\nSigned-off-by: Jiang Xin \n---\n builtin/apply.c | 2 +-\n diff.c | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/builtin/apply.c b/builtin/apply.c\nindex c24d..e289e 100644\n--- a/builtin/apply.c\n+++ b/builtin/apply.c\n@@ -3241,7 +3241,7 @@ static void stat_patch_list(struct patch *patch)\n \t\tshow_stats(patch);\n \t}\n \n-\tprintf(\" %d files changed, %d insertions(+), %d deletions(-)\\n\", files, adds, dels);\n+\tprintf(_(\" %d files changed, %d insertions(+), %d deletions(-)\\n\"), files, adds, dels);\n }\n \n static void numstat_patch_list(struct patch *patch)\ndiff --git a/diff.c b/diff.c\nindex 7e1542..b9115 100644\n--- a/diff.c\n+++ b/diff.c\n@@ -1476,7 +1476,7 @@ static void show_stats(struct diffstat_t *data, struct diff_options *options)\n \t}\n \tfprintf(options->file, \"%s\", line_prefix);\n \tfprintf(options->file,\n-\t \" %d files changed, %d insertions(+), %d deletions(-)\\n\",\n+\t _(\" %d files changed, %d insertions(+), %d deletions(-)\\n\"),\n \t total_files, adds, dels);\n }\n \n@@ -1507,7 +1507,7 @@ static void show_shortstats(struct diffstat_t *data, struct diff_options *option\n \t\t\t\toptions->output_prefix_data);\n \t\tfprintf(options->file, \"%s\", msg->buf);\n \t}\n-\tfprintf(options->file, \" %d files changed, %d insertions(+), %d deletions(-)\\n\",\n+\tfprintf(options->file, _(\" %d files changed, %d insertions(+), %d deletions(-)\\n\"),\n \t total_files, adds, dels);\n }\n \n-- \n1.7.9.3.g1fbd7\n"},{"id":"183605","messageId":"CACsJy8DrNHwLGJjj4nJHDm-NEsr6c=QW-kgxmTbsRxq057keWQ@mail.gmail.com","threadId":"29503","inReplyTo":"1328116977-61458-1-git-send-email-worldhello.net@gmail.com","subject":"Re: [PATCH] i18n: diff/apply statistics","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2012-02-02T14:40:01Z","receivedAt":"2012-02-02T14:40:01Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Thu, Feb 2, 2012 at 12:22 AM, Jiang Xin wrote:\n> translate oneline statistics of diff/apply.\n\nThere's another patch with similar goal:\n\nhttp://thread.gmane.org/gmane.comp.version-control.git/189453/focus=189509\n-- \nDuy\n"},{"id":"183686","messageId":"CANYiYbFBDtK5SiYZV41vWxjjQw3GT4+9kcESpV69sNDWgZ26QQ@mail.gmail.com","threadId":"29503","inReplyTo":"CACsJy8DrNHwLGJjj4nJHDm-NEsr6c=QW-kgxmTbsRxq057keWQ@mail.gmail.com","subject":"Re: [PATCH] i18n: diff/apply statistics","fromName":"Jiang Xin","fromEmail":"worldhello.net@gmail.com","sentAt":"2012-02-03T01:15:11Z","receivedAt":"2012-02-03T01:15:11Z","isPatch":true,"sender":{"key":"worldhello.net@gmail.com","avatar":"https://avatars.githubusercontent.com/u/183860?v=4"},"body":"2012/2/2 Nguyen Thai Ngoc Duy :\n> On Thu, Feb 2, 2012 at 12:22 AM, Jiang Xin wrote:\n>> translate oneline statistics of diff/apply.\n>\n> There's another patch with similar goal:\n>\n> http://thread.gmane.org/gmane.comp.version-control.git/189453/focus=189509\n\nIt's cool, especially the call of interactive_use, so that\ntranslations for the statistics line is only for human, not for scripts/pipe...\n\n--\nJiang Xin\n"},{"id":"183688","messageId":"CANYiYbHtJMw25ZDbYRbe8S_GM-gR6okkDwwNXo_yxPhPrHQp+w@mail.gmail.com","threadId":"29503","inReplyTo":"CACsJy8DfdTPfwZJq1_=RzO_f67FoLGJ1Q__Qfqtg+HxKZEMp4g@mail.gmail.com","subject":"Re: [PATCH] i18n: diff/apply statistics","fromName":"Jiang Xin","fromEmail":"worldhello.net@gmail.com","sentAt":"2012-02-03T01:23:42Z","receivedAt":"2012-02-03T01:23:42Z","isPatch":true,"sender":{"key":"worldhello.net@gmail.com","avatar":"https://avatars.githubusercontent.com/u/183860?v=4"},"body":"2012/2/3 Nguyen Thai Ngoc Duy :\n> On Fri, Feb 3, 2012 at 8:12 AM, Jiang Xin wrote:\n>> 2012/2/2 Nguyen Thai Ngoc Duy :\n>>>\n>>> There's another patch with similar goal:\n>>>\n>>> http://thread.gmane.org/gmane.comp.version-control.git/189453/focus=189509\n>>\n>> It's cool, especially the call of interactive_use, so that\n>> translations for the statistics line is only for human, not for scripts/pipe...\n>\n> That's the idea but they decided to allow translations unconditionally\n> in the end.\n\nOhh, sad, not so cool. Are there any reasons?\n\n-- \nJiang Xin\n"},{"id":"183690","messageId":"CACsJy8BksBhzu2cHNEr5S7u7dhsavBHm9e6fnPvdD31sr_d+gw@mail.gmail.com","threadId":"29503","inReplyTo":"CANYiYbHtJMw25ZDbYRbe8S_GM-gR6okkDwwNXo_yxPhPrHQp+w@mail.gmail.com","subject":"Re: [PATCH] i18n: diff/apply statistics","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2012-02-03T01:28:02Z","receivedAt":"2012-02-03T01:28:02Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Fri, Feb 3, 2012 at 8:23 AM, Jiang Xin wrote:\n> 2012/2/3 Nguyen Thai Ngoc Duy :\n>> On Fri, Feb 3, 2012 at 8:12 AM, Jiang Xin wrote:\n>>> 2012/2/2 Nguyen Thai Ngoc Duy :\n>>>>\n>>>> There's another patch with similar goal:\n>>>>\n>>>> http://thread.gmane.org/gmane.comp.version-control.git/189453/focus=189509\n>>>\n>>> It's cool, especially the call of interactive_use, so that\n>>> translations for the statistics line is only for human, not for scripts/pipe...\n>>\n>> That's the idea but they decided to allow translations unconditionally\n>> in the end.\n>\n> Ohh, sad, not so cool. Are there any reasons?\n>\n\nInconsistency mainly. I don't see anything sad about that though. You\nshould read that thread.\n-- \nDuy\n"}]}