{"thread":{"id":"29454","subject":"git-gui Ctrl-U (unstage) broken","startedAt":"2012-01-27T14:03:03Z","lastAt":"2012-02-06T16:48:51Z","messageCount":5,"participants":["Victor Engmark","Pat Thoyts","Clemens Buchacher","Phil Hord","Stefan Haller"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"183188","messageId":"CAA5Ydx-mi7i7mWDYO=Cbw4g1b7LR0hw4Tcqe9gMtBoCkDRuvYA@mail.gmail.com","threadId":"29454","inReplyTo":null,"subject":"git-gui Ctrl-U (unstage) broken","fromName":"Victor Engmark","fromEmail":"victor.engmark@gmail.com","sentAt":"2012-01-27T14:03:03Z","receivedAt":"2012-01-27T14:03:03Z","isPatch":false,"sender":{"key":"victor.engmark@gmail.com","avatar":"https://gravatar.com/avatar/5d7b4229a48f2ed011a265c19a1881c4ee58946449215db6627373a244c8aa4c?d=mp&s=160"},"body":"Using the git-gui available with the default Ubuntu 10.10 repos, I'm\nnot able to unstage files with the default keyboard shortcut. To\nreproduce:\n1. Change a file in the repository\n2. Run `git gui`\n3. Stage the changed file\n4. Select the changed file in the \"Staged Changes (Will Commit)\" list\n5. Click Ctrl-U\n\nExpected outcome: The selected file should be unstaged.\n\nActual outcome: Nothing at all changes in the GUI.\n\nVerified that other keyboard shortcuts work: Ctrl-T, Ctrl-I, Ctrl--,\nCtrl-+, F5. These (except Ctrl-T, obviously) were tested in* both the\n\"Unstaged Changes\" and \"Staged Changes (Will Commit)\" listsp\n\n* That is, after focusing a single element in that list.\n\nVersion info:\n\ngit-gui version 0.12.0.64.g89d6\ngit version 1.7.1\n\nTcl/Tk version 8.5.8\nAspell 0.60.6, en_US\n\nCheers,\nV\n"},{"id":"183265","messageId":"877h0at7ua.fsf@fox.patthoyts.tk","threadId":"29454","inReplyTo":"CAA5Ydx-mi7i7mWDYO=Cbw4g1b7LR0hw4Tcqe9gMtBoCkDRuvYA@mail.gmail.com","subject":"Re: git-gui Ctrl-U (unstage) broken","fromName":"Pat Thoyts","fromEmail":"patthoyts@users.sourceforge.net","sentAt":"2012-01-29T23:19:41Z","receivedAt":"2012-01-29T23:19:41Z","isPatch":false,"sender":{"key":"patthoyts@users.sourceforge.net","avatar":"https://avatars.githubusercontent.com/u/30739?v=4"},"body":"Victor Engmark writes:\n\n>Using the git-gui available with the default Ubuntu 10.10 repos, I'm\n>not able to unstage files with the default keyboard shortcut. To\n>reproduce:\n>1. Change a file in the repository\n>2. Run `git gui`\n>3. Stage the changed file\n>4. Select the changed file in the \"Staged Changes (Will Commit)\" list\n>5. Click Ctrl-U\n>\n>Expected outcome: The selected file should be unstaged.\n>\n>Actual outcome: Nothing at all changes in the GUI.\n>\n>Verified that other keyboard shortcuts work: Ctrl-T, Ctrl-I, Ctrl--,\n>Ctrl-+, F5. These (except Ctrl-T, obviously) were tested in* both the\n>\"Unstaged Changes\" and \"Staged Changes (Will Commit)\" listsp\n>\n>* That is, after focusing a single element in that list.\n>\n>Version info:\n>\n>git-gui version 0.12.0.64.g89d6\n>git version 1.7.1\n>\n>Tcl/Tk version 8.5.8\n>Aspell 0.60.6, en_US\n\nI checked this with the current version (gitgui-0.16.0) and it works ok\nfor me (on windows) - ie: ctrl-u unstaged a selected file.\n-- \nPat Thoyts http://www.patthoyts.tk/\nPGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD\n"},{"id":"183369","messageId":"20120130192223.GA21444@ecki","threadId":"29454","inReplyTo":"877h0at7ua.fsf@fox.patthoyts.tk","subject":"Re: git-gui Ctrl-U (unstage) broken","fromName":"Clemens Buchacher","fromEmail":"drizzd@aon.at","sentAt":"2012-01-30T19:22:24Z","receivedAt":"2012-01-30T19:22:24Z","isPatch":false,"sender":{"key":"drizzd@gmx.net","avatar":"https://avatars.githubusercontent.com/u/59082?v=4"},"body":"Hi Victor,\n\nVictor Engmark writes:\n>\n> Version info:\n> \n> git-gui version 0.12.0.64.g89d6\n> git version 1.7.1\n> \n> Tcl/Tk version 8.5.8\n> Aspell 0.60.6, en_US\n\nI could reproduce this issue on my Fedora 14 box at dayjob with the\ngit-gui package that corresponds to git version 1.7.4.4 (git-gui version\n0.13.0.8.g8f855 according to git.git).\n\nBut I cannot reproduce with the current git version or even with git\n1.7.1 and git-gui 0.12.0.64.g89d6 on my Arch Linux box, where I have\nTcl/Tk version 8.5.11.\n\nI have to check which Tcl/Tk version the F14 box uses. But the bug does\nnot seem to depend on the git gui version. Have you tried upgrading\nTcl/Tk?\n\nClemens\n"},{"id":"183384","messageId":"CABURp0qVOJXbF=GP=e62P=Lbe7+93jA_axhxNJfp85kJYo6t7A@mail.gmail.com","threadId":"29454","inReplyTo":"20120130192223.GA21444@ecki","subject":"Re: git-gui Ctrl-U (unstage) broken","fromName":"Phil Hord","fromEmail":"phil.hord@gmail.com","sentAt":"2012-01-30T20:50:25Z","receivedAt":"2012-01-30T20:50:25Z","isPatch":false,"sender":{"key":"phil.hord@gmail.com","avatar":"https://avatars.githubusercontent.com/u/123908?v=4"},"body":"On Mon, Jan 30, 2012 at 2:22 PM, Clemens Buchacher wrote:\n> I could reproduce this issue on my Fedora 14 box at dayjob with the\n> git-gui package that corresponds to git version 1.7.4.4 (git-gui version\n> 0.13.0.8.g8f855 according to git.git).\n>\n> But I cannot reproduce with the current git version or even with git\n> 1.7.1 and git-gui 0.12.0.64.g89d6 on my Arch Linux box, where I have\n> Tcl/Tk version 8.5.11.\n>\n> I have to check which Tcl/Tk version the F14 box uses. But the bug does\n> not seem to depend on the git gui version. Have you tried upgrading\n> Tcl/Tk?\n\nI haven't tried anything to fix this, but I'll add some data points.\n\n* Ctrl-T / Ctrl-U Ctrl-J have never worked reliably for me on Ubuntu/Gnome.\n\n* Ctrl-A does not work for \"Remote > Add...\" since it performs \"Edit\n> Select All\" instead\n\nAll the other combos I tried work ok.\n\nMaybe the last one is a clue, though I can't think what Ctrl-T might\nbe assigned to, and it's not listed in the menus as being assigned to\nanything else. But maybe the works-ness of it is related to the\nwindow focus.\n\nPhil\n"},{"id":"184033","messageId":"1kf1ynj.18kgomh1crpruyM%lists@haller-berlin.de","threadId":"29454","inReplyTo":"877h0at7ua.fsf@fox.patthoyts.tk","subject":"Re: git-gui Ctrl-U (unstage) broken","fromName":"Stefan Haller","fromEmail":"lists@haller-berlin.de","sentAt":"2012-02-06T16:48:51Z","receivedAt":"2012-02-06T16:48:51Z","isPatch":false,"sender":{"key":"lists@haller-berlin.de","avatar":null},"body":"Pat Thoyts wrote:\n\n> Victor Engmark writes:\n> \n> >Using the git-gui available with the default Ubuntu 10.10 repos, I'm\n> >not able to unstage files with the default keyboard shortcut. To\n> >reproduce:\n> >1. Change a file in the repository\n> >2. Run `git gui`\n> >3. Stage the changed file\n> >4. Select the changed file in the \"Staged Changes (Will Commit)\" list\n> >5. Click Ctrl-U\n> >\n> >Expected outcome: The selected file should be unstaged.\n> >\n> >Actual outcome: Nothing at all changes in the GUI.\n> \n> I checked this with the current version (gitgui-0.16.0) and it works ok\n> for me (on windows) - ie: ctrl-u unstaged a selected file.\n\nPat, it depends on where the focus is when you press ctrl-u. If you\nclick in the diff pane, and then select the file to unstage, and then\npress ctrl-u, then nothing happens. If you click in the commit message\nfield, then ctrl-u works fine.\n\nThe same problem exists with ctrl-j for \"Revert Changes\". In that case\nit is caused by the vi bindings that were introduced by 60aa065f69. It\nseems that a binding for is also triggered by ctrl-j (if you\nhave a long diff you can see the diff pane scroll down by one line).\n\nI'm not sure how to explain why ctrl-u doesn't work though, as I can't\nsee any binding for , but maybe this gives a clue to someone who\nknows more about TCL than I do.\n\n(It's not Windows-specific, btw: the same problem exists on Mac with\nCommand-U and Command-J.)\n\n\n-- \nStefan Haller\nBerlin, Germany\nhttp://www.haller-berlin.de/\n"}]}