{"thread":{"id":"29446","subject":"[PATCH] docs: minor grammar fixes for v1.7.9 release notes","startedAt":"2012-01-25T22:20:03Z","lastAt":"2012-01-26T19:27:21Z","messageCount":3,"participants":["Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"183098","messageId":"20120125222002.GA6309@sigill.intra.peff.net","threadId":"29446","inReplyTo":null,"subject":"[PATCH] docs: minor grammar fixes for v1.7.9 release notes","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-01-25T22:20:03Z","receivedAt":"2012-01-25T22:20:03Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"\nSigned-off-by: Jeff King \n---\nEasier to view with --color-words, of course.\n\nI also looked through \"git log --first-parent v1.7.8..master\" to see if\nanything had been missed. I think you hit the feature highlights pretty\nwell (I notice you mostly include features and not bug-fixes, which I\nassume is to keep the list to a readable length).\n\n Documentation/RelNotes/1.7.9.txt | 13 +++++++------\n 1 files changed, 7 insertions(+), 6 deletions(-)\n\ndiff --git a/Documentation/RelNotes/1.7.9.txt b/Documentation/RelNotes/1.7.9.txt\nindex f1294b4..95320aa 100644\n--- a/Documentation/RelNotes/1.7.9.txt\n+++ b/Documentation/RelNotes/1.7.9.txt\n@@ -12,19 +12,20 @@ Updates since v1.7.8\n \n * Git uses gettext to translate its most common interface messages\n into the user's language if translations are available and the\n- locale is appropriately set. Distributors can drop in new PO files\n+ locale is appropriately set. Distributors can drop new PO files\n in po/ to add new translations.\n \n- * The code to handle username/password for HTTP transaction used in\n+ * The code to handle username/password for HTTP transactions used in\n \"git push\" & \"git fetch\" learned to talk \"credential API\" to\n external programs to cache or store them, to allow integration with\n platform native keychain mechanisms.\n \n- * The prompted input in the terminal use our own getpass() replacement\n- when possible. HTTP transactions used to ask username without echoing\n- back what was typed, but with this change you will see it as you type.\n+ * The input prompts in the terminal use our own getpass() replacement\n+ when possible. HTTP transactions used to ask for the username without\n+ echoing back what was typed, but with this change you will see it as\n+ you type.\n \n- * The internal of \"revert/cherry-pick\" has been tweaked to prepare\n+ * The internals of \"revert/cherry-pick\" have been tweaked to prepare\n building more generic \"sequencer\" on top of the implementation that\n drives them.\n \n-- \n1.7.9.rc2.293.gaae2\n"},{"id":"183129","messageId":"7vwr8e2s3n.fsf@alter.siamese.dyndns.org","threadId":"29446","inReplyTo":"20120125222002.GA6309@sigill.intra.peff.net","subject":"Re: [PATCH] docs: minor grammar fixes for v1.7.9 release notes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-01-26T19:15:08Z","receivedAt":"2012-01-26T19:15:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> Signed-off-by: Jeff King \n> ---\n> Easier to view with --color-words, of course.\n\nThanks ;-)\n\n> ... (I notice you mostly include features and not bug-fixes, which I\n> assume is to keep the list to a readable length).\n\nActually my intention regarding fixes are:\n\n - never mention follow-up fixes to new topics merged since v1.7.8 at all;\n\n - omit mentioning trivial fixes that not many people would be bitten by\n and actually be hurt in real life (i.e. typo in an error message); and\n\n - make sure as many fixes are covered in \"Fixes since v1.7.8\" section.\n\nSo \"keep the list short\" is only one-third of the motivation.\n"},{"id":"183130","messageId":"20120126192721.GA10699@sigill.intra.peff.net","threadId":"29446","inReplyTo":"7vwr8e2s3n.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] docs: minor grammar fixes for v1.7.9 release notes","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-01-26T19:27:21Z","receivedAt":"2012-01-26T19:27:21Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Jan 26, 2012 at 11:15:08AM -0800, Junio C Hamano wrote:\n\n> > ... (I notice you mostly include features and not bug-fixes, which I\n> > assume is to keep the list to a readable length).\n> \n> Actually my intention regarding fixes are:\n> \n> - never mention follow-up fixes to new topics merged since v1.7.8 at all;\n> \n> - omit mentioning trivial fixes that not many people would be bitten by\n> and actually be hurt in real life (i.e. typo in an error message); and\n> \n> - make sure as many fixes are covered in \"Fixes since v1.7.8\" section.\n> \n> So \"keep the list short\" is only one-third of the motivation.\n\nThat makes sense.\n\nI was specifically thinking of 02f7914 (remote-curl: don't pass back\nfake refs), because \"git push --mirror\" failing is an often-reported bug\nfor github (and the solution is to upgrade your git client). But looking\nagain, I see that the fix was actually in v1.7.8.2, so it is included by\nthe \"...and all of the fixes in the maintenance releases\" text.\n\nIn general, it seems like most of our fixes go onto the maintenance\ntrack, so the \"fixes\" section of a major release ends up being empty.\nWhich I think is a good thing.\n\n-Peff\n"}]}