{"thread":{"id":"29339","subject":"[PATCH] t2203: fix wrong commit command","startedAt":"2012-01-11T03:21:38Z","lastAt":"2012-01-11T08:09:45Z","messageCount":5,"participants":["Nguyễn Thái Ngọc Duy","Ramkumar Ramachandra","Nguyen Thai Ngoc Duy","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"182306","messageId":"1326252098-2891-1-git-send-email-pclouds@gmail.com","threadId":"29339","inReplyTo":null,"subject":"[PATCH] t2203: fix wrong commit command","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2012-01-11T03:21:38Z","receivedAt":"2012-01-11T03:21:38Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"Add commit message to avoid commit's aborting due to the lack of\ncommit message, not because there are INTENT_TO_ADD entries in index.\n\nSigned-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>\n---\n t/t2203-add-intent.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t2203-add-intent.sh b/t/t2203-add-intent.sh\nindex 58a3299..2543529 100755\n--- a/t/t2203-add-intent.sh\n+++ b/t/t2203-add-intent.sh\n@@ -41,7 +41,7 @@ test_expect_success 'cannot commit with i-t-a entry' '\n \techo frotz >nitfol &&\n \tgit add rezrov &&\n \tgit add -N nitfol &&\n-\ttest_must_fail git commit\n+\ttest_must_fail git commit -m initial\n '\n \n test_expect_success 'can commit with an unrelated i-t-a entry in index' '\n-- \n1.7.3.1.256.g2539c.dirty\n"},{"id":"182310","messageId":"CALkWK0kDBFvssyX2ZPJ9WNzfNXD=wEJoXTRVpFWm1TDKJrvNzA@mail.gmail.com","threadId":"29339","inReplyTo":"1326252098-2891-1-git-send-email-pclouds@gmail.com","subject":"Re: [PATCH] t2203: fix wrong commit command","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2012-01-11T04:21:10Z","receivedAt":"2012-01-11T04:21:10Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Hi Duy,\n\nNguyễn Thái Ngọc Duy wrote:\n> Add commit message to avoid commit's aborting due to the lack of\n> commit message, not because there are INTENT_TO_ADD entries in index.\n\nIs there any way to differentiate between the two kinds of errors, so\nthat we can avoid this in the future?  Can we grep the error message\nfor something, or inspect the exit status?\n\n-- Ram\n"},{"id":"182313","messageId":"CACsJy8CjWBRtj3x3guyu-iJeTYxcRriXKbE=Be-rG=Rmesgt=g@mail.gmail.com","threadId":"29339","inReplyTo":"CALkWK0kDBFvssyX2ZPJ9WNzfNXD=wEJoXTRVpFWm1TDKJrvNzA@mail.gmail.com","subject":"Re: [PATCH] t2203: fix wrong commit command","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2012-01-11T04:43:04Z","receivedAt":"2012-01-11T04:43:04Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"2012/1/11 Ramkumar Ramachandra <artagnon@gmail.com>:\n> Hi Duy,\n>\n> Nguyễn Thái Ngọc Duy wrote:\n>> Add commit message to avoid commit's aborting due to the lack of\n>> commit message, not because there are INTENT_TO_ADD entries in index.\n>\n> Is there any way to differentiate between the two kinds of errors, so\n> that we can avoid this in the future?  Can we grep the error message\n> for something, or inspect the exit status?\n\ncommit exits with 1 in both cases, so no.\n-- \nDuy\n"},{"id":"182314","messageId":"CACsJy8Dkcj4Vbow29SBW52JKu7bkEWzk_S=rTrG+fdxiD0w7xw@mail.gmail.com","threadId":"29339","inReplyTo":"CACsJy8CjWBRtj3x3guyu-iJeTYxcRriXKbE=Be-rG=Rmesgt=g@mail.gmail.com","subject":"Re: [PATCH] t2203: fix wrong commit command","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2012-01-11T04:43:54Z","receivedAt":"2012-01-11T04:43:54Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Wed, Jan 11, 2012 at 11:43 AM, Nguyen Thai Ngoc Duy\n<pclouds@gmail.com> wrote:\n> 2012/1/11 Ramkumar Ramachandra <artagnon@gmail.com>:\n>> Hi Duy,\n>>\n>> Nguyễn Thái Ngọc Duy wrote:\n>>> Add commit message to avoid commit's aborting due to the lack of\n>>> commit message, not because there are INTENT_TO_ADD entries in index.\n>>\n>> Is there any way to differentiate between the two kinds of errors, so\n>> that we can avoid this in the future?  Can we grep the error message\n>> for something, or inspect the exit status?\n>\n> commit exits with 1 in both cases, so no.\n\nbut grepping error message should work, sorry I hit send too fast\n-- \nDuy\n"},{"id":"182328","messageId":"7vmx9u7j92.fsf@alter.siamese.dyndns.org","threadId":"29339","inReplyTo":"1326252098-2891-1-git-send-email-pclouds@gmail.com","subject":"Re: [PATCH] t2203: fix wrong commit command","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2012-01-11T08:09:45Z","receivedAt":"2012-01-11T08:09:45Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}