{"thread":{"id":"29227","subject":"[PATCH] builtin/log: remove redundant initialization","startedAt":"2011-12-21T12:05:27Z","lastAt":"2011-12-21T19:16:03Z","messageCount":2,"participants":["Michael Schubert","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"181571","messageId":"4EF1CB87.8050801@elegosoft.com","threadId":"29227","inReplyTo":null,"subject":"[PATCH] builtin/log: remove redundant initialization","fromName":"Michael Schubert","fromEmail":"mschub@elegosoft.com","sentAt":"2011-12-21T12:05:27Z","receivedAt":"2011-12-21T12:05:27Z","isPatch":true,"sender":{"key":"mschub@elegosoft.com","avatar":null},"body":"\"abbrev\" and \"commit_format\" in struct rev_info get initialized in\ninit_revisions - no need to reinit in cmd_log_init_defaults.\n\nSigned-off-by: Michael Schubert <mschub@elegosoft.com>\n---\n builtin/log.c |    2 --\n 1 files changed, 0 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/log.c b/builtin/log.c\nindex 89d0cc0..7d1f6f8 100644\n--- a/builtin/log.c\n+++ b/builtin/log.c\n@@ -73,8 +73,6 @@ static int decorate_callback(const struct option *opt, const char *arg, int unse\n \n static void cmd_log_init_defaults(struct rev_info *rev)\n {\n-\trev->abbrev = DEFAULT_ABBREV;\n-\trev->commit_format = CMIT_FMT_DEFAULT;\n \tif (fmt_pretty)\n \t\tget_commit_format(fmt_pretty, rev);\n \trev->verbose_header = 1;\n-- \n1.7.8.400.g03f4\n"},{"id":"181593","messageId":"7vaa6lhh1o.fsf@alter.siamese.dyndns.org","threadId":"29227","inReplyTo":"4EF1CB87.8050801@elegosoft.com","subject":"Re: [PATCH] builtin/log: remove redundant initialization","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-12-21T19:16:03Z","receivedAt":"2011-12-21T19:16:03Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}