{"thread":{"id":"29216","subject":"[PATCH] builtin/init-db.c: eliminate -Wformat warning on Solaris","startedAt":"2011-12-20T23:27:41Z","lastAt":"2011-12-21T00:04:17Z","messageCount":2,"participants":["Ævar Arnfjörð Bjarmason","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"181546","messageId":"1324423661-31174-1-git-send-email-avarab@gmail.com","threadId":"29216","inReplyTo":null,"subject":"[PATCH] builtin/init-db.c: eliminate -Wformat warning on Solaris","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2011-12-20T23:27:41Z","receivedAt":"2011-12-20T23:27:41Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Solaris systems we'd warn about an implicit cast of mode_t when we\nprinted things out with the %d format. We'd get this warning under GCC\n4.6.0 with Solaris headers:\n\n    builtin/init-db.c: In function ‘separate_git_dir’:\n    builtin/init-db.c:354:4: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘mode_t’ [-Wformat]\n\nWe've been doing this ever since v1.7.4.1-296-gb57fb80. Just work\naround this by adding an explicit cast.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n builtin/init-db.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin/init-db.c b/builtin/init-db.c\nindex d07554c..0dacb8b 100644\n--- a/builtin/init-db.c\n+++ b/builtin/init-db.c\n@@ -351,7 +351,7 @@ static void separate_git_dir(const char *git_dir)\n \t\telse if (S_ISDIR(st.st_mode))\n \t\t\tsrc = git_link;\n \t\telse\n-\t\t\tdie(_(\"unable to handle file type %d\"), st.st_mode);\n+\t\t\tdie(_(\"unable to handle file type %d\"), (int)st.st_mode);\n \n \t\tif (rename(src, git_dir))\n \t\t\tdie_errno(_(\"unable to move %s to %s\"), src, git_dir);\n-- \n1.7.7.3\n"},{"id":"181549","messageId":"7vmxamiyda.fsf@alter.siamese.dyndns.org","threadId":"29216","inReplyTo":"1324423661-31174-1-git-send-email-avarab@gmail.com","subject":"Re: [PATCH] builtin/init-db.c: eliminate -Wformat warning on Solaris","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-12-21T00:04:17Z","receivedAt":"2011-12-21T00:04:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"I will queue this directly on 'maint', as I do not think it is worth\nfixing immediately on top of 2c050e0 (i18n: mark init-db messages for\ntranslation, 2011-04-10) and merging all the way down to the now-ancient\nv1.7.5.X series.\n\nThanks.\n"}]}