{"thread":{"id":"29204","subject":"[PATCH] Fix capitalization of \"renamelimit\" in docs to agree with code","startedAt":"2011-12-19T00:34:52Z","lastAt":"2011-12-19T01:13:23Z","messageCount":4,"participants":["Pete Harlan","Jakub Narebski","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"181445","messageId":"4EEE86AC.2030802@pcharlan.com","threadId":"29204","inReplyTo":null,"subject":"[PATCH] Fix capitalization of \"renamelimit\" in docs to agree with code","fromName":"Pete Harlan","fromEmail":"pgit@pcharlan.com","sentAt":"2011-12-19T00:34:52Z","receivedAt":"2011-12-19T00:34:52Z","isPatch":true,"sender":{"key":"pgit@pcharlan.com","avatar":null},"body":"Signed-off-by: Pete Harlan \n---\nThe documentation and bash-completion have always capitalized\n\"renamelimit\" as \"renameLimit\". The code has always lowercased the\nwhole name. Repair the docs.\n\n Documentation/diff-config.txt | 2 +-\n Documentation/merge-config.txt | 4 ++--\n contrib/completion/git-completion.bash | 4 ++--\n 3 files changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/diff-config.txt b/Documentation/diff-config.txt\nindex 1aed79e..1b9a314 100644\n--- a/Documentation/diff-config.txt\n+++ b/Documentation/diff-config.txt\n@@ -86,7 +86,7 @@ diff.mnemonicprefix::\n diff.noprefix::\n \tIf set, 'git diff' does not show any source or destination prefix.\n\n-diff.renameLimit::\n+diff.renamelimit::\n \tThe number of files to consider when performing the copy/rename\n \tdetection; equivalent to the 'git diff' option '-l'.\n\ndiff --git a/Documentation/merge-config.txt b/Documentation/merge-config.txt\nindex 861bd6f..fdb3cb6 100644\n--- a/Documentation/merge-config.txt\n+++ b/Documentation/merge-config.txt\n@@ -32,10 +32,10 @@ merge.log::\n \tactual commits that are being merged. Defaults to false, and\n \ttrue is a synonym for 20.\n\n-merge.renameLimit::\n+merge.renamelimit::\n \tThe number of files to consider when performing rename detection\n \tduring a merge; if not specified, defaults to the value of\n-\tdiff.renameLimit.\n+\tdiff.renamelimit.\n\n merge.renormalize::\n \tTell git that canonical representation of files in the\ndiff --git a/contrib/completion/git-completion.bash\nb/contrib/completion/git-completion.bash\nindex cc1bdf9..76f66e1 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2122,7 +2122,7 @@ _git_config ()\n \t\tdiff.ignoreSubmodules\n \t\tdiff.mnemonicprefix\n \t\tdiff.noprefix\n-\t\tdiff.renameLimit\n+\t\tdiff.renamelimit\n \t\tdiff.renames\n \t\tdiff.suppressBlankEmpty\n \t\tdiff.tool\n@@ -2218,7 +2218,7 @@ _git_config ()\n \t\tmerge.\n \t\tmerge.conflictstyle\n \t\tmerge.log\n-\t\tmerge.renameLimit\n+\t\tmerge.renamelimit\n \t\tmerge.renormalize\n \t\tmerge.stat\n \t\tmerge.tool\n-- \n"},{"id":"181446","messageId":"m3ty4xfkpc.fsf@localhost.localdomain","threadId":"29204","inReplyTo":"4EEE86AC.2030802@pcharlan.com","subject":"Re: [PATCH] Fix capitalization of \"renamelimit\" in docs to agree with code","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2011-12-19T00:51:13Z","receivedAt":"2011-12-19T00:51:13Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Pete Harlan writes:\n\n> Signed-off-by: Pete Harlan \n> ---\n> The documentation and bash-completion have always capitalized\n> \"renamelimit\" as \"renameLimit\". The code has always lowercased the\n> whole name. Repair the docs.\n\nKey names are *case insensitive* so we can write it in docs in a way\nthat is more clear, like 'renameLimit'.\n\nCode compares with lowercased key name, so that is why it uses\n'renamelimit'.\n\n> @@ -2122,7 +2122,7 @@ _git_config ()\n> \t\tdiff.ignoreSubmodules\n> \t\tdiff.mnemonicprefix\n> \t\tdiff.noprefix\n> -\t\tdiff.renameLimit\n> +\t\tdiff.renamelimit\n> \t\tdiff.renames\n> \t\tdiff.suppressBlankEmpty\n> \t\tdiff.tool\n\nConsitency - why you change diff.renameLimit but not\ndiff.ignoreSubmodules?\n\n-- \nJakub Narebski\n"},{"id":"181448","messageId":"7vsjkhnzkt.fsf@alter.siamese.dyndns.org","threadId":"29204","inReplyTo":"4EEE86AC.2030802@pcharlan.com","subject":"Re: [PATCH] Fix capitalization of \"renamelimit\" in docs to agree with code","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-12-19T01:02:26Z","receivedAt":"2011-12-19T01:02:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Pete Harlan writes:\n\n> Signed-off-by: Pete Harlan \n> ---\n> The documentation and bash-completion have always capitalized\n> \"renamelimit\" as \"renameLimit\". The code has always lowercased the\n> whole name. Repair the docs.\n\nPlease don't do this.\n\nExactly because we treat the variable name part (and the top-level section\npart of three-part names) case insensitively, the code lowercases before\ncomparing as an implementation detail.\n\nHowever, you will be naming the same variable whether you spell it using\nall lowercase, or using camelCase (i.e. it does not really matter what\ncase the user uses). The camelCase makes it slightly easier to see where\nthe word boundaries are than alllowercase, and that is why we try to use\nit in our documentes, which is after all meant to be read by humans.\n\nI would also appreciate if people tried not to overflow my mailbox with an\nincorrect patch that hasn't been discussed and hasn't seen concensus on\nthe list that the particular change is a good thing to do, unless the\npatch is about an area that I am an area expert (you can see who the area\nexperts are by asking \"git shortlog --no-merges -n\" or \"git blame\").\n\nThanks.\n"},{"id":"181449","messageId":"4EEE8FB3.7070206@pcharlan.com","threadId":"29204","inReplyTo":"7vsjkhnzkt.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] Fix capitalization of \"renamelimit\" in docs to agree with code","fromName":"Pete Harlan","fromEmail":"pgit@pcharlan.com","sentAt":"2011-12-19T01:13:23Z","receivedAt":"2011-12-19T01:13:23Z","isPatch":true,"sender":{"key":"pgit@pcharlan.com","avatar":null},"body":"On 12/18/2011 05:02 PM, Junio C Hamano wrote:\n> Pete Harlan writes:\n> \n>> Signed-off-by: Pete Harlan \n>> ---\n>> The documentation and bash-completion have always capitalized\n>> \"renamelimit\" as \"renameLimit\". The code has always lowercased the\n>> whole name. Repair the docs.\n> \n> Please don't do this.\n\nSorry for the spam. There was a circumstance at work where it appeared\nclear that case wasn't being ignored and it bit us twice. Obviously our\nproblem lies elsewhere; please forgive the intrusion.\n\nSubmittingPatches says to send to you directly if (and only if) the\npatch is ready for inclusion. Next time I won't presume that a patch is\nready without review however obvious that may seem to me at the time.\n\n--Pete\n\n> Exactly because we treat the variable name part (and the top-level section\n> part of three-part names) case insensitively, the code lowercases before\n> comparing as an implementation detail.\n> \n> However, you will be naming the same variable whether you spell it using\n> all lowercase, or using camelCase (i.e. it does not really matter what\n> case the user uses). The camelCase makes it slightly easier to see where\n> the word boundaries are than alllowercase, and that is why we try to use\n> it in our documentes, which is after all meant to be read by humans.\n> \n> I would also appreciate if people tried not to overflow my mailbox with an\n> incorrect patch that hasn't been discussed and hasn't seen concensus on\n> the list that the particular change is a good thing to do, unless the\n> patch is about an area that I am an area expert (you can see who the area\n> experts are by asking \"git shortlog --no-merges -n\" or \"git blame\").\n> \n> Thanks.\n"}]}